From: Liliana Marie Prikler <liliana.prikler@ist.tugraz.at>
To: Luis Felipe <luis.felipe.la@protonmail.com>
Cc: 61236@debbugs.gnu.org
Subject: bug#61236: ibus-speech-to-text engine fails to run (?)
Date: Wed, 08 Feb 2023 08:32:43 +0100 [thread overview]
Message-ID: <4240a5efd5a902d1ac006da472922a90580c9961.camel@ist.tugraz.at> (raw)
In-Reply-To: <maZwVJL3NGR0wzfQ4Rfk5n5jQBUzJfHu6RELvGir9xt8PIJLOWNR4okKL7rwqxObkbdo3vc9LrCqYXZzUN6QlRSscbkJnG15maN1d7Gyldo=@protonmail.com>
Am Dienstag, dem 07.02.2023 um 16:41 +0000 schrieb Luis Felipe:
> Hi,
>
> The attached patch fixed the issue for me. Now ibus-engine-stt seems
> to be running correctly and I can switch to the input method without
> the workaround indicated in the initial report.
>
> I noticed that there are some lint issues from the original package
> definition though. I didn't fixed those:
>
> $ ./pre-inst-env guix lint ibus-speech-to-text
> /home/yo/guix/gnu/packages/ibus.scm:899:5: ibus-speech-to-text@0.4.0:
>
> [1] 'desktop-file-utils' should probably be a native input
>
> /home/yo/guix/gnu/packages/ibus.scm:899:5: ibus-speech-to-text@0.4.0:
>
> [2] 'glib:bin' should probably be a native input
>
> /home/yo/guix/gnu/packages/ibus.scm:899:5: ibus-speech-to-text@0.4.0:
>
> [3] 'gobject-introspection' should probably be a native input
>
> /home/yo/guix/gnu/packages/ibus.scm:899:5: ibus-speech-to-text@0.4.0:
>
> [4] label 'glib' does not match package name 'glib:bin'
>
> /home/yo/guix/gnu/packages/ibus.scm:856:2: ibus-speech-to-text@0.4.0:
>
> [5] "bash-minimal" should be in 'inputs' when 'wrap-program' is used
All but [4] should be fixed. Can you attach a separate patch to do so?
(If possible, use `git send-email` with a reroll count of 2, so that CI
and mumi-based workflows behave as intended.)
> * gnu/packages/ibus.scm (ibus-speech-to-text)[phases]:
Should probably be #:phases.
> Remove path to ibus-stt directory from GI_TYPELIB_PATH, since it
> doesn't provide typelibs.
Should probably be "Use getenv to set GUIX_PYTHONPATH."
> Remove path to ibus' typelibs directory from GUIX_PYTHONPATH, since
> it doesn't provide Python modules.
I think you should also use getenv here. I think we should mimic
python-build-system here and add the output directory to
GUIX_PYTHONPATH before it gets wrapped.
> Remove unnecessary delimiters from all environment variables.
I don't think it's necessary to remove them ;)
Cheers
next prev parent reply other threads:[~2023-02-08 7:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 19:46 bug#61236: ibus-speech-to-text engine fails to run (?) Luis Felipe via Bug reports for GNU Guix
2023-02-03 7:14 ` Liliana Marie Prikler
2023-02-03 17:07 ` Luis Felipe via Bug reports for GNU Guix
2023-02-07 16:41 ` Luis Felipe via Bug reports for GNU Guix
2023-02-08 7:32 ` Liliana Marie Prikler [this message]
2023-02-09 19:33 ` Luis Felipe via Bug reports for GNU Guix
2023-02-10 6:42 ` Liliana Marie Prikler
2023-02-09 19:38 ` bug#61236: [PATCH v1] gnu: ibus-speech-to-text: Fix execution of ibus-engine-stt sirgazil--- via Bug reports for GNU Guix
2023-02-10 18:49 ` bug#61236: [PATCH v2 1/2] " sirgazil--- via Bug reports for GNU Guix
2023-02-10 18:49 ` bug#61236: [PATCH v2 2/2] gnu: ibus-speech-to-text: Fix lint warnings sirgazil--- via Bug reports for GNU Guix
2023-02-12 7:53 ` Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4240a5efd5a902d1ac006da472922a90580c9961.camel@ist.tugraz.at \
--to=liliana.prikler@ist.tugraz.at \
--cc=61236@debbugs.gnu.org \
--cc=luis.felipe.la@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).