From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id MP2aKGuii1/IQAAA0tVLHw (envelope-from ) for ; Sun, 18 Oct 2020 02:03:23 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id kOtfJGuii187OgAAB5/wlQ (envelope-from ) for ; Sun, 18 Oct 2020 02:03:23 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 582BE940112 for ; Sun, 18 Oct 2020 02:03:22 +0000 (UTC) Received: from localhost ([::1]:53190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTy2a-0004w8-2P for larch@yhetil.org; Sat, 17 Oct 2020 22:03:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41874) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTy2L-0004w0-6R for bug-guix@gnu.org; Sat, 17 Oct 2020 22:03:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52619) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kTy2H-0005Ea-OI for bug-guix@gnu.org; Sat, 17 Oct 2020 22:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kTy2H-0003Qw-Km for bug-guix@gnu.org; Sat, 17 Oct 2020 22:03:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#44027: [PATCH] installer: Create bios_grub partition when it is needed. Resent-From: Brendan Tildesley Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 18 Oct 2020 02:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44027 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas , Brett Gilio Received: via spool by 44027-submit@debbugs.gnu.org id=B44027.160298656113168 (code B ref 44027); Sun, 18 Oct 2020 02:03:01 +0000 Received: (at 44027) by debbugs.gnu.org; 18 Oct 2020 02:02:41 +0000 Received: from localhost ([127.0.0.1]:35932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTy1x-0003QK-Ck for submit@debbugs.gnu.org; Sat, 17 Oct 2020 22:02:41 -0400 Received: from mout-p-201.mailbox.org ([80.241.56.171]:24354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTy1v-0003Q5-IV for 44027@debbugs.gnu.org; Sat, 17 Oct 2020 22:02:40 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4CDNST3mSnzQlWB; Sun, 18 Oct 2020 04:02:33 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brendan.scot; s=MBO0001; t=1602986551; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a+qtRf3TeXUWx87UloWNn1B5qxdp53mkoiCqi23YlWA=; b=nmXOWp8ein6Qr1P8BQYcFCOUHpm4/0j3mHBRJ522wntdsYNLvIYzOFeprnLMKTGk4TgFZE rCJF5y6UiF+l/sp1kHH9RUqpgU0ohIMAdZffHw3mx7cRazVQn572rLm0Urr3vgjkfAmYQ0 hFGWr0w618vXQ4J0juUaKxc+qmfFQdueKh/iERSwAYW/v6ZYm7mjANARXC8wW8FwlmW1pb WFGn+g01axclF9F53VEmZKGsPdFjG7JcwcfLGX0u2rl/0/zpVfjtXRwuBnMzB4KN5+uMbu ouZWZ/CBrCiYdq1cixO6ts3f/13cDjr303+Bx6yDe63NbBpJpF0La6+UGeWf5w== Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter06.heinlein-hosting.de (spamfilter06.heinlein-hosting.de [80.241.56.125]) (amavisd-new, port 10030) with ESMTP id OIvzC8LGYmIX; Sun, 18 Oct 2020 04:02:29 +0200 (CEST) References: <76f35a63-62e8-4653-865b-b14bb273db34@brendan.scot> <87lfg65jho.fsf@gnu.org> <878sc5wzld.fsf@debian> <87pn5hq9rs.fsf_-_@gmail.com> From: Brendan Tildesley Message-ID: <418d612d-ef7c-ea58-2df2-80e4bb73ed4b@brendan.scot> Date: Sun, 18 Oct 2020 13:02:20 +1100 MIME-Version: 1.0 In-Reply-To: <87pn5hq9rs.fsf_-_@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-MBO-SPAM-Probability: X-Rspamd-Score: -6.26 / 15.00 / 15.00 X-Rspamd-Queue-Id: 3CB9B16FE X-Rspamd-UID: f852fa X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: othacehe@gnu.org, 44027@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=brendan.scot header.s=MBO0001 header.b=nmXOWp8e; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -0.01 X-TUID: J81oXhvOFZHG On 17/10/20 11:09 pm, Miguel Ángel Arruga Vivas wrote: > Hi, > > Brett Gilio writes: >> Ludovic Courtès writes: >>> Shouldn’t it create a “legacy” partition table rather than GPT since >>> we’re on an old, non-UEFI platform? >> That is my thinking as well, it should create a legacy MBR table. > IMHO the old format should be avoided completely when possible. Why > should we enforce it? > > I think this problem involves having a previous ESP partition on the > disk (at least identified as such by parted), because auto-partition! > currently checks that before checking if the booted system has EFI > support. When that's the case, it doesn't create the needed bios_grub > partition that might have been removed previously. > > The attached patch solves that. What do you think? > > Happy hacking, > Miguel I'm about to give it a test run. Unrelated to the patch, but, I'm building the installer (gnu/system/install.scm) on latest master and I get the following warnings/errors, although it doesn't stop the build from completing. is it a bug? https://paste.debian.net/plain/1167398