From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aJQWAbQ3lWEvcAAAgWs5BA (envelope-from ) for ; Wed, 17 Nov 2021 18:11:16 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id cMhIOLM3lWGKAgAA1q6Kng (envelope-from ) for ; Wed, 17 Nov 2021 17:11:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BF5852CD47 for ; Wed, 17 Nov 2021 18:11:15 +0100 (CET) Received: from localhost ([::1]:40904 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mnOSo-0002jL-V4 for larch@yhetil.org; Wed, 17 Nov 2021 12:11:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42750) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnOSc-0002g8-6c for bug-guix@gnu.org; Wed, 17 Nov 2021 12:11:06 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:50420) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mnOSb-0005Lx-Tn for bug-guix@gnu.org; Wed, 17 Nov 2021 12:11:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mnOSb-00074u-Pv for bug-guix@gnu.org; Wed, 17 Nov 2021 12:11:01 -0500 Subject: bug#51869: [PATCH] Add emacs-vala-mode Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Wed, 17 Nov 2021 17:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 51869 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Vivien Kraus Mail-Followup-To: 51869@debbugs.gnu.org, liliana.prikler@gmail.com, vivien@planete-kraus.eu Received: via spool by 51869-done@debbugs.gnu.org id=D51869.163716900427084 (code D ref 51869); Wed, 17 Nov 2021 17:11:01 +0000 Received: (at 51869-done) by debbugs.gnu.org; 17 Nov 2021 17:10:04 +0000 Received: from localhost ([127.0.0.1]:33729 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnORg-00072l-0u for submit@debbugs.gnu.org; Wed, 17 Nov 2021 12:10:04 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:51775) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnORd-000729-W5 for 51869-done@debbugs.gnu.org; Wed, 17 Nov 2021 12:10:02 -0500 Received: by mail-wm1-f68.google.com with SMTP id z200so2897994wmc.1 for <51869-done@debbugs.gnu.org>; Wed, 17 Nov 2021 09:10:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=T9l0Q6RphdEKZPHUdcviFvSSw+M/9pfs7w8K8Fqi2f8=; b=K2ViAd68Vteo4m9P8G4DeNk6FbASiD9HU/uyMzplLoI4CKDN4Zb53IZH6XL9IM/9Np bOMmRqgpl7MKWYd/oe5MeRKj4NsXhfOajYHeLzzlDrVBDSh5W/rlkB+dqIePHcubjTmJ EOYRPH/3a/XKM7OMsSFqJuVslKR2t4Y0EE+FJaGQtC3yLVnWzZJEnDy8tiEUqXV1a1wZ wkFDGX/07qdUGCSfVtHQmM0uOJ7riEpEmk11pw36JI6rAElrxlZ0RqxuhzrQIV+dXrxE S1SBhiyd2TGiPBVDj8ONkX54A4cpe93mNaRLS0VBRCxLMYNIzYs3HlkN57YG4xroU0du E7Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=T9l0Q6RphdEKZPHUdcviFvSSw+M/9pfs7w8K8Fqi2f8=; b=zaqNx60KVbWni6Beq137lhE17Dm8pLEmXTreQEQGSAgbDhfDIYO5UyA/0BEflOJQmP 938jXWaCSIbU6NAS26d/UdMO+pNg7dVUuZxaTQO0JUzCGVr+FSrGzPOP66ZuTcFwZeTO sq4W4W2tyhcYmm9aVVtP4g/SJhWHQyeTbXEqtL7n/cz890/jv5AhfXb2WveeJkHE/6XK T1iJGXqeVJMFWOspm55Sof0QEtMJGqrvK08+hIvdA8NVMmwu1p7rQdDO+B713nuw1g2n vScBVnNhZ9yhPSKegmU96GS4unJ0a2zCscU7WZL9kybEUEWo41fM4m4jGeFbriZO4Q/G Laow== X-Gm-Message-State: AOAM532MfwveMUqFtA+HGQX9aJa1wlOxm+//2sEFUHa6oJkGzCvZSI0x BvY9+/NNj3yH/R6aBx+/VFA= X-Google-Smtp-Source: ABdhPJx6hKNNNObrckng6P66b0tDsbWyMMbjdRFxFexJNFG7eMFTW5vW+Z7iqYZl/81QUmZpOIV75w== X-Received: by 2002:a1c:7c02:: with SMTP id x2mr1372264wmc.165.1637168995957; Wed, 17 Nov 2021 09:09:55 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id p12sm621601wrr.10.2021.11.17.09.09.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Nov 2021 09:09:55 -0800 (PST) Message-ID: <3df08e59131fca25380c16ac697ef45076257b6b.camel@gmail.com> From: Liliana Marie Prikler Date: Wed, 17 Nov 2021 18:09:53 +0100 In-Reply-To: <87zgq3svut.fsf@planete-kraus.eu> References: <87pmr14ipx.fsf@planete-kraus.eu> <93b000a9d4d893e23e7b55d306aa385eeca19c78.camel@gmail.com> <878rxp3yuk.fsf@planete-kraus.eu> <874k8ct16t.fsf@planete-kraus.eu> <8490cb54de7cc4b18ff7a66f36b0a226826ebbbb.camel@gmail.com> <87zgq3svut.fsf@planete-kraus.eu> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 51869-done@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637169075; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=T9l0Q6RphdEKZPHUdcviFvSSw+M/9pfs7w8K8Fqi2f8=; b=Ni6wW9oHM/tne37vEE0NH8bfhlTgk1RjiUWSptjMi7UWtu+0cBC4fLQTC0Xi8p9OO34XSm jYQ4SuWaHjl4BcazhRU/MkCITq/z1hY/nuVrHjHC69Cnp4swooPJ4HewNLG4kQhb7OoLPu zAi6vJZhcklTpnd/drEMZb1t95szfj9hhz25DgEfwn0jn5ABBOa9khADoCeIXi1jFhBNaL ppt5NITZII/BB9nxnU+9EvYmiXB2dV3h+I5U8h4HLPgLTEOtcWEn+Yztg3YtwNo3RaoTBO kGK1qY54gJ/3nUgJA1f7zcB4Dg9BXz6zTzCyU3w3otIE9bLsAQdKAtmjnPjYSA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637169075; a=rsa-sha256; cv=none; b=PtZSWaA75fnMHBalEpmshPpbaiQr6Dc1e66JbAmf2+dJalzw33HLsj4VmU1v8SaNC9AIEO JAYpHmLfU5GyvrGBiwG3G2tEdad0vOOBHEl3FSnZgNnuo1YFerx+i7tTSaOLS29T05vB4b jIFc0p273dZEvEyS6f7ZZ7GskveV9R7ZO0Q23eQ4y8so0UjTgV9JVKOp5R2cvxP5QBc10O 7IEzB3200lHHi+8ELQkVk0a7nanGxF3blOzGLeqVGUxAhGf3PHJkma6Dp6r3tmXZV535ID 4z92ZP0SVhgVbUe+6ilc+8EtISK7LNb2aA69vIq3Z8PTOmnlkagsVJPXt+V4yw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=K2ViAd68; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.86 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=K2ViAd68; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BF5852CD47 X-Spam-Score: -1.86 X-Migadu-Scanner: scn0.migadu.com X-TUID: sjifsfTIYhN6 Hi, Am Dienstag, den 16.11.2021, 19:48 +0000 schrieb Vivien Kraus: > > > + (emacs-substitute-sexps "vala-mode.el" > > > + (";; Support multiline strings" 'disabled.) > > > + ("(defcustom vala-multiline-strings nil" > > > + "This variable is ignored."))))))) > > This inserts mostly bogus into the file rather than killing the > > sexps > > as it should. > > The first substitution fully kills the whole sexp (and inserts a > comment that reads "Support for multiline strings disabled." if you > don’t read too closely ^^). That was too sneaky for me :P > It’s true that the second does not kill the defcustom expansion, but > since it’s part of the intended public API, I’m not so sure we should > remove it altogether. I think it’s clearer for the user that way, > because the two modifications are kind of documented in the source. > > Also, it’s shorter. I'm pretty sure you can still use vala-multiline-strings inside a custom-set-variables form, it will just do nothing as it ought to. > Anyway, Here are the two versions, you decide. I rewrote your batch-edit version to be a little clearer and to leave documented FIXMEs in the code. I pushed the rewrite, so you should now be able to use emacs-vala-mode, with or without lsp. Cheers