From: Bruno Victal <mirai@makinata.eu>
To: Greg Hogan <code@greghogan.com>, Andy Tai <atai@atai.org>
Cc: 63526@debbugs.gnu.org
Subject: bug#63526: [PATCH] gnu: hubbub: Disable building tests
Date: Thu, 25 May 2023 14:35:17 +0100 [thread overview]
Message-ID: <3c4419ef-5d5e-451f-8985-ef4b8e06d068@makinata.eu> (raw)
In-Reply-To: <CA+3U0ZnSpb-Rdws3AuFtf5=NAZYKjs0J7wc-Wyh0gg6iWffRQQ@mail.gmail.com>
On 2023-05-25 14:02, Greg Hogan wrote:
> Hi Andy,
>
> Disabling tests should be a last resort, especially without a process
> to evaluate re-enabling tests in the future.
I concur.
A test failure, unless it is caused by things such as “requiring
network access” or is expected due to guix specifics should be
considered a problem with the package. (if tests are disabled simply
because they happen to fail without doing any investigation, why have
tests at all?)
> Based on the error, can we instead add
> "-Wno-error=maybe-uninitialized" to the configure-flags?
I'd report this upstream first, it can be the case that the error
(which is being flagged by the compiler) is unmasking a real bug
upstream.
--
Furthermore, I consider that nonfree software must be eradicated.
Cheers,
Bruno.
next prev parent reply other threads:[~2023-05-25 13:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 19:24 bug#63526: hubbub build failure when doing guix package -u Andy Tai
2023-05-22 6:44 ` bug#63526: [PATCH] gnu: hubbub: Disable building tests Andy Tai
2023-05-25 13:02 ` Greg Hogan
2023-05-25 13:35 ` Bruno Victal [this message]
2023-05-25 17:54 ` Andy Tai
2023-05-27 7:29 ` bug#63526: [PATCH v2] gnu (hubbub): Fix build Andy Tai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c4419ef-5d5e-451f-8985-ef4b8e06d068@makinata.eu \
--to=mirai@makinata.eu \
--cc=63526@debbugs.gnu.org \
--cc=atai@atai.org \
--cc=code@greghogan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).