From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 06fYAqNXj2BahgAAgWs5BA (envelope-from ) for ; Mon, 03 May 2021 03:53:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 4Il6OaJXj2BYKAAAbx9fmQ (envelope-from ) for ; Mon, 03 May 2021 01:53:38 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 15B49E9F9 for ; Mon, 3 May 2021 03:53:38 +0200 (CEST) Received: from localhost ([::1]:54804 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldNmD-0006Lo-4N for larch@yhetil.org; Sun, 02 May 2021 21:53:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58118) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldNjx-0004iB-QF for bug-guix@gnu.org; Sun, 02 May 2021 21:51:17 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34392) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ldNji-0007hv-24 for bug-guix@gnu.org; Sun, 02 May 2021 21:51:17 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ldNjh-0005hQ-Vz for bug-guix@gnu.org; Sun, 02 May 2021 21:51:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#48166: Dont stop the upgrade process - Better guix handling when Package failed to build Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 03 May 2021 01:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48166 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: bo0od ,Leo Famulari Received: via spool by 48166-submit@debbugs.gnu.org id=B48166.162000665421900 (code B ref 48166); Mon, 03 May 2021 01:51:01 +0000 Received: (at 48166) by debbugs.gnu.org; 3 May 2021 01:50:54 +0000 Received: from localhost ([127.0.0.1]:45938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldNja-0005hA-8Y for submit@debbugs.gnu.org; Sun, 02 May 2021 21:50:54 -0400 Received: from lepiller.eu ([89.234.186.109]:36092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldNjW-0005h4-Fx for 48166@debbugs.gnu.org; Sun, 02 May 2021 21:50:53 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 3f63c959; Mon, 3 May 2021 01:50:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date :in-reply-to:references:mime-version:content-type :content-transfer-encoding:subject:to:cc:from:message-id; s= dkim; bh=W4kTfreUGAE5+9OtKHl2NqViiIICZ/D7OE2idT2N3nI=; b=AZpExTN 9asRRR+9B2E9bA7/32/EZ+u9tFeFuOiGIJSzbqZTRbyCjXLQH1c8abrBegLZqO4S mYH2FkmqJ6rkZIPkCqwxp5v6N9g+RHeQoTG/51gpeaX/5UHtd2QH4Zxac3r3fM4H s1P06t1ECsvNHn11Uy200D39LWtTjUTeGyMBrIDe2FbSJ3OWQK6lYN6zZ3mRzZ/D wk64V24ZXPIhcoD4p2Xqzu4aoczaCdYAMtE/5EB+4UjUfnqUP0Upgnaapir/gB4T d4eixSVx8xgOEEvuaEFBkBKm8VW9FVLaJMcSwNEwqXw9/aEM+1Q5/UpNnzdn3k4z Kz2/lJy7LK8TVjw== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 8981550f (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Mon, 3 May 2021 01:50:47 +0000 (UTC) Date: Sun, 02 May 2021 21:50:39 -0400 User-Agent: K-9 Mail for Android In-Reply-To: References: MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----S8L3RX4DXJK9CL3RHXUE0KGJE0NQX3" Content-Transfer-Encoding: 7bit From: Julien Lepiller Message-ID: <3C1DFBAD-68E9-4B7C-9610-222DAFF8A745@lepiller.eu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 48166@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620006818; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=uMfZp2EPO8FqbL3YpFiKpxzXJC9b/plO0T/QAnx+EM0=; b=T+RyujmS09XRyhtEwgWwRY1t9u6JUwbsFjw22XyPA6sO8CELbdEATmba1XXzk2cpSuSPp0 UIy4XmEca18Hghp9ngJNkEOFpzvkyGVuljs4f0kFFK9Tgrtdj2w8KMmJWWf6ETnHsU2UBh H8wPLBrzb1evQq9teI/ExzMlLib/xdOjCERMoUc7qqN763kjny48cZ5/cTmDD+Z704HnbJ 9fhE90BtMJqVhJJWhNLkOSD8kzS7lFRB9Ejo6gSGbtnalZe1pmAgFxX9ka4ehQovLk+SqD gxvjoJ024cWVSIoxkNPtRE5nQ9QfLGXc6CMtEUsuVi6YO2LAAEKGSDgaAmOSDg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620006818; a=rsa-sha256; cv=none; b=aeikMPr2QMEu/HRnaO4GVgqHccB/QM80/L39EdKFsMASrZTVwFXizZpX4PnpmKYFDDnTLY GkRHDg+EopcdvQ8OUx/jGS7emrHQyr4CRb5iCW+X2vhL/hyS/V7jZ5BD6ucgpcmSKXOcZl HNP/3A2n7vYXbGyI2aF9jOQae7aNOCSjFZVV5LT69Kiv1TB9BMzmnvXtuXVA0IbjU1hiTT 9xcx69Oqrx+ToHpn3toaIFNZZ+657CbF91CWwSq86RKTZ2m/Acsmheip/TWv9LtSdKgY7M ZL8MNJW4kd+55HsjBeHPRaN5jg3RJChKp9HGhDAmC7ocGL18MgP6Ob//L+x46A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b="AZpExTN "; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -1.36 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b="AZpExTN "; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 15B49E9F9 X-Spam-Score: -1.36 X-Migadu-Scanner: scn0.migadu.com X-TUID: /4LrLB7U4cav ------S8L3RX4DXJK9CL3RHXUE0KGJE0NQX3 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I don't think --keep-going works as you expect it to=2E When you do guix up= grade, guix creates a derivation for your new profile and proceeds to build= it=2E If it has dependents that need to be built (packages that were updat= ed), it builds them as they are needed to build the new profile=2E If one of them fails, guix fails early by default=2E --keep-going will, we= ll, keep going and guix will build the rest of the dependents that are inde= pendent from that failure=2E However, it will eventually fail (late) when it tries to finally build the= derivation for the new derivation: itqdepends on other derivations that al= ready failed=2E Not sure how it reports the failures, but it might be easie= r to list all the failures in one try, and apply your workaround=2E To do what you want (create a new generations ignoring failures) is not ea= sy to implement=2E We would have to "change our mind" and build a different= derivation for that new profile=2E Le 2 mai 2021 21:00:02 GMT-04:00, bo0od a =C3=A9crit = : > > I think you can use `guix package --upgrade =2E --keep-going`: > >Thank you for the hint, sorry i didnt know this command exist=2E > >Currently i cant test this because i dont have a package which has an=20 >error in the building (previous icedove bug should be fixed) to see how > >this is going to go=2E > >- First question: > >Why this is not default? and what not default should be: > >--stop-at-error or --dont-proceed-error =2E=2E(or whatever) > >- Second question: > >Does it show the error at the end or during the upgrade or both (same >as=20 >my example before)? So user is aware that one or more of his packages=20 >didnt upgraded=2E > >- If second question is yes then that command can replace=20 >--do-not-upgrade in my previous workaround faster implementation but >not=20 >ultimate=2E > > > > >Leo Famulari: >> On Sun, May 02, 2021 at 08:29:31PM +0000, bo0od wrote: >>> Current (manual) solution is: >>> >>> guix package --upgrade =2E --do-not-upgrade x >>=20 >> I think you can use `guix package --upgrade =2E --keep-going`: >>=20 >> >https://guix=2Egnu=2Eorg/manual/devel/en/html_node/Common-Build-Options= =2Ehtml >>=20 >> --keep-going >> -k >>=20 >> Keep going when some of the derivations fail to build; return >only once all the builds have either completed or failed=2E >>=20 >> The default behavior is to stop as soon as one of the specified >derivations has failed=2E >>=20 ------S8L3RX4DXJK9CL3RHXUE0KGJE0NQX3 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable I don't think --keep-going works as you expect it = to=2E When you do guix upgrade, guix creates a derivation for your new prof= ile and proceeds to build it=2E If it has dependents that need to be built = (packages that were updated), it builds them as they are needed to build th= e new profile=2E

If one of them fails, guix fails early by default= =2E --keep-going will, well, keep going and guix will build the rest of the= dependents that are independent from that failure=2E

However, it wi= ll eventually fail (late) when it tries to finally build the derivation for= the new derivation: itqdepends on other derivations that already failed=2E= Not sure how it reports the failures, but it might be easier to list all t= he failures in one try, and apply your workaround=2E

To do what you = want (create a new generations ignoring failures) is not easy to implement= =2E We would have to "change our mind" and build a different derivation for= that new profile=2E

Le 2 mai 2021 21:00:= 02 GMT-04:00, bo0od <bo0od@riseup=2Enet> a =C3=A9crit :
I t=
hink you can use `guix package --upgrade =2E --keep-going`:

Thank you for the hint, sorry i didnt know this command exist=2E
Currently i cant test this because i dont have a package which has an error in the building (previous icedove bug should be fixed) to see how this is going to go=2E

- First question:

Why this is not de=
fault? and what not default should be:

--stop-at-error or --dont-pro=
ceed-error =2E=2E(or whatever)

- Second question:

Does it sho=
w the error at the end or during the upgrade or both (same as 
my exampl=
e before)? So user is aware that one or more of his packages 
didnt upgr=
aded=2E

- If second question is yes then that command can replace --do-not-upgrade in my previous workaround faster implementation but not =

ultimate=2E




Leo Famulari:
On Sun, May 02, 2021 at 08:29:31PM +0000, bo0od w=
rote:
 Current (manua=
l) solution is:

 guix package --upgrade =2E --do-not-upgrade x

I think you can use `guix package --upgrade =2E --keep-going=
`:

https://guix=2Egnu=2Eorg/manual/devel/en/html_nod=
e/Common-Build-Options=2Ehtml

--keep-going
-k

     Kee=
p going when some of the derivations fail to build; return only once all th=
e builds have either completed or failed=2E

     The default behavio=
r is to stop as soon as one of the specified derivations has failed=2E
<=
br>



------S8L3RX4DXJK9CL3RHXUE0KGJE0NQX3--