unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Eric Blake <eblake@redhat.com>
To: "Glenn Morris" <rgm@gnu.org>, "Ludovic Courtès" <ludo@gnu.org>
Cc: 25969@debbugs.gnu.org
Subject: bug#25969: guix-patches debbugs appears to mangle patches
Date: Mon, 6 Mar 2017 11:54:56 -0600	[thread overview]
Message-ID: <398d7c29-a7c4-f600-49f1-e7db9562b509@redhat.com> (raw)
In-Reply-To: <nashmqz4aw.fsf@fencepost.gnu.org>


[-- Attachment #1.1: Type: text/plain, Size: 1638 bytes --]

On 03/06/2017 11:46 AM, Glenn Morris wrote:
> Ludovic Courtès wrote:
> 
>> Hello!
>>
>> Leo Famulari <leo@famulari.name> skribis:
>>
>>> The guix-patches debbugs thing causes a regression in this workflow by
>>> rewriting the commit messages to include the debbugs ticket number.
>>>
>>> So, a commit that begins with this:
>>>
>>> gnu: gitolite: Fix shebangs in hooks.
>>>
>>> ... becomes this:
>>>
>>> bug#25966: [PATCH 2/2] gnu: gitolite: Fix shebangs in hooks.
>>>
>>> Am I missing something, or is debbugs really rewriting the patches?
>>
>> Good question.  Maybe Glenn and others at help-debbugs have an idea?
> 
> I think it's over the top to describe this as "mangling" or "rewriting"
> patches. The system relies on adding a bug number to the subject, so
> that replies to the maintainer address can be associated with the right
> bug. I don't see any prospect of this changing. If you are using a tool
> that is sensitive to the subject line in emails, I can only suggest
> using eg a trivial sed command to take out the bug number before passing
> the mail to your tool.

'git am' already knows how to strip anything inside one or more [text]
prefix of the subject. I don't know how hard it would be to convince the
GNU debbugs instance to output '[bug#25969] ' instead of its current
'bug#25969: ' (and of course to also recognize both spellings on input,
when checking for existing mails in reply to existing bugs), but such a
tweak would play nicer with a git patch workflow.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

      parent reply	other threads:[~2017-03-06 17:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-04 22:54 bug#25969: guix-patches debbugs appears to mangle patches Leo Famulari
2017-03-05 12:34 ` ng0
2017-03-05 12:37 ` ng0
2017-03-06 10:16 ` Ludovic Courtès
     [not found] ` <87a88yww0m.fsf@gnu.org>
2017-03-06 17:46   ` Glenn Morris
     [not found]   ` <nashmqz4aw.fsf@fencepost.gnu.org>
2017-03-06 17:54     ` Eric Blake [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=398d7c29-a7c4-f600-49f1-e7db9562b509@redhat.com \
    --to=eblake@redhat.com \
    --cc=25969@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).