From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id OO7FJ8DAc2LD9AAAbAwnHQ (envelope-from ) for ; Thu, 05 May 2022 14:19:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id AMoSKMDAc2JBeQAA9RJhRA (envelope-from ) for ; Thu, 05 May 2022 14:19:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3A9F17A5C for ; Thu, 5 May 2022 14:19:12 +0200 (CEST) Received: from localhost ([::1]:49860 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmaRq-0002py-QJ for larch@yhetil.org; Thu, 05 May 2022 08:19:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmaRi-0002ph-H3 for bug-guix@gnu.org; Thu, 05 May 2022 08:19:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50739) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nmaRi-00008V-4G for bug-guix@gnu.org; Thu, 05 May 2022 08:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nmaRh-0006U8-VQ for bug-guix@gnu.org; Thu, 05 May 2022 08:19:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#55270: unpack phase randomly changes the cwd Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 05 May 2022 12:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55270 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Attila Lendvai , 55270@debbugs.gnu.org Received: via spool by 55270-submit@debbugs.gnu.org id=B55270.165175311124875 (code B ref 55270); Thu, 05 May 2022 12:19:01 +0000 Received: (at 55270) by debbugs.gnu.org; 5 May 2022 12:18:31 +0000 Received: from localhost ([127.0.0.1]:44636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmaRD-0006T8-7e for submit@debbugs.gnu.org; Thu, 05 May 2022 08:18:31 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:44212) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmaRB-0006Sz-1g for 55270@debbugs.gnu.org; Thu, 05 May 2022 08:18:29 -0400 Received: from [IPv6:2a02:2c40:200:b001::1:c51f] ([IPv6:2a02:2c40:200:b001::1:c51f]) by albert.telenet-ops.be with bizsmtp id T0JS270011673cg060JTMc; Thu, 05 May 2022 14:18:27 +0200 Message-ID: <378a823f4ae3a60c2d3ad419b22958524c933b19.camel@telenet.be> From: Maxime Devos Date: Thu, 05 May 2022 14:18:21 +0200 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-8nR/8CzggRC0XvhF0o4q" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1651753107; bh=LRC+FolItBDbxDh6MvLn0McfU1n364CCwPVQ26dL9HA=; h=Subject:From:To:Date:In-Reply-To:References; b=ALo98k/U1d4dxCHyYiKgW4tD/qUsscpVvHwjJU15LvWI24iQk7rEYb2qGLMk59cpp nmWgqJFlLzLm5097Z+r9gn25i1btzgohxWCpk6uaqFgGDTV8kk5f9MG1eeM2+hGGr1 u9mssSQ5+Xsz4p1Wh/qs86A/g7OnJsN+jRN+wW71esa7TtyJYIXUtFGCuCQVJb1rns vhNh6GqiDbLsMsdEubWuzn9WwmTiPTmxNmMeNH3BqC0gssL/sZ5If+dP1PTJiWm6Eb e5sUWwcK+NgdMGugnEKm763hy3Ylgkfi2HcWfHRhZOTsRHcGsG/NlrGFGpDyq8zko6 OZrecJ6mKyXzQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1651753152; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=LRC+FolItBDbxDh6MvLn0McfU1n364CCwPVQ26dL9HA=; b=a0aeMiMoY+DUt9R8tgT3XfJwyTygpLw6o3BSKdYkY3K9daUpqJV7nyK1ryH5NvnPi6KOKl QJryTp7yB1PTs4b+TYN5+Qcapx4Hd3qe76cnWq7FOWKLccpqP7OuOIrjmrJgsCupUUSpYD 6vSoq7p1jitPo4fWVZipMEFcD+K+TeNkXbP6kNpdsMz2JuKOUyZpOOWy0Tf0mKW6cp1nR/ AcIQDQanuDbB51Xgqqc7beo4DA8J7xyLoHBUIQTDAV54mklGy3L0bKtCyxJ62O6r8d1QLj iUZ3z0F2PToHV9JvncR7Lqf8tawsuNEUc3u/nxyb0Qrt4OTxKIvaXHIyM3GXCg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1651753152; a=rsa-sha256; cv=none; b=Od8JQf5B9CzO+79iSTQ8q2KTQsiviJCLAegBjXsfcMBZ8d2yihN/ELBLfvGNaDZE+Tipck Y0r6XyLoSgAfJQAYXuFFqcIuFvFORm/3k9Rh21RI5f5uOq3a4uRq2NMU3t6+88TNziDGs2 bUmTeWO1cAyI0mmvbVeMZiWJ2bjqW+5NB8DGBSEBnHemmSdejYqlLJ+x4bL6X0G7j4IjdF B2/uYQucvrjFRYZalL7J2WnJk58pjqFkpNlMwqoMndtZpDHis89thSw/zZFJkR1j+uvoik 5VOZgAwL60/IetWCM3iLQusiQy2xiKmKInlmSnlHo05NNC1kRPs1cDKwtgtlQQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b="ALo98k/U"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.91 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b="ALo98k/U"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3A9F17A5C X-Spam-Score: 3.91 X-Migadu-Scanner: scn1.migadu.com X-TUID: R7yRexbDZLzC --=-8nR/8CzggRC0XvhF0o4q Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attila Lendvai schreef op do 05-05-2022 om 11:16 [+0000]: > at the end of the unpack phase, the working directory is changed to a ran= dom directory. >=20 > https://git.savannah.gnu.org/cgit/guix.git/tree/guix/build/gnu-build-syst= em.scm#n178 It takes the first result 'scandir' -- i.e., the 'smallest' file name according to string-locale=20 > this is fine *when* the archive contains a single dir... but this DWIM'ne= ss has just burned 15 mintues of my life, and i recommend removing it. >=20 > if it is to stay, then at least it should be patched that it only happens= when the dir after extraction only contains a single subdir, and no files = otherwise. Except maybe when using 'out-of-source?', I think it has to stay in some form -- somehow, we will have to run build scripts, "make", maybe do some 'substitute*', and having to type the version number and directory name inside build phases seems a bit error-prone (what if the source is changed fom tarball or 'zip' to a vcs checkout?). I agree with only chdiring if there's only one subdir (and no other files) though -- =E2=80=98just the first=E2=80=99 is a bit arbitrary. Greetings, Maxime. --=-8nR/8CzggRC0XvhF0o4q Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnPAjRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7hcPAQCFW/Nxza6Q/6DPskwK3/dzFebz aUV1g5TI31LsC29bPwD/SVm+R3wlX4KhqNDtMtfQ3vKEDM/rLKd+8HkMLCSshgc= =ci5l -----END PGP SIGNATURE----- --=-8nR/8CzggRC0XvhF0o4q--