From: Maxime Devos <maximedevos@telenet.be>
To: "Thompson, David" <dthompson2@worcester.edu>
Cc: 56444@debbugs.gnu.org
Subject: bug#56444: [EXT] Re: bug#56444: Patch to fix Gitolite home directory permissions
Date: Mon, 29 Aug 2022 15:19:49 +0200 [thread overview]
Message-ID: <31e8c6df-a9c9-7f16-69fb-e022d94c16ff@telenet.be> (raw)
In-Reply-To: <CAJ=Rwfax4r3281OLMOp7xGg1-f4DSFHRsGT+qRHm_Bu82NJ2tg@mail.gmail.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 659 bytes --]
On 29-08-2022 14:57, Thompson, David wrote:
> I disagree. I believe we shouldn't let perfect be the enemy of the good.
I don't think your patch counts as "good" here -- while fixing the bug
counts as "good", you are at the same time introducing a new bug (the
non-atomicity), which is bad. You would have to weigh the goodness and
the badness to end up with an overall "good" (or maybe "bad", depending
on the conclusion), but I'd think that the time required to do such a
weighing is better spent by doing a tiny bit of extra effort to
implement the new field (it should be very low effort, see other response).
Greetings,
Maxime.
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next prev parent reply other threads:[~2022-08-29 13:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 21:35 bug#56444: Gitolite home directory permissions Evgeny Pisemsky
[not found] ` <handler.56444.B.165722972531874.ack@debbugs.gnu.org>
2022-07-08 8:10 ` bug#56444: Acknowledgement (Gitolite home directory permissions) Evgeny Pisemsky
2022-08-19 13:32 ` bug#56444: Patch to fix Gitolite home directory permissions Thompson, David
2022-08-23 12:41 ` Maxime Devos
2022-08-23 14:45 ` Thompson, David
2022-08-29 12:49 ` Thompson, David
2022-08-29 12:52 ` Maxime Devos
2022-08-29 12:57 ` bug#56444: [EXT] " Thompson, David
2022-08-29 13:09 ` Maxime Devos
2022-08-29 13:11 ` Maxime Devos
2022-08-29 13:19 ` Maxime Devos [this message]
2022-08-29 13:30 ` bug#56444: [EXT] " Thompson, David
2022-08-29 13:44 ` Maxime Devos
2022-08-29 13:59 ` bug#56444: [EXT] " Thompson, David
2022-08-29 21:05 ` zimoun
2022-08-30 15:20 ` bug#56444: " Ludovic Courtès
2022-08-30 16:39 ` bug#56444: [EXT] " Thompson, David
2022-08-30 18:31 ` david larsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31e8c6df-a9c9-7f16-69fb-e022d94c16ff@telenet.be \
--to=maximedevos@telenet.be \
--cc=56444@debbugs.gnu.org \
--cc=dthompson2@worcester.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).