From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id lHfuJHGu4F+9fgAA0tVLHw (envelope-from ) for ; Mon, 21 Dec 2020 14:17:21 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id qNFRIHGu4F87TAAA1q6Kng (envelope-from ) for ; Mon, 21 Dec 2020 14:17:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 02AC79404E5 for ; Mon, 21 Dec 2020 14:17:20 +0000 (UTC) Received: from localhost ([::1]:54924 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1krLzy-0005t3-Ce for larch@yhetil.org; Mon, 21 Dec 2020 09:17:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36878) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1krLzk-0005sf-06 for bug-guix@gnu.org; Mon, 21 Dec 2020 09:17:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:35053) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1krLzj-0006Bs-Og for bug-guix@gnu.org; Mon, 21 Dec 2020 09:17:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1krLzi-0000I5-Gj for bug-guix@gnu.org; Mon, 21 Dec 2020 09:17:03 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#37523: Print hint if build fails due to invalid character in package source base name Resent-From: Hartmut Goebel Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 21 Dec 2020 14:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37523 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: zimoun Received: via spool by 37523-submit@debbugs.gnu.org id=B37523.1608560178941 (code B ref 37523); Mon, 21 Dec 2020 14:17:02 +0000 Received: (at 37523) by debbugs.gnu.org; 21 Dec 2020 14:16:18 +0000 Received: from localhost ([127.0.0.1]:46599 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krLyz-0000F7-Ru for submit@debbugs.gnu.org; Mon, 21 Dec 2020 09:16:18 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:39700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krLyv-0000Em-Qu for 37523@debbugs.gnu.org; Mon, 21 Dec 2020 09:16:17 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4D01jS4QVhz1qs0j; Mon, 21 Dec 2020 15:16:12 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4D01jS2l0hz1qr3y; Mon, 21 Dec 2020 15:16:12 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id j6BfV6onsQds; Mon, 21 Dec 2020 15:16:11 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-188-174-60-135.dynamic.mnet-online.de [188.174.60.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Mon, 21 Dec 2020 15:16:11 +0100 (CET) Received: from lenashee.goebel-consult.de (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id 60AC960031; Mon, 21 Dec 2020 15:16:18 +0100 (CET) References: <80714a9a-b70d-8810-0f1b-606b8a6b8743@crazy-compilers.com> <86lfdr9t67.fsf@gmail.com> From: Hartmut Goebel Organization: crazy-compilers.com Message-ID: <2f806ed7-dc2c-ee67-76ff-4483b5515f31@crazy-compilers.com> Date: Mon, 21 Dec 2020 15:16:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <86lfdr9t67.fsf@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 37523@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.32 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 02AC79404E5 X-Spam-Score: -2.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: dqESyaYKpxu+ Hi,, thanks for picking this up. > Therefore, I am missing if this message “invalid character” should be > improved or if the check of the name should be done before on the Scheme > side. Well, I am missing what could be the path to improve the > situation, if it needs. Since this check is done also for other store-items, I assume it does not make much sense to change the message in the C-code. So I assume the patch to improve this is to check the name on the Scheme side. (Or to make the da)emon return some meaningful error object. Anyhow I assume this is much more complicated and not a solution for now. -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible |