From: Maxime Devos <maximedevos@telenet.be>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 54469@debbugs.gnu.org
Subject: bug#54469: home-environment-variables-service-type does not quote things
Date: Thu, 21 Jul 2022 14:30:39 +0200 [thread overview]
Message-ID: <2e23d60c-f4cb-b5a0-6067-c01ef18eea19@telenet.be> (raw)
In-Reply-To: <87v8s08v3n.fsf@gnu.org>
[-- Attachment #1.1.1: Type: text/plain, Size: 672 bytes --]
On 14-07-2022 01:13, Ludovic Courtès wrote:
> [...]
> Fixed in af4c103595a725194318f40fc5aba110772ff417… except for checking
> the name of the variable.
>
> I guess we should stick to the grammar for “names” that Bash defines
> (info "(bash) Definitions") and error out if the variable name doesn’t
> comply?
Yes -- supporting arbitrary variable names would be nice but that just
sticking to those (and erroring out) should be good enough in practice.
FWIW, (guix search-paths) also does export this="that", so it looks like
the quoting and name checking could be generalised a little to also
extend to etc/profile.
Greetings,
Maxime.
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
prev parent reply other threads:[~2022-07-21 12:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-19 21:04 bug#54469: home-environment-variables-service-type does not quote things Maxime Devos
2022-07-13 23:13 ` Ludovic Courtès
2022-07-21 12:30 ` Maxime Devos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e23d60c-f4cb-b5a0-6067-c01ef18eea19@telenet.be \
--to=maximedevos@telenet.be \
--cc=54469@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).