From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aFMGAmp5w2EwCwAAgWs5BA (envelope-from ) for ; Wed, 22 Dec 2021 20:15:54 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id HQY9OWl5w2GkfQAAbx9fmQ (envelope-from ) for ; Wed, 22 Dec 2021 19:15:53 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9AB8DFD1B for ; Wed, 22 Dec 2021 20:15:53 +0100 (CET) Received: from localhost ([::1]:47860 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n075c-0005vu-Ei for larch@yhetil.org; Wed, 22 Dec 2021 14:15:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n074x-0005vG-1K for bug-guix@gnu.org; Wed, 22 Dec 2021 14:15:15 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48204) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n074o-0007zz-J4 for bug-guix@gnu.org; Wed, 22 Dec 2021 14:15:09 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n074o-0005sY-BC for bug-guix@gnu.org; Wed, 22 Dec 2021 14:15:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#52452: PATCH v2 2/4] activation: Add 'lchown-recursive'. References: <8735mx26qr.fsf@cbaines.net> In-Reply-To: <8735mx26qr.fsf@cbaines.net> Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 22 Dec 2021 19:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52452 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 52452@debbugs.gnu.org Received: via spool by 52452-submit@debbugs.gnu.org id=B52452.164020046022532 (code B ref 52452); Wed, 22 Dec 2021 19:15:02 +0000 Received: (at 52452) by debbugs.gnu.org; 22 Dec 2021 19:14:20 +0000 Received: from localhost ([127.0.0.1]:59750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0748-0005rL-5u for submit@debbugs.gnu.org; Wed, 22 Dec 2021 14:14:20 -0500 Received: from baptiste.telenet-ops.be ([195.130.132.51]:51714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0745-0005rB-F1 for 52452@debbugs.gnu.org; Wed, 22 Dec 2021 14:14:18 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by baptiste.telenet-ops.be with bizsmtp id ZXEE2601z4UW6Th01XEEmk; Wed, 22 Dec 2021 20:14:14 +0100 Message-ID: <2877ff704a262640a315063c536e67b0efc2d487.camel@telenet.be> From: Maxime Devos Date: Wed, 22 Dec 2021 19:14:14 +0000 Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1640200454; bh=HoLot5eJutaSJpa1c3WxYO/xjwoPNbeSrj18eqqhyuI=; h=Subject:From:To:Date; b=SL2OdcOk94mTuWDvtSsfV2zVQUgPNGxCe7mzseYC1hd23u584gqtnaszFY12PHL9A R4dMdY0bzc9WqC4TMeHRp3rTdiBUcbEOq/pWqd7ji+/3LDPEn/Iq3dWse++bjwqb5P eDhcaIKzL0ME7Q0reaNEoZzCih/OoTEUIAbSbwRLD2vv5oKWUDZqnDE0crslodptQ3 YWpnNcMigFx/EbCHW8ala4xrTx4wX2yUE2EYsrtXV8/s3CdQG5oic2PE5uVgbji37w uLXnVnC4046ogLrMChs7Nn128pZzyIweRR5H+WFggm8Tz09+vWdD23WXhD9PbMSuOh NMzdgmGQMFkPw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640200553; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=HoLot5eJutaSJpa1c3WxYO/xjwoPNbeSrj18eqqhyuI=; b=D563b/d6sQiEKz1HkM9lKQDgHmpH/vscDvciaPrfPtrFqAVyNBx5LKZF8meijgR79ZOKGD clvBuZiCD7CI88jKB0Feh2WrhSfOpTwFolYzZJdt+Jzf4OHZrgG9QsL9Io8ddA8aQbB9JF V6h5ExBweFy9qWXMzdirni4Gv3PU6KkYSx7UiVrq1DbP8gcaeZ9cJ7+sZdKzsOpbEG9lfF 2r2SkHyC3HpCUXc4foeXyVgR2wQF+aUW2uLNHPgYGEjG8hnXSS/DTdOGLZv7ryAlt7wbYN skMSYILsSMOe+cOVHgOJi7SFHborILXbCj23mhf49qIqWaCWgctKseRiWmTLlA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640200553; a=rsa-sha256; cv=none; b=hgoV4acFIuglIPbpBBJexTZKezbndahtAvzwo2g1QSkbuCyf61JyCQq+/HPHFmhc4UWK+2 5rYoztkaBRhVN2c/ALxuhQ71Mwdh5exQbzulGBvegYMruqfc4bp0oDayPrGCcQ4tlVD5RP ka3kdr6LkkEYYfKNARpiuD32jIsbh6Pqf/AXrQQ7gcEx6j9wE+P23OPlf875Rn0761pmXa CgaNFMs7pn4JZKjF5Tc+GgNZ1dS87BSiFfkY/eGuwSniCNHc2OnvJuxZW/oDL7QWDTwFMq NA9fkWBRwftz6FzGdQrcCDhHx6ZudAUID9s3xRQAATA9O6osevePpY+8t2/Tog== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=SL2OdcOk; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.54 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=SL2OdcOk; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9AB8DFD1B X-Spam-Score: -2.54 X-Migadu-Scanner: scn0.migadu.com X-TUID: CwhBmf99jIL8 >+(define (lchown-recursive file owner group) >+ "As 'lchown' but recursively, change ownership of FILE to the >integer values >+OWNER and GROUP without dereferencing symbolic links it encounter." >+ (nftw file >+ (lambda (filename statinfo flag base level) >+ (catch 'system-error >+ (lambda () >+ (when (member flag '(regular directory symlink)) >+ (lchown filename owner group))) >+ (lambda args >+ (format (current-error-port) >+ "warning: failed to chown ~s: ~a~%" >+ filename >+ (strerror (system-error-errno args))))) >+ #t) >+ 'physical)) This is racy (compare with mkdir-p/perms for example). This race can be resolved by using 'openat' & 'chownat' & 'AT_SYMLINK_NOFOLLOW' from . Greetings, Maxime.