From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SJu7M1/Y1WFsJQEAgWs5BA (envelope-from ) for ; Wed, 05 Jan 2022 18:41:51 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id aJE1MF/Y1WGmaAAAauVa8A (envelope-from ) for ; Wed, 05 Jan 2022 18:41:51 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5D5EB3B01A for ; Wed, 5 Jan 2022 18:41:51 +0100 (CET) Received: from localhost ([::1]:32846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5AII-0003fS-H6 for larch@yhetil.org; Wed, 05 Jan 2022 12:41:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5AHW-0003dL-Nl for bug-guix@gnu.org; Wed, 05 Jan 2022 12:41:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:58367) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5AHW-0004FE-EE for bug-guix@gnu.org; Wed, 05 Jan 2022 12:41:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n5AHW-0006mz-Ci for bug-guix@gnu.org; Wed, 05 Jan 2022 12:41:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#34170: bitcoin-core bundles leveldb Resent-From: Carl Dong Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 05 Jan 2022 17:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34170 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: zimoun Received: via spool by 34170-submit@debbugs.gnu.org id=B34170.164140445626077 (code B ref 34170); Wed, 05 Jan 2022 17:41:02 +0000 Received: (at 34170) by debbugs.gnu.org; 5 Jan 2022 17:40:56 +0000 Received: from localhost ([127.0.0.1]:41680 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5AHP-0006mX-IO for submit@debbugs.gnu.org; Wed, 05 Jan 2022 12:40:55 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:53927) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5AHO-0006m7-Ir for 34170@debbugs.gnu.org; Wed, 05 Jan 2022 12:40:55 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1F5D25C0153; Wed, 5 Jan 2022 12:40:49 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 05 Jan 2022 12:40:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=carldong.me; h= from:message-id:content-type:mime-version:subject:date :in-reply-to:cc:to:references; s=fm2; bh=JRleEb/mGdchHT3MIE0cNXP I+f17nvaT0mACCWklTz4=; b=OblnjhT1X6FK8Md745fXP7jrPTwcNaGvrsdyN7e srxJ4VSbJiUqPDvffSKY9qZPyzMcTmbcq4NZzGLLALY6WSz2tchCvqPsE62s+AOY 8sgyHmhYI0DVhXpm+Rr6guA6lVJ+bmmQ0BhaFRbXo9LwiLavXOALoMR9rWyfxcAN QP/smcQUuzIYaTyRF4sfwLwnjvEDmdtI3gpOBANqoWsNMB/j4TtCprg930SbrETc Ohi5Eb3C+x/MlomGBYuSrrVh7mKZfuYmq8AhEbB2HSvjDuSYMXIRCQIX3xI0LsCv B0FfO7+KWTmiw/I1WcAvLfsb7pJ65BmNnUxvIpwBGPv+/CA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=JRleEb /mGdchHT3MIE0cNXPI+f17nvaT0mACCWklTz4=; b=LGq2HQZko6shRVcdpB/iBk aq2rPrC/LuS57O50gfg2RkC+5WakWLr0P3KRRk+XLWPkuBObZ10wzLExR5cYfnZI ACXYqpJMJVGzmW7xheV4UlnAQcAuaFIBAZTH634ZynDLY3o+y130PPVmR+j+Dv9G z7k8K2/AyfaTHv3KyPiWLoxACU7UTLZ/AUra/RkteisZ1jRuOk53fgfkObM3kDwf X8CP+V9WxjNFUm2vb0KbiO0VNt4WowlUn4Cbw3Rlzhh30m6d6HvOLeZUDR14djE7 3F88jgVM45+hcMS7G8d3GDei6uxiYqhiYrxV580dYxZfk1rtyz6OTcW6q/vCP6Xg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrudefjedgudekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffktgggufffjgfvfhfosegrtdhmrehhtdejnecuhfhrohhmpeevrghrlhcu ffhonhhguceotghonhhtrggtthestggrrhhlughonhhgrdhmvgeqnecuggftrfgrthhtvg hrnhepffejgfetffejfefgheeuvdffhfehffeffedtffeffedvieeiveektedtgfelffei necuffhomhgrihhnpehgihhthhhusgdrtghomhdpsghithhmvgigrdgtohhmnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheptghonhhtrggtthes tggrrhhlughonhhgrdhmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Jan 2022 12:40:48 -0500 (EST) From: Carl Dong Message-Id: <26B84833-6F9F-4C5D-8448-715C67C16768@carldong.me> Content-Type: multipart/alternative; boundary="Apple-Mail=_EC7E2094-152E-45AD-AABD-1B9A07852BBA" Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\)) Date: Wed, 5 Jan 2022 12:40:48 -0500 In-Reply-To: <86lezu8qj4.fsf@gmail.com> References: <20190122133124.7ca032d7@scratchpost.org> <865ys6m168.fsf@gmail.com> <86lezu8qj4.fsf@gmail.com> X-Mailer: Apple Mail (2.3693.40.0.1.81) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 34170@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641404511; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=JRleEb/mGdchHT3MIE0cNXPI+f17nvaT0mACCWklTz4=; b=IB/LVgJjEcMCQ1RJPsjKP4CFvOFXG6Nt/RwkqyCevO5k92tQtmMHOTDkZvHV6oGj+4Uzyr XG5HHicDZgC/EaJTXMiU7hanMuAPSIi1JyMq+YIJy//m8pOpH25IVygIUa/v4B6SIjmSbq CkZBUd7h8dhHlHru5+NYFp9cQLWe0/D4ls58eOUseUXQ+hz5YqiP8TB1cru5aJH70gxf3D hTskFlbaqeAuLFhQULBz+fayeFz7QHKcomahaLWXnbWViWjkE3Bs65wLcbq2oU0/WGi8X+ ZFRvtdOGoBShT9oGfK1kfCM0gZsvcTB1Nk0zB854UFVSTXEnbuUliCd4AWJJTw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641404511; a=rsa-sha256; cv=none; b=qGKYEnMT95WemeFH1KNdqHlySFPjIy9/QlfTgrUItSHt41boj+fDXRVJ6iBcneK0YOup/O hG1xkS/W3iwarrzPenTjMwiPBOd6AiSpxWO8zHjRer4ztb3vw4kt+v9JjG9/vTlKRw6Fw4 WrvT60hF5keEZyNFRjUI+g5nM+EnGTo6oqkJreDPlYDyKITnP4VsIHf1/4Zry2XJxEbE4p hbqhM5W0u8y/cdSnvNNA6hYaODI0igkzn4Tj8uOo70i//wryhdfKN4VvGp1AZpivMVeKri n/E3B9qAd1mNRnsFcRkIHzjEHdlPEmqKnvnb8cbiIg2TaFIRMO1R0gkr92twmg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=carldong.me header.s=fm2 header.b=OblnjhT1; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=LGq2HQZk; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.00 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=carldong.me header.s=fm2 header.b=OblnjhT1; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=LGq2HQZk; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 5D5EB3B01A X-Spam-Score: -2.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: tJGJzXxI061x --Apple-Mail=_EC7E2094-152E-45AD-AABD-1B9A07852BBA Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Simon, Maxime, Danny, Thanks for CCing me on this message! The rationale for bundling leveldb = in Bitcoin Core goes a bit beyond convenience, it is several things: 1. The original reason for sub-treeing is that Bitcoin Core used to = maintain its own version of leveldb with its own fixes here: = https://github.com/bitcoin-core/leveldb-subtree = , since then most of = these fixes have been upstreamed as of: = https://github.com/bitcoin/bitcoin/pull/17398 = 2. We also used to support using an external leveldb, however, it seems = that it was fragile to rely on external projects to maintain ABI = compatibility, see the quoted IRC bug report here: = https://github.com/bitcoin/bitcoin/pull/23282 = . Reasonable minds may = disagree on this point, especially coming from Guix where patching is = convenient. In addition to the above, Bitcoin Core experienced a hard fork in 2013 = due to database incompatibilities, which has predisposed maintainers = towards a more stringent approach with pinning dependencies and their = configure/build-time flags. See: = https://blog.bitmex.com/bitcoins-consensus-forks/#was-the-2013-incident-a-= hardfork = Let me know if I can provide more context! Cheers, Carl Dong > On Jan 5, 2022, at 4:45 AM, zimoun wrote: >=20 > Hi Maxime, >=20 > On Wed, 05 Jan 2022 at 10:39, Maxime Devos = wrote: >=20 >>> The package bitcore-core still provides =E2=80=99leveldb=E2=80=99: >>>=20 >>> [...] >>>=20 >>> and I am not sure to get what is the issue. Some explanations? >>=20 >> The issue is that bitcoin-core bundles leveldb (which you have shown >> is still the case), even though leveldb is packaged in Guix. >=20 > Thanks, I missed that =E2=80=99leveldb=E2=80=99 is packaged in Guix. = Indeed, it should > preferably be used. >=20 > So reopen. :-) >=20 >=20 > Cheers, > simon --Apple-Mail=_EC7E2094-152E-45AD-AABD-1B9A07852BBA Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Simon, Maxime, Danny,

Thanks for CCing me on this message! The rationale for = bundling leveldb in Bitcoin Core goes a bit beyond convenience, it is = several things:

1. The original reason for sub-treeing is that Bitcoin Core = used to maintain its own version of leveldb with its own fixes = here: https://github.com/bitcoin-core/leveldb-subtree, since = then most of these fixes have been upstreamed as of: https://github.com/bitcoin/bitcoin/pull/17398
2. We also used to support using an external leveldb, = however, it seems that it was fragile to rely on external projects to = maintain ABI compatibility, see the quoted IRC bug report here: https://github.com/bitcoin/bitcoin/pull/23282. Reasonable = minds may disagree on this point, especially coming from Guix where = patching is convenient.

In addition to the above, Bitcoin Core experienced a hard = fork in 2013 due to database incompatibilities, which has predisposed = maintainers towards a more stringent approach with pinning dependencies = and their configure/build-time flags. See: https://blog.bitmex.com/bitcoins-consensus-forks/#was-the-2013-= incident-a-hardfork

Let me know if I can provide more context!

Cheers,
Carl Dong

On Jan 5, 2022, at 4:45 AM, = zimoun <zimon.toutoune@gmail.com> wrote:

Hi = Maxime,

On Wed, 05 Jan 2022 at 10:39, = Maxime Devos <maximedevos@telenet.be> wrote:

The package bitcore-core still provides =E2=80=99leveldb=E2=80=99= :

[...]

and I = am not sure to get what is the issue.  Some explanations?

The issue is that bitcoin-core = bundles leveldb (which you have shown
is still the case), = even though leveldb is packaged in Guix.

Thanks, I missed that =E2=80=99leveldb=E2=80=99 is packaged = in Guix.  Indeed, it should
preferably be used.

So reopen. :-)


Cheers,
simon

= --Apple-Mail=_EC7E2094-152E-45AD-AABD-1B9A07852BBA--