Simon, Maxime, Danny,
Thanks for CCing me on this message! The rationale for bundling leveldb in Bitcoin Core goes a bit beyond convenience, it is several things:
2. We also used to support using an external leveldb, however, it seems that it was fragile to rely on external projects to maintain ABI compatibility, see the quoted IRC bug report here:
https://github.com/bitcoin/bitcoin/pull/23282. Reasonable minds may disagree on this point, especially coming from Guix where patching is convenient.
Let me know if I can provide more context!
Cheers,
Carl Dong
Hi Maxime,
On Wed, 05 Jan 2022 at 10:39, Maxime Devos <
maximedevos@telenet.be> wrote:
The package bitcore-core still provides ’leveldb’:
[...]
and I am not sure to get what is the issue. Some explanations?
The issue is that bitcoin-core bundles leveldb (which you have shown
is still the case), even though leveldb is packaged in Guix.
Thanks, I missed that ’leveldb’ is packaged in Guix. Indeed, it should
preferably be used.
So reopen. :-)
Cheers,
simon