From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cFC8KJ6AjWFWKwAAgWs5BA (envelope-from ) for ; Thu, 11 Nov 2021 21:44:14 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id KPxmJJ6AjWGmCQAA1q6Kng (envelope-from ) for ; Thu, 11 Nov 2021 20:44:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 64A5E21932 for ; Thu, 11 Nov 2021 21:44:13 +0100 (CET) Received: from localhost ([::1]:44792 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mlGvc-0004x7-JO for larch@yhetil.org; Thu, 11 Nov 2021 15:44:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlGvS-0004vf-4O for bug-guix@gnu.org; Thu, 11 Nov 2021 15:44:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:59109) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mlGvR-00084b-Qw for bug-guix@gnu.org; Thu, 11 Nov 2021 15:44:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mlGvR-0003aU-I8 for bug-guix@gnu.org; Thu, 11 Nov 2021 15:44:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#51731: [PATCH] gnome-tweaks fails to start on core-updates-frozen Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 11 Nov 2021 20:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51731 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Vivien Kraus Received: via spool by 51731-submit@debbugs.gnu.org id=B51731.163666342713760 (code B ref 51731); Thu, 11 Nov 2021 20:44:01 +0000 Received: (at 51731) by debbugs.gnu.org; 11 Nov 2021 20:43:47 +0000 Received: from localhost ([127.0.0.1]:42422 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlGvD-0003Zr-5k for submit@debbugs.gnu.org; Thu, 11 Nov 2021 15:43:47 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:36387) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlGvB-0003Zc-AE for 51731@debbugs.gnu.org; Thu, 11 Nov 2021 15:43:46 -0500 Received: by mail-wm1-f68.google.com with SMTP id i8-20020a7bc948000000b0030db7b70b6bso8252639wml.1 for <51731@debbugs.gnu.org>; Thu, 11 Nov 2021 12:43:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=PoX4ZVmVPXbrbWueTZh8t7uGDA3+Pek1TN6ZcBlrVuo=; b=eitdt3wQ7TR2aCYt4l3zyItJd0DqmbGQMw99L6HBhHAxdZaZVA3Qr6bMQpYi2z5pqe aJw7ArPn7sSxuH/U9RA/DouuyUYg51g+MgCYPTgx+VX87slE8R+w2gFKvcXpYk6s44eE vcNsFDFHV3hkwvYPskvXVyC1zfdYlNMM6wB8FQ3EWnpAkTjm6/xW4mdtfF509gn/WAGP vzjymVLSz44MDczqDoXEOw7ZNTD3YCHp5+JlAnXnKGakNT45rT+8RtkEm1Xta99WcPQ7 +RnHBEsKfnICJ08ok3f35h9S7tYhluhLX55rBCxsFqdiuEcB8GJD+zvg1dGyxJeavYv8 cyiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=PoX4ZVmVPXbrbWueTZh8t7uGDA3+Pek1TN6ZcBlrVuo=; b=vH0wwcKFi6Mm02QFpmprZLyseKzcXOm46+6ZyikqjkDDMK5LhIHvmr03uMqeld29Qp YRco5egUJC2IeDPrqso9tclZx73w36tU98n19JlVDmK5L4fIDINl5YAdnk/SjDw7OCH9 E1pClCX9x07nnmsc8u8UExA/sfRKNHl30qMctCcnmYhKd1yVx9rE29OBYuAwN1e39GIk SauPpMs8hovJXaW5tfnTvLYIVwSs2OUaffr4o+B82WngCnH4IU1OZeVeIk/DfhwuCPZN 4Gdyh3vSLk1WFsfH2X3iDGWXXDh1fxSkhFwTHhtYAHj9RmgHXNuurO3CFF9222iScLI8 pF5Q== X-Gm-Message-State: AOAM532L0tgHeOZbNPbNTDZl6QYMkKIQoUasg6spTWNJFfcClFYZhmwy x5/buVLQzI7QQGrwZp+fehE= X-Google-Smtp-Source: ABdhPJxcw+tvT3DpsK01b54IA5RL03PVt0Hw+cX0UttIS5pk1J/oQyuG2vmhrhsq+daE0A8XgMiTgA== X-Received: by 2002:a1c:cc19:: with SMTP id h25mr28956371wmb.57.1636663419408; Thu, 11 Nov 2021 12:43:39 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id n15sm10461672wmq.38.2021.11.11.12.43.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Nov 2021 12:43:38 -0800 (PST) Message-ID: <202fa36515ed6ef320af31704fce6ff36f1ab10c.camel@gmail.com> From: Liliana Marie Prikler Date: Thu, 11 Nov 2021 21:43:37 +0100 In-Reply-To: <871r3nspqc.fsf@planete-kraus.eu> References: <87pmr9x6vu.fsf@planete-kraus.eu> <73796631dd1dd39a638c948ca3273f5cd3423b88.camel@gmail.com> <871r3nspqc.fsf@planete-kraus.eu> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 51731@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636663453; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=PoX4ZVmVPXbrbWueTZh8t7uGDA3+Pek1TN6ZcBlrVuo=; b=HeobinCrou2v15O6XzXaw5JdwhLzsxh92WUBZIg7XTFXAKCeBxakjj/u0w50X7Y2za7a4N 5RbXGdTeKd2YJ6quNUcEZIVe/VsMkd/St9euPgGxXbY2yO7ZLYuJCQ2UlJz50FtGzhHIic SM4W7LKFlg/ay8Qs/97No3Iy30Vl9ue/fQnRa4y9tAoHyAIIvSd38dgeCvliD7P/8w7wf5 Nsa2W0lFEZTU0axrKOe0ZLngsAKRcwMM4f5AkIAI7k17mUDPf7+fzr78mio2jpOufuTLrG HlQrKVf5arlnR0tfe0hB7xgRhApPde+ms8XTKqzUckeViajquT7ocSPaHSunUQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636663453; a=rsa-sha256; cv=none; b=ajwBPU5Egp41NBH0vIjKtJMgrLyLQa8FuM1V/yOO+nKpTGm/S39nME80WyXVneDRFLdECe DsKkGH4K1dlcm6ysTl9FeDuLdAIC2lxZOiKS1muZDr3r2iACWstbZn3gW/YPD+TguhTNKA K+HbJLu3MJUuL+Wwh8chPJHc8LlkCtkFk7/QgmuyfEQLvYi+0NjVcbU4y8muWBZCFpzhTp MHIb6IiO/hgOyZjC3JauCV8kC9Ay7hR5vyEo+lYub81T8TLyVm1ettOyQoSVy4cNtu347K ZfNP9qANoctLGom4EGBIXs4Cq+W3ux0DHN+/tyQhEVKcRdW1ytZzcboPgbbO6g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=eitdt3wQ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -1.73 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=eitdt3wQ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 64A5E21932 X-Spam-Score: -1.73 X-Migadu-Scanner: scn1.migadu.com X-TUID: uEh/e0dJyY6/ Hi, Am Mittwoch, den 10.11.2021, 20:20 +0000 schrieb Vivien Kraus: > Apparently, we shouldn’t apply guix style yet, we will apply it for > all packages at once some day. I don't think it's a rule that you can't at all; rather that you shouldn't when you're not already touching that package. Then again, I'll leave the decision to you and the experts who actually work on core-updates-frozen :) > > Note, libhandy 0.0 only exists on master (and therefore core- > > updates), because there are packages still using it. If there's no > > more users post updating gnome-tweaks, it is to be removed! > I tried, but there are 2 problems: > 1. I can’t update authenticator (gnu/packages/gnome.scm), because > upstream switched to Rust and I don’t know how to package that; > 2. Geary needs it too (and gmime 2, which we could drop the same > way), but it’s a pain to upgrade. I went a long way, but there’s some > vala code that acts on strings as if they were arrays and I don’t > know what happens: maybe a newer vala is required, or the glib string > type does not apply for some reason. Fair enough, that's a few users more than I remembered. > > > Subject: [PATCH 2/5] gnu: gnome-tweaks: Set the python path. > > Nice catch, I think this was previously done by a different phase. > > However... > > > gnu/packages/gnome.scm (gnome-tweaks)[phases]: Also wrap with > > > GUIX_PYTHONPATH. > > Please note the phase and perhaps change its name to reflect what > > it > > does. > Is the 'wrap-gi-typelib-and-python boring name appropriate? Good enough for me, there's some similar phase names flying around in gnome.scm. > > > Subject: [PATCH 4/5] gnu: gnome-tweaks: Add bash-minimal as an > > > input to wrap the program. > > Split the long line. Also perhaps add a comment in the file itself > > as to why this is needed if it's not already obvious from best > > practises in core-updates-frozen. > It’s flagged by the linter, because wrapping a program produces a > shell script that needs to be executed. "Flagged by the linter" is not a good description in a commit message or elsewhere. I think a few packages on c-u-frozen might have a comment along the lines of "; for wrap-program" or similar. Cheers