unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Emmanuel Beffara <manu@beffara.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 62140@debbugs.gnu.org, Michael Rohleder <mike@rohleder.de>,
	44877@debbugs.gnu.org
Subject: bug#62140: enable LVM in Grub
Date: Tue, 28 Mar 2023 14:32:36 +0200	[thread overview]
Message-ID: <20230328143236.GD1964@beffara.org> (raw)
In-Reply-To: <87edpe1gn5.fsf@gmail.com>

Hi,

De Maxim Cournoyer le 24/03/2023 à 13:24:
> OK, thanks for explaining.  Could you please try
> https://issues.guix.gnu.org/60442 (by applying the patch to a local guix
> checkout, building it, then 'sudo -E ./pre-inst-env sudo guix system
> reconfigure /path/to/your/config.scm)?  The test suite was broken it
> seems (it passed without the fix), but perhaps the fix still does work?

I did as you suggested, and unfortunately the patch has no observable effect
on my system.

I can't say it comes as a surprise. Indeed, what the patch does is set the
environment variable `GRUB_PRELOAD_MODULES` before calling `grub-install`,
which is expected to have no effect: this variable is used by `grub-mkconfig`
to generate a `grub.cfg`, but the code in Guix assembles a Grub configuration
file itself and never calls `grub-mkconfig`. The same applies to the variable
`GRUB_ENABLE_CRYPTODISK`, by the way. Maybe the way `grub.cfg` is produced has
changed at some point in history ?

The only hypothesis I can make is that it would influence `grub-install` by
preloading the given modules in the installed image, but that is not the case.
According to Grub's documentation, passing `--modules=...` to `grub-install`
would have this effect, but I'm not sure it is the right approach.

-- 
Emmanuel




  reply	other threads:[~2023-03-28 12:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-11 18:02 bug#62140: enable LVM in Grub Emmanuel Beffara
2023-03-13 13:56 ` bug#44877: " Michael Rohleder
2023-03-14 21:26   ` Emmanuel Beffara
2023-03-23 12:48     ` Maxim Cournoyer
2023-03-23 14:58       ` Emmanuel Beffara
2023-03-24 12:24         ` Maxim Cournoyer
2023-03-28 12:32           ` Emmanuel Beffara [this message]
2023-03-28 14:10             ` Maxim Cournoyer
2024-01-23 16:36 ` Erik Eduardo via Bug reports for GNU Guix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230328143236.GD1964@beffara.org \
    --to=manu@beffara.org \
    --cc=44877@debbugs.gnu.org \
    --cc=62140@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    --cc=mike@rohleder.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).