unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Mădălin Ionel Patrașcu" <madalinionel.patrascu@mdc-berlin.de>
To: <57077@debbugs.gnu.org>
Subject: bug#57077: [PATCH] gnu: guix-jupyter: Fix build and check phase.
Date: Thu, 15 Sep 2022 18:37:40 +0200	[thread overview]
Message-ID: <20220915163740.11672-1-madalinionel.patrascu@mdc-berlin.de> (raw)
In-Reply-To: <YvJf7XqVKOxrgvh6@jurong>

Build drops warnings regarding 'guild' and the check phase does not
have write permissions for its tests.
[build]: Remove the warnings generated by the 'guild' by setting the
"GUILE_AUTO_COMPILE" to 0.
[check]: Set the homeless-shelter to /tmp for write permission.
---
 gnu/packages/package-management.scm | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-management.scm
index 2d1fe914e3..454c69c8a7 100644
--- a/gnu/packages/package-management.scm
+++ b/gnu/packages/package-management.scm
@@ -21,6 +21,7 @@
 ;;; Copyright © 2021, 2022 Maxim Cournoyer <maxim.cournoyer@gmail.com>
 ;;; Copyright © 2021 John Kehayias <john.kehayias@protonmail.com>
 ;;; Copyright © 2022 Zhu Zihao <all_but_last@163.com>
+;;; Copyright © 2022 Mădălin Ionel Patrașcu <madalinionel.patrascu@mdc-berlin.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1616,6 +1617,10 @@ (define-public guix-jupyter
        #:parallel-tests? #f         ;kernels.scm frequently breaks in parallel
        #:phases
        (modify-phases %standard-phases
+         (add-before 'build 'set-GUILE_AUTO_COMPILE
+             (lambda _
+               ;; To avoid warnings relating to 'guild'.
+               (setenv "GUILE_AUTO_COMPILE" "0")))
          (add-after 'install 'sed-kernel-json
            (lambda* (#:key inputs outputs #:allow-other-keys)
              (let* ((out   (assoc-ref outputs "out"))
@@ -1651,7 +1656,11 @@ (define-public guix-jupyter
                  (("guix-jupyter-kernel.scm")
                   (string-append out "/share/guile/site/3.0/"
                                  "guix-jupyter-kernel.scm")))
-               #t))))))
+               #t)))
+         (add-before 'check 'change-home
+           (lambda _
+             ;; Change from /homeless-shelter to /tmp for write permission.
+             (setenv "HOME" "/tmp"))))))
     (native-inputs
      (list autoconf
            automake

base-commit: 0624e7dbad2f53b7f752e9f1109765470f369298
-- 
2.37.3





  parent reply	other threads:[~2022-09-15 16:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-09 13:23 bug#57077: guix-jupyter fails a test Andreas Enge
2022-08-09 21:17 ` Ludovic Courtès
2022-09-08 19:35   ` Ludovic Courtès
2022-09-14 20:34 ` Ricardo Wurmus
2022-09-15 16:35 ` bug#57077: gnu: guix-jupyter: Fix build and check phase MadalinIonel.Patrascu
2022-09-15 16:37 ` Mădălin Ionel Patrașcu [this message]
2023-01-20 11:24   ` bug#57077: guix-jupyter fails a test Ludovic Courtès
2023-01-22  2:02     ` bug#57077: [ext] " MadalinIonel.Patrascu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220915163740.11672-1-madalinionel.patrascu@mdc-berlin.de \
    --to=madalinionel.patrascu@mdc-berlin.de \
    --cc=57077@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).