From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YNK8C+8c3WLmNgAAbAwnHQ (envelope-from ) for ; Sun, 24 Jul 2022 12:20:31 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 8DG+C+8c3WIbQwAA9RJhRA (envelope-from ) for ; Sun, 24 Jul 2022 12:20:31 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8A8261E135 for ; Sun, 24 Jul 2022 12:20:30 +0200 (CEST) Received: from localhost ([::1]:51128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oFYiq-0002BO-Gd for larch@yhetil.org; Sun, 24 Jul 2022 06:20:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41280) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oFYiQ-0002B4-Vm for bug-guix@gnu.org; Sun, 24 Jul 2022 06:20:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57168) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oFYiQ-0005rU-MI for bug-guix@gnu.org; Sun, 24 Jul 2022 06:20:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oFYiQ-0005g0-G8 for bug-guix@gnu.org; Sun, 24 Jul 2022 06:20:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#52823: [PATCH 1/2] gnu: gx-vbass-preamp-lv2: Update to latest commit to fix build issue. Resent-From: Thorsten Wilms Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 24 Jul 2022 10:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52823 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxime Devos Cc: 52823@debbugs.gnu.org Received: via spool by 52823-submit@debbugs.gnu.org id=B52823.165865798721789 (code B ref 52823); Sun, 24 Jul 2022 10:20:02 +0000 Received: (at 52823) by debbugs.gnu.org; 24 Jul 2022 10:19:47 +0000 Received: from localhost ([127.0.0.1]:46917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFYiB-0005fN-9w for submit@debbugs.gnu.org; Sun, 24 Jul 2022 06:19:47 -0400 Received: from mout3.freenet.de ([195.4.92.93]:32956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFYi7-0005f5-C4 for 52823@debbugs.gnu.org; Sun, 24 Jul 2022 06:19:45 -0400 Received: from [195.4.92.127] (helo=sub8.freenet.de) by mout3.freenet.de with esmtpa (ID t_w_@freenet.de) (port 25) (Exim 4.94.2 #2) id 1oFYi5-00GzIP-4q; Sun, 24 Jul 2022 12:19:41 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freenet.de; s=mjaymdexmjqk; h=Content-Transfer-Encoding:Content-Type:Mime-Version: References:In-Reply-To:Message-Id:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=20ZNxxZeM2jBc/w2xEEKuEGvyGBsm+TlRwgXVxamf7E=; b=qSz2iIdCpH5QJC0/WVl3IayE0x 16sMYkSnfuUF1u1cKlztqft2tOaJkLPFHPOjHRKiKNNf6x9zEKP4JOO5B0GxovOYmzm9sjBaUJUo4 fJmU+LjGn1LZBy+afAQzm7Ah9kn2vVskODy7FUChBr7W6alkAypSoV0/1aJzlh/I3HbF+dU14WjEY g/joZyYgCGhsKZUq5jx2IDT67Pjc7gQC3p1ksleJi+sISurx/K96HB6youGJtpNLEJPRRY8dOu780 V9d9rpZ32/WRm5Jvxz7MvDE1Qy1rASWZyEetmzwPdBi8V0vxCI1CQoYvutvtQtpf1M3XvWYkfgs0E fUwsUKgw==; Received: from p200300e4f705300088ccadc4b8cc9a4b.dip0.t-ipconnect.de ([2003:e4:f705:3000:88cc:adc4:b8cc:9a4b]:57044 helo=charly) by sub8.freenet.de with esmtpsa (ID t_w_@freenet.de) (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (port 587) (Exim 4.94.2 #2) id 1oFYi4-00CDcs-Sn; Sun, 24 Jul 2022 12:19:41 +0200 Date: Sun, 24 Jul 2022 12:19:40 +0200 From: Thorsten Wilms Message-Id: <20220724121940.305cef17dfd3b36f9376ef70@freenet.de> In-Reply-To: References: <20220717195635.20876ade1ec2b16da97cff14@freenet.de> <20220717180017.6850-1-t_w_@freenet.de> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-FN-MUUID: 1658657981F1F874303E1FO X-Originated-At: 2003:e4:f705:3000:88cc:adc4:b8cc:9a4b!57044 X-Scan-TS: Sun, 24 Jul 2022 12:19:41 +0200 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1658658030; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=20ZNxxZeM2jBc/w2xEEKuEGvyGBsm+TlRwgXVxamf7E=; b=owSRpBxpI9s+/fu4mFPYc3rS3Smst+odjCLbr2zVEXcwd/QME4kEfu0kQkhcECW84eO5F6 9s2LZdiBWic/gfZ/2dhdhKFdgY8Sk+YEk0wkj8aewk5goQBq+SQwjpKcAsE2d7ZH22q+1l UrcR5togpMd0yHQilyaNzfajDZOfZyVSBf8HdWPg796IrgAHJJhi2FC0rMjdLRH6EZtxkK SEXijzxi2OVCFlDxEXDmMcDRBJRuJgs1djnk8IPNJTYmxHEzxQbNhi2yJ5X3uYhRd108Gw eOZbNKyFC8NKvM/zZK7xvvUc9fm1uwePKb0TWPiewnVPSlVMaG4N2s56wy+ZEg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1658658030; a=rsa-sha256; cv=none; b=uCy+0YFef0VmLXP5dLpKIf+rdifb+TydbpyKvJQb+q+e/pVBcIMfTYoEQn02R4M0cHK3Xl NrRdx9c7Nokg+ie4nrMpBzU7VC/Y/Ukp1pFNNxlbHCVlR8IFd9fdDzICqzzNR/9s3OEdoe uOlXAT0jWg86jicaidQU1uqAe0tubCEi73pmp3YQ24fKlK4R0W0djUdO2kEu9JdnsKlbw1 tQnjupmKGqtk2zrwoTHxh905uEsQWg/7nRql6CkHj15vRO5Qpao/xxpKWBuBi5dj+g7q3R H1dsyHfmNyvvt+ZflOH9YdIKeVsdGTHDuSLPrK49QdFyTObRWHc/myWzz0bbsA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=freenet.de header.s=mjaymdexmjqk header.b=qSz2iIdC; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 0.67 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=freenet.de header.s=mjaymdexmjqk header.b=qSz2iIdC; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 8A8261E135 X-Spam-Score: 0.67 X-Migadu-Scanner: scn0.migadu.com X-TUID: lNT3KikziksE On Sat, 23 Jul 2022 15:29:31 +0200 Maxime Devos wrote: > > On 17-07-2022 20:00, Thorsten Wilms wrote: > > + (arguments > > + (substitute-keyword-arguments (package-arguments gx-guvnor-lv2) > > + ((#:make-flags flags) `(cons (string-append "CC=" ,(cxx-for-target)) ,flags)))) > > This presumably works but is fragile -- if at some point in time, > gx-guvnor-lv2 decides to change to a G-exp, this won't compile anymore. > Instead, you can do #~(cons (string-append "CC=" #$(cxx-for-target)) > #$flags), which works whether or not gx-guvnor-lv2 uses S-exps or G-exps. I admit that whole construct is from the helpful people in #guix, answering my question on how to still inherit, but add to the arguments. Also, what I used to know about quoting in Scheme, I have forgotten! > Also, I don't understand why you are doing CC=g++. CC stands for > c-compiler, not C++ compiler, so I would have expected "CC=" > #$(cc-for-target) or "CXX=" #$(cxx-for-target) instead, unless > gx-vbass-preamp-lv2 is not following these conventions. Well, CC=gcc was the intention, no idea how I mixed that up. BTW, where does cc-for-target come from and why doesn’t a simple string suffice? Thank you Maxime, for having a look and pointing out the issues! What should I send, where, now? Here’s the patch that has to change: * gnu/packages/music.scm (gx-vbass-preamp-lv2): Update to latest commit to fix build issue. --- gnu/packages/music.scm | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index 697fae8fc0..9174320ce0 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -49,6 +49,7 @@ ;;; Copyright © 2022 Maxim Cournoyer ;;; Copyright © 2022 Wamm K. D. ;;; Copyright © 2022 Jose G Perez Taveras +;;; Copyright © 2022 Thorsten Wilms ;;; ;;; This file is part of GNU Guix. ;;; @@ -4100,8 +4101,8 @@ (define-public gx-guvnor-lv2 (license license:gpl3+))) (define-public gx-vbass-preamp-lv2 - (let ((commit "eb999b0ca0ef4da40a59e458a9ab6e7042b96c99") - (revision "2")) + (let ((commit "a7613f91a12d46a7a08a13461e526353ede7def0") + (revision "3")) (package (inherit gx-guvnor-lv2) (name "gx-vbass-preamp-lv2") (version (string-append "0-" revision "." (string-take commit 9))) @@ -4112,8 +4113,11 @@ (define-public gx-vbass-preamp-lv2 (commit commit))) (sha256 (base32 - "0firap073ldw4nrykkd7jvyyj0jbl1nslxyzjj4kswazp99x7d9h")) + "00yj1v3pdry2ns9gv11zcap7prg0yix2vr66rljjpx3nz94fqk4b")) (file-name (string-append name "-" version "-checkout")))) + (arguments + (substitute-keyword-arguments (package-arguments gx-guvnor-lv2) + ((#:make-flags flags) #~(cons (string-append "CC=" #$(cc-for-target)) #$flags)))) (inputs (list lv2 gtk+-2)) (native-inputs -- 2.37.0 -- Thorsten Wilms