From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YJxsBdNAlmLVRgAAbAwnHQ (envelope-from ) for ; Tue, 31 May 2022 18:22:43 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id eHczBdNAlmJhBgAAauVa8A (envelope-from ) for ; Tue, 31 May 2022 18:22:43 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9D86F17CBF for ; Tue, 31 May 2022 18:22:42 +0200 (CEST) Received: from localhost ([::1]:46974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nw4dl-0006Ja-Ph for larch@yhetil.org; Tue, 31 May 2022 12:22:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43046) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nw4RY-0006DW-0e for bug-guix@gnu.org; Tue, 31 May 2022 12:10:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54838) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nw4RX-0002Xr-M3 for bug-guix@gnu.org; Tue, 31 May 2022 12:10:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nw4RW-0004Oa-Du; Tue, 31 May 2022 12:10:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#55499: [PATCH 0/3] Make 'manifest' files more compact Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: rekado@elephly.net, bug-guix@gnu.org Resent-Date: Tue, 31 May 2022 16:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55499 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 55499@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Ricardo Wurmus X-Debbugs-Original-Xcc: Ricardo Wurmus Received: via spool by 55499-submit@debbugs.gnu.org id=B55499.165401339316846 (code B ref 55499); Tue, 31 May 2022 16:10:02 +0000 Received: (at 55499) by debbugs.gnu.org; 31 May 2022 16:09:53 +0000 Received: from localhost ([127.0.0.1]:48727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nw4RL-0004NQ-G7 for submit@debbugs.gnu.org; Tue, 31 May 2022 12:09:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nw4RJ-0004N8-2f for 55499@debbugs.gnu.org; Tue, 31 May 2022 12:09:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41042) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nw4RD-0002LP-Qf; Tue, 31 May 2022 12:09:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=4FzyPDQ2/wKppshfTjMndtEDbgCepbz97k16beuPG+Q=; b=ODRWGHVaFZ4SZMYOd2qM /UyhfoZct0dVVyKIvtiG+ycKZuznZs9YSdxXH06C5c98ALXaHIbUOb/5vEKio99rK6ft6SLOpqsMt yYQURFweTot6dkB2m6Zn9SyZVCQl4803zO3miEPpxiDgYnOybOzeuaXXQ+6Nm9USMSgzThXwmoYoZ ApujuYiFWzXFBzEs+rDX9qRhysga9esRhJ5SPO+CTyo0fmvyZtHZYa4ouo3mPl8j+nHsFHfHkbmwu VRXl3M1pjHvjPJUPGjxdStWbPySLXQtD+sTKk3kZj17PTQj/zn7DLfblIs5QGlzZJP94qvwDyFhqm WAx2sBilXsI/5w==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=52502 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nw4R9-00067m-FK; Tue, 31 May 2022 12:09:42 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Date: Tue, 31 May 2022 18:09:13 +0200 Message-Id: <20220531160916.21508-1-ludo@gnu.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <87sfp7kkim.fsf@elephly.net> References: <87sfp7kkim.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654014162; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=4FzyPDQ2/wKppshfTjMndtEDbgCepbz97k16beuPG+Q=; b=FpYpSUba3wNmcAJwYQoPjd6lRs9yUEMrtAsqomHjQEjsGZWTn0jqHILjNimzJ8o6NKqV45 zTM0IjYeAqbGvU1P6LWknTPH/odainChbJgG5i1sCYaZA7I7zobceUU0Z1pxwBaX1ZVYFA sgj98gmetEXKaRBl+E3/Z01EmJ3HdV82AmjnVnTaLGmgZnldhXYzK/Ca1hpq/A1rlab12t vW2GoxPcEWMOwQAdV+zgUqeamBdEMiddw35eKvpTqbkYw8d5oowsmmfbssCruPSOAzFQgN /Ocvp9tXqa31wFpOX+kaGQ48Wt/Gurwm/RwrfV6ZN4bvlXfPpK/18opm6gTpfA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654014162; a=rsa-sha256; cv=none; b=H7BLT0DCssBU9WHQ9BB1oKbr72Q9N0bT1ttd1NDbLvu2feLYJb/jv4qUtddptYB2inRq4D NsiaIUcscNfjFT+mYshF1QWZonO4rAHQdXjHEvxvMEiqn/SI+Ed48Ewf9h3aSGky9sQw7X hJjzr8PqCxGNSk8voEr8iFtCMzfEfsAxwyXfvs0iyqml+k29piWmCIcpkUEgw964cm8fS6 CPFr70J29R0AWF8YCjl1ySK6VX3pg1DMR7b82QSZ7kFxBVlJOyhcTWduOYD6o9SKtK8q/K bCKRaT9+SeyT4HaQqITqtlYsLvoH9CEkQug8KexBLcg1r5/1EwmegW4rehvmRA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=ODRWGHVa; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.94 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=ODRWGHVa; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9D86F17CBF X-Spam-Score: -2.94 X-Migadu-Scanner: scn1.migadu.com X-TUID: 4a8aZTxCneti Hello, These patches implement what you suggested on IRC: not repeating entire manifest entries and their propagated inputs. This has a dramatic impact on the size of the ‘manifest’ file and on the memory and processing time to read it for the the use case you gave. The second patch goes a tiny bit further by making the ‘search-paths’ and ‘propagated-inputs’ fields optional, shaving another ~10% on the size of ‘manifest’ in this example. The second patch should be squashed with the first one (so we don’t bump version formats a second time and duplicate code). It’s kinda optional because it doesn’t bring much compared to the first patch and causes a bit of extra complexity, but maybe it’s still worth keeping? Could you try this on your larger use cases and tell me how it goes? Thanks, Ludo’. Ludovic Courtès (3): tests: Augment profile collision test. profiles: Do not repeat entries in 'manifest' file. squash! profiles: Make all entry fields optional. guix/build/profiles.scm | 32 ++++++++-- guix/profiles.scm | 137 ++++++++++++++++++++++++++++++++-------- tests/profiles.scm | 52 ++++++++++++++- 3 files changed, 187 insertions(+), 34 deletions(-) base-commit: fed51b26141548a5bae349a5e1d8d6f681320f4f -- 2.36.1