From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 6Ex/D4Xoj2JU+QAAbAwnHQ (envelope-from ) for ; Thu, 26 May 2022 22:52:21 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id UDSpDoXoj2IWKgAAG6o9tA (envelope-from ) for ; Thu, 26 May 2022 22:52:21 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CBD76F178 for ; Thu, 26 May 2022 22:52:20 +0200 (CEST) Received: from localhost ([::1]:40950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nuKSx-0005QY-OM for larch@yhetil.org; Thu, 26 May 2022 16:52:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuKRl-0004Z1-Dd for bug-guix@gnu.org; Thu, 26 May 2022 16:51:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38020) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nuKRi-0001L3-S1 for bug-guix@gnu.org; Thu, 26 May 2022 16:51:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nuKRi-0005lv-Pn for bug-guix@gnu.org; Thu, 26 May 2022 16:51:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#55441: [PATCH 2/2] Improve thread safety of piped-process. Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 26 May 2022 20:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55441 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Christopher Baines Cc: 55441@debbugs.gnu.org, Josselin Poiret Received: via spool by 55441-submit@debbugs.gnu.org id=B55441.165359825522159 (code B ref 55441); Thu, 26 May 2022 20:51:02 +0000 Received: (at 55441) by debbugs.gnu.org; 26 May 2022 20:50:55 +0000 Received: from localhost ([127.0.0.1]:60148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuKRb-0005lG-73 for submit@debbugs.gnu.org; Thu, 26 May 2022 16:50:55 -0400 Received: from jpoiret.xyz ([206.189.101.64]:49112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuKRZ-0005l6-PF for 55441@debbugs.gnu.org; Thu, 26 May 2022 16:50:54 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 92C3C1851E0; Thu, 26 May 2022 20:50:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1653598253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jyI1w3v4SM61nS6P+eq8N3bLtYPmZXK0BiZU/x8DsbI=; b=puupIP5hAJWOCvg9tlwBEGnWvJDaYub9r7//d8kxqTSopNzcE2YQIhgYzebof+eHOiO0yh UnIOQUMQjyy2UViL0E2NlrKA/mugmLwYZ85fBrCeiOZiGqbXsiXVTsE9ku/W3tTp5gF1Ko 3wqUjNxFUAXEd4xpIXE0iZVLyfxybquDfPljp4Xjzp0ZxViuJJmeyecgyW+x80m+k/zlSN W/wC2XIzafcHOTxrTnIz5nH6CrkCGVvVk6NcKYkeaiCvy46ydwvDiT21kzQyqqkDei1aIe RmxUVOVDCkNNcf+EIDrjPUO3WakRVLpn5it3aCQS/v0UCrW2WqPxGzro+J3iXA== Date: Thu, 26 May 2022 22:50:47 +0200 Message-Id: <20220526205047.23960-2-dev@jpoiret.xyz> In-Reply-To: <87sfow10lc.fsf@jpoiret.xyz> References: <87sfow10lc.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Bar: / X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" Reply-to: Josselin Poiret From: Josselin Poiret via Bug reports for GNU Guix X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653598340; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=jyI1w3v4SM61nS6P+eq8N3bLtYPmZXK0BiZU/x8DsbI=; b=SKvh7NykG1+RqnYlUaAbiFIPS7BuuLjCQlXDKJn13mbWbV0E9jzBGWrjcytsckMcdD0/kC 9D2Dz1KR8uMLuFFotINewgUyPz7ufWuhCS86L8pFeUIJ6D/QkVuYN2e+T5xlyxe7MkvcU+ /3jhnX86yEbTO/g8+WDFyt4a7sL3HKjITO/KnnmqTKxfVa+eceZ+HGVSNTRynQTYo4qSuH DH1SgyCScZEGUHTLqWsHKJkRRhDdlXC4e8MyzXa0aJQ62yxUdE6l8bBdvMoJNx5aCLtQMr lNS8L5n23b2nR4fOL2tQ2lQEDgwC1eaJcSeWr4HJeM0G2xCjv7ZjNLLXvt+Gcg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653598340; a=rsa-sha256; cv=none; b=sK/WUnFtjtTzfuaTsKLMySAC/vR08g+9Ok9qRmU8+HxDt3BXWstWwJ3ZCkB1bDFl6Z1DzP G69MY4WFK84dvKzKZgWRwRDoWFHZp2pkSKQ/9tvFpQ7oLmgDkV69ae5ObKCvAchBEsOSqj 0Pc98BB88RVIyx90m8Cnhj8nPdjO2OIgVEHkQ29oWv6YnJ77j2G5KvbXWCNR5/Q+s0pr15 58o0GFKQjMpncl7nMM60f9i1VbawYNLw5BU4gZ/FfTA4B3jJusP9nVJ0aOF61YJxNxgjPY 8j+OjJXNEJ0ZS6zCmyIuAtVQKOGqdSEUAGLA1b9/wuDypobqT8T6WG6xq7z9Ug== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=puupIP5h; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.34 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=puupIP5h; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: CBD76F178 X-Spam-Score: -2.34 X-Migadu-Scanner: scn0.migadu.com X-TUID: i/Jtg9GxkN82 * libguile/posix.c (scm_piped_process): Avoid double close. --- libguile/posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libguile/posix.c b/libguile/posix.c index dc3080b3c..e134408e3 100644 --- a/libguile/posix.c +++ b/libguile/posix.c @@ -1486,7 +1486,7 @@ scm_piped_process (SCM prog, SCM args, SCM from, SCM to) SCM_SYSERROR; } - if (reading) + if (reading && !(writing && c2p[1] == p2c[0])) close (c2p[1]); if (writing) close (p2c[0]); -- 2.36.0