From: Josselin Poiret via Bug reports for GNU Guix <bug-guix@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 54783@debbugs.gnu.org, Stefan Baums <baums@stefanbaums.com>,
Josselin Poiret <dev@jpoiret.xyz>
Subject: bug#54783: [v2 0/2] Clarify zram priority
Date: Tue, 24 May 2022 19:16:29 +0200 [thread overview]
Message-ID: <20220524171631.25011-1-dev@jpoiret.xyz> (raw)
In-Reply-To: <87o7zn3pkf.fsf_-_@gmail.com>
Hello Maxim,
Thanks for looking at this. Here's a v2.
Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
> I'm curious, what does delaying the field buys us here? Is it to avoid
> printing the warning multiple times when the record is evaluated?
Right, and this would get worse if someone ended up inheriting from
another configuration. It would be bad UX IMO.
> By convention, a warning message should not be a complete sentence (no
> capitalized first letter nor last period) and be short. To provide a
> human friendly hint/message, you could use 'display-hint' (combined with
> a more succinct warning).
Right, fixed!
> The rest LGTM.
>
> Maxim
Josselin Poiret (2):
system: Align zram priority with swap-space spec to clarify.
doc: Remove double copyright.
doc/guix.texi | 11 +++++------
gnu/services/linux.scm | 29 ++++++++++++++++++++++++++---
2 files changed, 31 insertions(+), 9 deletions(-)
--
2.36.0
next prev parent reply other threads:[~2022-05-24 17:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 2:27 bug#54783: ZRAM default priority wrong Stefan Baums
2022-04-21 7:57 ` Josselin Poiret via Bug reports for GNU Guix
2022-04-21 8:06 ` Stefan Baums
2022-04-21 13:49 ` bug#54783: [PATCH 1/2] system: Align zram priority with swap-space spec to clarify Josselin Poiret via Bug reports for GNU Guix
2022-05-24 15:42 ` bug#54783: ZRAM default priority wrong Maxim Cournoyer
2022-05-24 17:16 ` Josselin Poiret via Bug reports for GNU Guix [this message]
2022-05-24 17:16 ` bug#54783: [PATCH v2 1/2] system: Align zram priority with swap-space spec to clarify Josselin Poiret via Bug reports for GNU Guix
2022-05-24 17:16 ` bug#54783: [PATCH v2 2/2] doc: Remove double copyright Josselin Poiret via Bug reports for GNU Guix
2022-04-21 13:49 ` bug#54783: [PATCH " Josselin Poiret via Bug reports for GNU Guix
2022-06-11 5:56 ` bug#54783: ZRAM default priority wrong Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220524171631.25011-1-dev@jpoiret.xyz \
--to=bug-guix@gnu.org \
--cc=54783@debbugs.gnu.org \
--cc=baums@stefanbaums.com \
--cc=dev@jpoiret.xyz \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).