From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id oPsCB+VZkmEjOgAAgWs5BA (envelope-from ) for ; Mon, 15 Nov 2021 14:00:21 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id wPyVAuVZkmHkVQAAbx9fmQ (envelope-from ) for ; Mon, 15 Nov 2021 13:00:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 98C822A3FB for ; Mon, 15 Nov 2021 14:00:20 +0100 (CET) Received: from localhost ([::1]:44720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmbat-00010H-Pw for larch@yhetil.org; Mon, 15 Nov 2021 08:00:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53418) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmbae-0000xw-G6 for bug-guix@gnu.org; Mon, 15 Nov 2021 08:00:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41376) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mmbac-0006DT-HG for bug-guix@gnu.org; Mon, 15 Nov 2021 08:00:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mmbac-0007AM-9k for bug-guix@gnu.org; Mon, 15 Nov 2021 08:00:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#51693: [patch] Add Java 17 Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 15 Nov 2021 13:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51693 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: "Dr. Arne Babenhauserheide" Received: via spool by 51693-submit@debbugs.gnu.org id=B51693.163698116627471 (code B ref 51693); Mon, 15 Nov 2021 13:00:02 +0000 Received: (at 51693) by debbugs.gnu.org; 15 Nov 2021 12:59:26 +0000 Received: from localhost ([127.0.0.1]:52922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmba1-000790-Uq for submit@debbugs.gnu.org; Mon, 15 Nov 2021 07:59:26 -0500 Received: from lepiller.eu ([89.234.186.109]:38928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmbZz-00078n-Tb for 51693@debbugs.gnu.org; Mon, 15 Nov 2021 07:59:25 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 260fa3d2; Mon, 15 Nov 2021 12:59:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=dkim; bh=+seZVHz4B8+B l4NaFLZNT4SYDkT41gkg1Zt4+C9vb+M=; b=eEKH8jRC9bfcXpnIpvRLY+qPdtA7 brqNZ3Fbt/jmQjcLmdnc7XUZXlZpzorxX22j1HTmFgA5Yn2/yDaFqZ/K4FYesE9A 5G7ZgNSuXBCCkLMf1y95iMqwzf9hYlqf9353DyiTyLLCAW8QaNMCQdA6LdlD+rFV XKdZjQDmPcsJFElt2LdQ4kYyqOKM46e9QJhXosxZzJzycDqQk6/647OgEjAnZuWU E1lZX3wkkMfO1FzvKSWWxhuiZXa55+Xh7Of91QZHk3N0Jv4amg7VpAY5hCMrpniX TKqywDv7obYv6MsgtSYH7Lz8ypoOH7oK0xMgrjYkzb4ryaUzyhXutBveVA== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 78dc68d6 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Mon, 15 Nov 2021 12:59:19 +0000 (UTC) Date: Mon, 15 Nov 2021 13:59:12 +0100 From: Julien Lepiller Message-ID: <20211115135912.708ef981@tachikoma.lepiller.eu> In-Reply-To: <87zgq61hmw.fsf@web.de> References: <87y25yxu7y.fsf@web.de> <20211114165407.5223d22f@tachikoma.lepiller.eu> <87zgq61hmw.fsf@web.de> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.24; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 51693@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636981220; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=+seZVHz4B8+Bl4NaFLZNT4SYDkT41gkg1Zt4+C9vb+M=; b=RLcE4k7TgW5HPiVFqYeAb35YkQKFgpCb3yJB6I4H/RY/Yxg4Y9JHEMgbPF3hjiKLjuQioc cP5pcVySbCdFYCDCiV3UOAtGqiOXhxqlpfcxalXVr20KbUmkzUrti8+o3zaw8bMqQg8NvC oxWNJFNHEBLWTiAAKgPo77USMifuBkVpUSeYU5LuFMMl2rMEk/RoqZsw84wypXZZb5aFaz YtD6bGxcTo+4NNLq3k8PYVrLZwC6pGBJhq0zq/kFGmDhOPsZQ7nrj6CRZT2x60ddXMuPFy NS1hqS3COWsZD5sNX2tEqCZyEW9r1qWxvocQOcHUWRgsqyfWm586HGAzXHPl7w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636981220; a=rsa-sha256; cv=none; b=GsrLODIEZ2Z1Ghp/+Omd43J/MLDClunhhM3kUNSLKVONCQjlzxJA+iZxrMWjhVst7kej/H 6g8tQC+gbIDMq3KkRaqR9wnJNyI4QHeVoReJvVJAoMFdE67aQB4sojLJtlzWXISybEKZcE 6Mhv/D+M+dZs4CJpQ+cuNqBFF25g2tkroyfcwn98XCfXgivPd1ST8sdOsf0mELHnaB+a1i p62T3JZXpMfBviFy51y/UvLYoBp9OBwg0gM8GS9VcWcTdTUBZd0r5I37kDueShnD+PbiTt YwhbD3av9rA2K007cwHIBaCGCQVVxJf1VoY6jr8I1dOweZ9wpjg+X65oVhQ4cQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=eEKH8jRC; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.84 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=eEKH8jRC; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 98C822A3FB X-Spam-Score: -1.84 X-Migadu-Scanner: scn0.migadu.com X-TUID: Jss+O10X3yPP Hi, I think you fixed openjdk16 instead of openjdk17, this makes the patch a bit confusing to read. Le Sun, 14 Nov 2021 21:59:44 +0100, "Dr. Arne Babenhauserheide" a =C3=A9crit : > Julien Lepiller writes: >=20 > > Le Mon, 08 Nov 2021 21:32:16 +0100, > > "Dr. Arne Babenhauserheide" a =C3=A9crit : > > =20 > >> the attached patch adds openjdk@17 > >>=20 > >> Take care with updating packages depending on this, because the > >> changes to the module system can cause runtime failures. =20 >=20 > > sorry for the delay. =20 >=20 > No problems =E2=80=94 thank you for checking my patch! >=20 > > I tried your patch, but the build fails for me > > because it goes "out of file descriptors" and "unix resources". > > Does it work for you? =20 >=20 > It works for me, yes. >=20 > ./pre-inst-env guix environment --ad-hoc openjdk@17:jdk -- java > -version =E2=80=A6 > openjdk version "17.0.1" 2021-10-19 > OpenJDK Runtime Environment (build 17.0.1+0-adhoc..source) > OpenJDK 64-Bit Server VM (build 17.0.1+0-adhoc..source, mixed mode, > sharing) >=20 > > I tried with various levels of parallelism, but it did not > > change anything. > > > > also about your patch, could you replace (invoke "chmod" "u+w" file) > > with a call to make-writable? =20 >=20 > Do you mean `make-file-writable` ? I switched to that now. >=20 > > It's available by default in the build > > environment, it comes from (guix build utils). I wonder also why you > > inherit arguments from openjdk15 instead of openjdk16? =20 >=20 > That was a mistake =E2=80=94 thank you! >=20 > I attached a new patch. >=20