From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ELYCFB8XkWHbeQAAgWs5BA (envelope-from ) for ; Sun, 14 Nov 2021 15:03:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id aFqcDx8XkWE/SAAAB5/wlQ (envelope-from ) for ; Sun, 14 Nov 2021 14:03:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0FAC714D3C for ; Sun, 14 Nov 2021 15:03:11 +0100 (CET) Received: from localhost ([::1]:48466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmG6A-0006rj-75 for larch@yhetil.org; Sun, 14 Nov 2021 09:03:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmG63-0006rb-5o for bug-guix@gnu.org; Sun, 14 Nov 2021 09:03:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37958) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mmG62-00025Y-Td for bug-guix@gnu.org; Sun, 14 Nov 2021 09:03:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mmG62-0006ZP-JJ for bug-guix@gnu.org; Sun, 14 Nov 2021 09:03:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#51798: [PATCH] gnu: bashtop: Add dependencies and wrap program with PATH Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 14 Nov 2021 14:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51798 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Lenny =?UTF-8?Q?H=C3=A4ndler?= , 51798@debbugs.gnu.org Cc: Josselin Poiret Received: via spool by 51798-submit@debbugs.gnu.org id=B51798.163689853725202 (code B ref 51798); Sun, 14 Nov 2021 14:03:02 +0000 Received: (at 51798) by debbugs.gnu.org; 14 Nov 2021 14:02:17 +0000 Received: from localhost ([127.0.0.1]:49504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmG5I-0006YP-LT for submit@debbugs.gnu.org; Sun, 14 Nov 2021 09:02:16 -0500 Received: from jpoiret.xyz ([206.189.101.64]:33514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmG5G-0006YH-NH for 51798@debbugs.gnu.org; Sun, 14 Nov 2021 09:02:15 -0500 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 57097184F2A; Sun, 14 Nov 2021 14:02:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1636898533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ri2YkiCTsEQ3SG2bOzAbrCmj6MRI3WNVusxuD6JcAc0=; b=dmjTJ2YqgWZABoRgQlJZKVGoGUgo1KTcpQCUKX1RvkbecqBGLH7t0dJUgiHHQ6J0xZq+Da JDENl849VsDP3vubj2o4LcU3lkZDAQKbfJp9Up17z2DEAwfVf0lj3rXnwPbLc+zGm9K0B8 y67Q1T4GSiSvfh5r2PW+Xj9c4MkYZ3XWVnPWoXzjTNDLXNtYDM3XSupFmElRpCMNGh2vG7 kOSw93hyE+VEeFzdyCOCKAtMu2ymQU1hRU4uw8rbNIP0DpBG+P5IHJr2wbK9yD3JTR/6cV L7AUxkpOnqpZUVmvZl9ojX1jxC4Ra2f6b5D26wR4uywwiwRcSmct6f3bKh+o0g== Date: Sun, 14 Nov 2021 14:01:37 +0000 Message-Id: <20211114140137.13868-1-dev@jpoiret.xyz> In-Reply-To: <0fe8420a-dae9-92e8-5dfb-b52260a7c669@lennyhaendler.com> References: <0fe8420a-dae9-92e8-5dfb-b52260a7c669@lennyhaendler.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Bar: ++++ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" Reply-to: Josselin Poiret From: Josselin Poiret via Bug reports for GNU Guix X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636898591; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ri2YkiCTsEQ3SG2bOzAbrCmj6MRI3WNVusxuD6JcAc0=; b=ps2dBsMR1K60nrhaXVAUaIEWzMEEnlvlibgwdNo+rIof2nEeeaD2/8yK+H87/L10BL6wX5 kSbc6O9zdpSl9o5kKuOk5EXCjAOONW5wqbA77wNFv0pWay6QyEWgxGEIlacVyIBEab5RVl CdPLOFjLP9j3Pwa28Bu9kkSzWcOUQONCUB0fxPMKCjlJ3E34E75+lj5W+vPz3nWgvY5R5L ypKDdUu5FK1CvTwlLW0Sn0QvQk07U6pE8ki8iPfWGMYKm0OQMjmUJV4HzRZ/g3v4T5y7Ab thI/hUDutq7rUfVth1N6SkVFnWKbhM60oVJq+tn6FO7Lu13fYnv4Jp3vEZbrvg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636898591; a=rsa-sha256; cv=none; b=HI7rq5UNhqyETUJkvLlwFXZBuCgLrclwN3pCUnzHqRYC+acSsi4Gp5NiZKwIXOw3KDrnL4 JQueA47XfbJZTkP46XSRNtMQtn93ABvqTl8FJFqp2d7T44dvn0ns9O970XqiUjGbuOvlby nM4Q1pu4EUvMFTzI4NiLoPrUndWCxzNCphrDqf23x8KTW2+VwdrE68mXr5zefwUr1/reIo THqYDGD7Dd2Iti/ShOnB7uc5s2JfTYN3XxhkAjnnOGjqMRs9hKqRV6dpF4R1qiAkM3R394 SshGQvyx/3IoILe6rTE/8fSEtTL1BO9l1enwrEECZhNJ7csHBa57e6Xym0xZvg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=dmjTJ2Yq; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.34 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=dmjTJ2Yq; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0FAC714D3C X-Spam-Score: -1.34 X-Migadu-Scanner: scn0.migadu.com X-TUID: p+DBe120T67n You're right, none of the needed dependencies of bashtop were actually present in the package definition. Here is a patch that does work on my machine using `guix shell --pure bashtop -- bashtop`. Best, Josselin Poiret -- >8 -- * gnu/packages/admin.scm (bashtop): Add dependencies, wrap the script so that it can access the commands it needs. --- gnu/packages/admin.scm | 27 +++++++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm index 2a7b0f310d..8f9125212c 100644 --- a/gnu/packages/admin.scm +++ b/gnu/packages/admin.scm @@ -71,6 +71,7 @@ (define-module (gnu packages admin) #:use-module (guix build-system python) #:use-module (guix build-system ruby) #:use-module (guix build-system trivial) + #:use-module (guix build-system copy) #:use-module (guix download) #:use-module (guix git-download) #:use-module ((guix licenses) #:prefix license:) @@ -670,11 +671,29 @@ (define-public bashtop (sha256 (base32 "07nlr6vmyb7yihaxj1fp424lmhwkdjl6mls92v90f6gsvikpa13v")))) - (build-system gnu-build-system) + (build-system copy-build-system) (arguments - '(#:make-flags (list (string-append "PREFIX=" %output)) - #:tests? #f ; bats test fails with loading load.bash - #:phases (modify-phases %standard-phases (delete 'configure)))) + '(#:install-plan '(("./bashtop" "./bin/bashtop")) + #:phases (modify-phases %standard-phases + (add-after 'install 'wrap + (lambda* (#:key outputs #:allow-other-keys) + (let ((paths (map (lambda (program) + (dirname (which program))) + '("awk" "dd" "grep" "ip" + "locale" "ps" "sed"))) + (bashtop (string-append (assoc-ref outputs + "out") + "/bin/bashtop"))) + (wrap-program bashtop + `("PATH" ":" = ,paths)))))))) + (inputs + `(("coreutils" ,coreutils) + ("gawk" ,gawk) + ("glibc" ,glibc) ; for 'locale' + ("grep" ,grep) + ("iproute" ,iproute) + ("procps" ,procps) + ("sed" ,sed))) (home-page "https://github.com/aristocratos/bashtop") (synopsis "Linux/OSX/FreeBSD resource monitor") (description "Resource monitor that shows usage and stats for processor, -- 2.33.1