From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QL6ZK8JTMmGjbAEAgWs5BA (envelope-from ) for ; Fri, 03 Sep 2021 18:56:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id WAxRJ8JTMmFvPAAAbx9fmQ (envelope-from ) for ; Fri, 03 Sep 2021 16:56:34 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E82A4673 for ; Fri, 3 Sep 2021 18:56:33 +0200 (CEST) Received: from localhost ([::1]:59916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mMCUS-0005TM-VJ for larch@yhetil.org; Fri, 03 Sep 2021 12:56:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMCS2-0003vz-FF for bug-guix@gnu.org; Fri, 03 Sep 2021 12:54:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34294) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mMCS2-0007Ho-0c for bug-guix@gnu.org; Fri, 03 Sep 2021 12:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mMCS1-000153-R4 for bug-guix@gnu.org; Fri, 03 Sep 2021 12:54:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#50346: core-updates-frozen: strace 5.13 fails "make check" on AArch64 Resent-From: Bengt Richter Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 03 Sep 2021 16:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50346 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Simon South Received: via spool by 50346-submit@debbugs.gnu.org id=B50346.16306880284134 (code B ref 50346); Fri, 03 Sep 2021 16:54:01 +0000 Received: (at 50346) by debbugs.gnu.org; 3 Sep 2021 16:53:48 +0000 Received: from localhost ([127.0.0.1]:45840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMCRo-00014c-D1 for submit@debbugs.gnu.org; Fri, 03 Sep 2021 12:53:48 -0400 Received: from imta-37.everyone.net ([216.200.145.37]:57960 helo=imta-38.everyone.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMCRn-00014V-5o for 50346@debbugs.gnu.org; Fri, 03 Sep 2021 12:53:47 -0400 Received: from pps.filterd (m0004962.ppops.net [127.0.0.1]) by imta-38.everyone.net (8.16.0.43/8.16.0.43) with SMTP id 183Gl7dc020867; Fri, 3 Sep 2021 09:53:46 -0700 X-Eon-Originating-Account: oaPLf34qVV4C3NT07fPBwpcx3c_0xMSfkBAp-8j_AYI X-Eon-Dm: m0116787.ppops.net Received: by m0116787.mta.everyone.net (EON-AUTHRELAY2 - 53b92e8b) id m0116787.611f98ad.fc47c; Fri, 3 Sep 2021 09:53:44 -0700 X-Eon-Sig: AQMHrIJhMlMYBv0e9AIAAAAC,f341fdcb756dd2e1d55c1ba8998338d9 X-Eip: o7JDIqqJ0PvuwmMCDWezEVfY9cXg7Jy6D85uVZ1Q_DQ Date: Fri, 3 Sep 2021 18:53:35 +0200 From: Bengt Richter Message-ID: <20210903165335.GA10190@LionPure> References: <875yvi93w8.fsf@simonsouth.net> <877dfy7g8n.fsf@simonsouth.net> <20210903121513.GA5202@LionPure> <877dfxbvy6.fsf@simonsouth.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <877dfxbvy6.fsf@simonsouth.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-Proofpoint-GUID: K9zWgqgLmdg_-bTzzsQzD1X0MpaZUreF X-Proofpoint-ORIG-GUID: K9zWgqgLmdg_-bTzzsQzD1X0MpaZUreF X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-09-03_07:2021-09-03, 2021-09-03 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 impostorscore=0 malwarescore=0 phishscore=0 adultscore=0 lowpriorityscore=0 mlxlogscore=999 clxscore=1034 spamscore=0 suspectscore=0 priorityscore=1501 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000 definitions=main-2109030099 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Bengt Richter Cc: 50346@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630688194; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=NSyMYQgMU6D7QkhpNL0Fy1TZ2sah+YlEjYDifIg2LUI=; b=NCzunYDRBOXi7jW6XRQO1iPlx1RnOVTNJMNkVspeAT4NHluJb3qvQLMQ1gEgUr60LGJTAj JV8wnN2YkoryNZQ+dSSKJhmsY4QUjuxkwsorBr3SMHb0Od3ZTKZaVjhiL0IYN1+bO5XTEj VZhm4uK/kgmpEV2o1jw7ut6n3fGD6P6fQbMVRKW+dA8u2RAzEzyYT8OYJT7yLtmR/lnvHd 5ZVXxHS61lzCCCljAhpGvIFNODAcxBBSHXy+v27N4rROtPgWVQuS8rj27TSsST7I7S/SBV /qcKOSAE7J13Hd0c7vPqXxz/vqJgFvpNNjkeinbe7tFBPvu1bAoG6VkleflMWA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630688194; a=rsa-sha256; cv=none; b=imGqTOeQ3HiQ7H501C1fTWDNPgipgIA4W6+1wkWWnG1pgKNVSLVFp3XX8xRZaA5iULNsnh JNR+61U3C9qCwTTV8lF1kPsl98FbtPRC1DmLn7S+v71ZEcjtC5US567BOazfjZWvdZjBua vEt7eZl60WYqiP+/N7DwLgq63Z7WLi34kDUWpqoup7IPc2YzoTv2mwS0c52X7r5SumiO3K 8h1nF3xmH8RZmY6guZN+Gyxps4evAJrbjjfGeCqjTZiNvhq+ZRNDpi1N39m42x+QsNDptR UtRoCE6UmVmZTN3yaLZAm9I++VPMkg3567ukftJcOdv5U5zL++F87YkVASEp4g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -1.92 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: E82A4673 X-Spam-Score: -1.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: NP1DQlP/MyhM On +2021-09-03 10:00:33 -0400, Simon South wrote: > Bengt Richter writes: > > A proper configurability, ISTM, would be preferable to any other form > > of more general filtering. > > I agree with you on the need to be cautious around modifying test cases > but I'm not sure I follow you otherwise. What would "proper > configurability" look like in this case? > > The change I'm proposing here narrows the two test cases so they test > only what appears to have been intended, i.e. that strace can capture > readlink(at) system calls and that it reports them in the format > expected by the developers. It does not affect other test cases or the > test suite as a whole. > > The obvious alternative would be to modify the test cases' expected > output to match what is actually generated, but this could have the side > effect of tying the package to Linux and perhaps to specific versions of > glibc. Well, that would be the point :) I.e., to move the customizations into .conf files and out of test-suite sources. > > That said I'm still not sure why this additional syscall is being made > in the first place, only that it appears to originate from glibc's > "_dl_get_origin" function[0]. If I build strace from source "manually" > the tests complete fine without modification. I presume the extra call > has to do with the fact Guix builds strace inside a container; does > anyone know how this could be affecting the way programs are loaded? > I did not realize there were mods to strace itself affecting this. I thought it was about somehow filtering its output to fool tests, sorry. With strace variants maybe "proper configurability" should have to consider strace versions also, to tune test expectations ;/ > -- > Simon South > simon@simonsouth.net > > [0] See e.g. glibc's sysdeps/unix/sysv/linux/dl-origin.c for the x86-64 > case, as well as "_dl_non_dynamic_init" in elf/dl-support.c, which > seems to be the only place it is called. -- Regards, Bengt Richter