From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UDorDpwTMmGJ5wAAgWs5BA (envelope-from ) for ; Fri, 03 Sep 2021 14:22:52 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id AGtECpwTMmFZcAAAB5/wlQ (envelope-from ) for ; Fri, 03 Sep 2021 12:22:52 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7EE881AFBA for ; Fri, 3 Sep 2021 14:22:51 +0200 (CEST) Received: from localhost ([::1]:33098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mM8Da-0004ye-Gj for larch@yhetil.org; Fri, 03 Sep 2021 08:22:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34614) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mM8Co-0004xh-8G for bug-guix@gnu.org; Fri, 03 Sep 2021 08:22:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59924) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mM8Cn-0007VS-Us for bug-guix@gnu.org; Fri, 03 Sep 2021 08:22:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mM8Cn-0006Ht-O8 for bug-guix@gnu.org; Fri, 03 Sep 2021 08:22:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#50346: core-updates-frozen: strace 5.13 fails "make check" on AArch64 Resent-From: Bengt Richter Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 03 Sep 2021 12:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50346 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Simon South Received: via spool by 50346-submit@debbugs.gnu.org id=B50346.163067166524103 (code B ref 50346); Fri, 03 Sep 2021 12:22:01 +0000 Received: (at 50346) by debbugs.gnu.org; 3 Sep 2021 12:21:05 +0000 Received: from localhost ([127.0.0.1]:43237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mM8Bs-0006Gh-Sm for submit@debbugs.gnu.org; Fri, 03 Sep 2021 08:21:05 -0400 Received: from imta-37.everyone.net ([216.200.145.37]:43378 helo=imta-38.everyone.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mM8Bp-0006Fz-JX for 50346@debbugs.gnu.org; Fri, 03 Sep 2021 08:21:03 -0400 Received: from pps.filterd (localhost.localdomain [127.0.0.1]) by imta-38.everyone.net (8.16.0.43/8.16.0.43) with SMTP id 183CDDxe028270; Fri, 3 Sep 2021 05:20:59 -0700 X-Eon-Originating-Account: Dr8LztROKqga6csNU72rRAFAC1pdfHBZWW6vSlL2H-0 X-Eon-Dm: m0116787.ppops.net Received: by m0116787.mta.everyone.net (EON-AUTHRELAY2 - 5a81c5e6) id m0116787.611f98ad.f7451; Fri, 3 Sep 2021 05:15:21 -0700 X-Eon-Sig: AQMHrIJhMhHZnpXIowIAAAAC,e4733b03bae20c8c84ac5c1169bc4de5 X-Eip: 3dKKpsUI-g4akfKJ-qQ69B89B80rRrbpGIP05VXqRpA Date: Fri, 3 Sep 2021 14:15:13 +0200 From: Bengt Richter Message-ID: <20210903121513.GA5202@LionPure> References: <875yvi93w8.fsf@simonsouth.net> <877dfy7g8n.fsf@simonsouth.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <877dfy7g8n.fsf@simonsouth.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-Proofpoint-GUID: T6Dx3OmtrMO7W1T6K8NplqR3ef9Bx9oy X-Proofpoint-ORIG-GUID: T6Dx3OmtrMO7W1T6K8NplqR3ef9Bx9oy X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-09-03_03:2021-09-03, 2021-09-03 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 clxscore=1034 priorityscore=1501 suspectscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 impostorscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000 definitions=main-2109030076 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Bengt Richter Cc: 50346@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630671771; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=smwzKZe5dJ4F14HoC/YGqWP8jPrHqq3jwnSJlZnY1aU=; b=XvjdSI5UhUKJxaWgQoQj9cMIBsWiGTVjP3q0goiuyoWN+pYih6M6xJ/Fsbu9z2I5ucDYg0 TfQ8DzaquTmiP79uIOT2bVBTGj4kZX+GLonlDEs0cidKe/ZV+Jy3GpRQcYQ5Q6C5kioNJP vx09vZUxaQfD8sTmNAyO7y6wLyohMhgfTQNc6dL0Cc4IB8zHw0VMZxSj3EgNWk40MYibYM pzZ8xQZMiWJcoY6wrz3+VsYJXktA6hs0sjMvwdPol2g/fm8Aiv4grH/8BLZ/Nn3nbZvOwU sALMdgMhgj2mQTALgGnXHsxtsGJD6SpWT96TkqH+JWjyw4i14bqpqrf8mz9slw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630671771; a=rsa-sha256; cv=none; b=HHOoqIF+3cf7cYDjzlrV4c6sPafW08V58QfpaxJ8wqMeiyMQwJ6r05waRhABz2ilWicupl fxcEl0lIAg0Sc65VyKAAR7EDB4DpsRXjpMJHX1kGQkHZMgOTx/BifrAmwzCFS6QSIB4Wzv rD5yIcmuokQ8HaMvOzMB408AOqoKBs2DrNh7B7g6WV/w8RBJ6TgrUMdhs85udEAW9atRIL oewi2V2ce9A67OWCOE545urao4lf5rYjE/2N2rQzrsSvdrlDyxM+NFzDmEutUGrw7rSEsA 4393vGKW1o47dGqtqr3FYcanZVA6pilvdIYNOXs2SPnbIQlPYSFYC3Pckajo+w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -1.92 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 7EE881AFBA X-Spam-Score: -1.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: QCjxzu5Kp+To Hi, On +2021-09-02 18:41:12 -0400, Simon South wrote: > Patching strace to add a "--trace-path" parameter to the two tests' > definitions as in the patch below seems to fix this issue on both > AArch64 and x86-64, and is less drastic than disabling the tests > altogether. > > The changes limit strace's output during testing to only calls affecting > files in the test directory itself, effectively filtering out the > 'readlink("/proc/self/exe")' call from glibc that is throwing the tests > currently. You can see a number of other places in gen_tests.in where > this is done, presumably for similar reasons. > > Does this seem reasonable? > I worry about disabling tests in too general a way, since it creates a hiding place which conceivably someone really clever may be able exploit. So I wonder whether what you are doing is making it possible to configure tests to have (narrow) context-sensitive expectations (e.g., in this case making the test handle the error as an expected one, as opposed to being made ignorant of it), or building in a static and probably too general configuration. A proper configurability, ISTM, would be preferable to any other form of more general filtering. Sorry if this is just noise from a lurker with insufficient knowledge of the issue and discussions. If so please ignore ;/ of13> definitions as in the patch below seems to fix this issue on both > -- > Simon South > simon@simonsouth.net > > > diff --git a/tests/gen_tests.in b/tests/gen_tests.in > index 8b4e2e9..cc3ca63 100644 > --- a/tests/gen_tests.in > +++ b/tests/gen_tests.in > @@ -623,8 +623,8 @@ quotactl-xfs-v -v -e trace=quotactl > read-write -a15 -eread=0,5 -ewrite=1,4 -e trace=read,write -P read-write-tmpfile -P /dev/zero -P /dev/null > readahead -a1 > readdir -a16 > -readlink -xx > -readlinkat -xx > +readlink -xx --trace-path=test.readlink.link > +readlinkat -xx --trace-path=test.readlinkat.link > reboot -s 256 > recv-MSG_TRUNC -a26 -e trace=recv > recvfrom -a35 > > > -- Regards, Bengt Richter