From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MDmXJ75xHmEy/gAAgWs5BA (envelope-from ) for ; Thu, 19 Aug 2021 16:59:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id wOU7I75xHmFdbQAAbx9fmQ (envelope-from ) for ; Thu, 19 Aug 2021 14:59:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 210831751E for ; Thu, 19 Aug 2021 16:59:10 +0200 (CEST) Received: from localhost ([::1]:49900 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mGjVd-0001DZ-Bd for larch@yhetil.org; Thu, 19 Aug 2021 10:59:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34696) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGjVW-0001DO-2n for bug-guix@gnu.org; Thu, 19 Aug 2021 10:59:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49072) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mGjVV-0005on-Rh for bug-guix@gnu.org; Thu, 19 Aug 2021 10:59:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mGjVV-0002xA-PT for bug-guix@gnu.org; Thu, 19 Aug 2021 10:59:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#49827: Error message for missing synopsis in opam importer Resent-From: Alice BRENON Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 19 Aug 2021 14:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49827 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: zimoun Received: via spool by 49827-submit@debbugs.gnu.org id=B49827.162938509411297 (code B ref 49827); Thu, 19 Aug 2021 14:59:01 +0000 Received: (at 49827) by debbugs.gnu.org; 19 Aug 2021 14:58:14 +0000 Received: from localhost ([127.0.0.1]:60618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGjUk-0002w8-Ex for submit@debbugs.gnu.org; Thu, 19 Aug 2021 10:58:14 -0400 Received: from lxc-smtp2.ens-lyon.fr ([140.77.167.81]:55664) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGjUi-0002vz-U7 for 49827@debbugs.gnu.org; Thu, 19 Aug 2021 10:58:13 -0400 Received: from localhost (localhost [127.0.0.1]) by lxc-smtp2.ens-lyon.fr (Postfix) with ESMTP id 8E2D2E310D; Thu, 19 Aug 2021 16:58:11 +0200 (CEST) X-Virus-Scanned: by amavisd-new-2.11.0 (20160426) (Debian) at ens-lyon.fr Received: from lxc-smtp2.ens-lyon.fr ([127.0.0.1]) by localhost (lxc-smtp2.ens-lyon.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kLjaOhmIf7x8; Thu, 19 Aug 2021 16:58:11 +0200 (CEST) Received: from localhost (unknown [78.194.167.103]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) by lxc-smtp2.ens-lyon.fr (Postfix) with ESMTPSA id 4E2DCE3095; Thu, 19 Aug 2021 16:58:11 +0200 (CEST) Date: Thu, 19 Aug 2021 16:58:10 +0200 From: Alice BRENON Message-ID: <20210819165810.67094d1b@ens-lyon.fr> In-Reply-To: <868s10pldd.fsf@gmail.com> References: <20210802170115.696ac103@ens-lyon.fr> <86r1fb4pez.fsf@mgsn.dev> <20210811151520.61c85eaa@ens-lyon.fr> <868s10pldd.fsf@gmail.com> Organization: ENS de Lyon X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.24; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sarah Morgensen , 49827@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1629385150; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=KoZFr27cXfRYsJO75DTWFq6+yDt6XLDjjEiVEly8JcQ=; b=NJMB+A1kgNceadkMcUqQncVPiM2gNj3bPIitoPo3ed74q0EtTYjwxzQqRf6JxgoWXXjcK6 dhxIKWk9FgJJQ8x3MxPk4Nd8XWpmR1NEq19FkHnkMDQ8bAuOAAmo+3oZknj0Nr0P3fmDTV XjOkU6Y/0CAnhsVQxllQTDK/PKXrx7fb30x7zOkoYLY1DtOQLVC6MJ56UfEy/VrzjDlc4I w+fj3/dmhR74iaoIkjETmauvXqbvfUVO8RHKVXafEKLXFiV5njd0r3an/9TC647+3cvmkv n+ciDSCsfWvH0+1k5hCUjXtU4X+04HgBEQdxpn/i3THSD8QLq95eBchrS69oeg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1629385150; a=rsa-sha256; cv=none; b=MR0Jz7VRzSI6rnWXQvMLkOD3CXTXlmJ0Qn/YBolqeGD/jxhJH4yXqxjHXfnEkDteBK0rhv qb9Eui3DICqeWwpj8BVYkqD4cMm9N2gCgyXqErs26caYO4BNzovnqySI0fCYCH7446SF4L cFAT6C68QNQfJtCYMa7I5DI8iGBnRdEZPZrA+niqKTE2OZn4yiuji9cXRHN1dcsntsFCkp D6bb2IGUWPVMM9LDb+g4EhsnWP5tw/9IxOs5R2fPz5rNtDszZoKDc+MlFqoox6Oa7jY/dO Y6hCjdbHyAmjPfgLIIpwzaJy12eeb1N5QnGWHJk13am/CvdjYOeQ0h/XW9Od4w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -2.42 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 210831751E X-Spam-Score: -2.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: xLwwBDMvJrL2 Hello, Thanks for your answer ! Le Tue, 17 Aug 2021 09:43:10 +0200, zimoun a =C3=A9crit : > Hi, >=20 > I am back from holidays. :-) >=20 > =E2=80=A6 =20 >=20 > From my understanding, there is 2 issues: =20 >=20 > - gentle handler for error > - warn for incomplete metadata >=20 Yes, absolutely, because currently understanding the cause of the error requires to delve into the source to understand what is going on. The warning part is more optional, but if this pattern matching is modified to handle that special case of a missing metadata instead of entirely crashing, I thought it could be useful not to be too permissive either, and to at least mention that a missing metadata was caught and should be filled by hand. This could take the form of a message above the output of the actual scheme code for the package declaration while the importer is running, or of an invalid value for that missing field in the generated scheme output, something like "" or such that would be invalid in scheme and would make guix build fail when trying to use the output directly without manually editing it to fill the missing metadata. > With J=C3=A9r=C3=A9my (jeko), we have started to work time to time using > experimental pair-programming to fix the former. Currently, each > importer uses its own error mechanism and obviously incoherence > between them happens; especially when =E2=80=99--recursive=E2=80=99. We = are trying > to unify that. >=20 > Thanks for the report of this use case. :-) Glad to learn my report could help : ) >=20 >=20 > Cheers, > simon