bug#48595: `guix install mes` fails in 'check'-phase

bug#48595: `guix install mes` fails in 'check'-phase

[Gabriel Wicki]

i tried running `guix install mes` which fails on my x86_64 debian
machine. CI fails as well
(https://ci.guix.gnu.org/build/286577/details).

log output shows a couple of segmentation faults and an undefined
variable in phase 'check':

test/test10/hello.sh
+ '[' amd64 = amd64 ']'
+ ./test/results/test1-binary
+ . ./sha256.sh
++ set -ex
test/test1/hello.sh: line 37:   171 Segmentation fault      ./test/results/test1-binary < test/test1/hex0.hex0 > test/test1/proof1
+ '[' amd64 = x86 ']'
+ exit 0
make: *** [makefile:104: test1-binary] Error 139
[...]
test/test7/hello.sh: line 31:   175 Segmentation fault      ./test/results/test7-binary test/test7/hex1.hex1 > test/test7/proof
[...]
test/test3/hello.sh: line 23: GET_MACHINE_FLAGS: unbound variable

bug#48595: `guix install mes` fails in 'check'-phase

[Ludovic Courtès]

Hi,

(Cc: Janneke.)

Gabriel Wicki <gabriel@erlikon.ch> skribis:

> i tried running `guix install mes` which fails on my x86_64 debian
> machine. CI fails as well
> (https://ci.guix.gnu.org/build/286577/details).
>
> log output shows a couple of segmentation faults and an undefined
> variable in phase 'check':
>
> test/test10/hello.sh
> + '[' amd64 = amd64 ']'
> + ./test/results/test1-binary
> + . ./sha256.sh
> ++ set -ex
> test/test1/hello.sh: line 37:   171 Segmentation fault      ./test/results/test1-binary < test/test1/hex0.hex0 > test/test1/proof1
> + '[' amd64 = x86 ']'
> + exit 0
> make: *** [makefile:104: test1-binary] Error 139
> [...]
> test/test7/hello.sh: line 31:   175 Segmentation fault      ./test/results/test7-binary test/test7/hex1.hex1 > test/test7/proof
> [...]
> test/test3/hello.sh: line 23: GET_MACHINE_FLAGS: unbound variable

Could this be non-deterministic?

I just got substitutes from bayfront.guix.gnu.org:

--8<---------------cut here---------------start------------->8---
$ guix build mes 
1.4 MB will be downloaded:
   /gnu/store/2x63a7415vfz605pw33awfccrn0z74dg-mes-0.23
substituting /gnu/store/2x63a7415vfz605pw33awfccrn0z74dg-mes-0.23...
downloading from https://bayfront.guix.gnu.org/nar/lzip/2x63a7415vfz605pw33awfccrn0z74dg-mes-0.23 ...
 mes-0.23  1.3MiB                                       3.4MiB/s 00:00 [##################] 100.0%

/gnu/store/2x63a7415vfz605pw33awfccrn0z74dg-mes-0.23
$ guix build mes -d --no-grafts
/gnu/store/nb6vmrz197bfpz4w5mdrmj0r10mszzig-mes-0.23.drv
ludo@ribbon ~/src/guix$ guix describe
Generacio 185   Jun 07 2021 15:07:46    (nuna)
  guix e3611cc
    repository URL: https://git.savannah.gnu.org/git/guix.git
    branch: master
    commit: e3611cc412e7b1c750a56d17fb1b7cde684baa3f
--8<---------------cut here---------------end--------------->8---

I rebuilt it with ‘--check’ and it went fine.  Hmm!

Thoughts?

Ludo’.

bug#48595: `guix install mes` fails in 'check'-phase

[Gabriel Wicki]

(This is a reply to the original bug report [0]; cross-posting to
bug-mes@gnu.org for reasons described below. I hope this is ok)

On Sun, Jun 13, 2021 at 02:52:41PM +0200, Ludovic Courtès wrote:
> Hi,
Hello!

I guess i need to clarify: it's not mes building that fails; it's
mescc-tools (version 0.7.0 on x86_64) (which mes depends upon).
Sorry for the confusion.

> Could this be non-deterministic?
I have the same problem in guix on my Debian host and in my qemu Guix
System. And since the error is the same as in the build on
ci.guix.gnu.org [1] i'm under the impression that it might be (at least
somewhat) deterministic ;)
I should be able to test this in my (real) Guix System host tomorrow.


> Thoughts?
Digging through the CI logs a bit i found mescc-tools-0.7.0 failing
to build for x86_64[2]. Also there is this build (mes-0.23 for x86_64)
failing with the same errors [3], but during `check' phase for
dependency nyacc-1.00.2 (this is not the current version; also: i'm
not sure if this really is related, but the log outputs are strikingly
similar).

My debugging[5] didn't reveal anything further than what's already in
the logs. So i'm CC-ing bug-mes mailing list, since that's probably
the most adequate place to discuss this issue :)

g



[0] https://issues.guix.gnu.org/48595
[1] https://ci.guix.gnu.org/build/286577/details
[2] https://ci.guix.gnu.org/build/82814/details
[3] https://ci.guix.gnu.org/build/82812/details
[4] mescc-tools/test/test1/hello.sh:26
[5] ./test/results/test1-binary --> segfault

bug#48595: `guix install mes` fails in 'check'-phase

[Ekaitz Zarraga]

[-- Attachment #1.1: Type: text/plain, Size: 1728 bytes --]

Hi,

I found the same issue while trying to set the environment for gnu-mes using the scripts the directory includes.

I updated the mescc-tools version to 1.1.0 and it worked.

I attach a possible patch for the `mes` repository that can easily be translated for the `guix` package.

hth,

Ekaitz


From 828ba527e652de9166eddf24a9296b5aa2db3f79 Mon Sep 17 00:00:00 2001
From: Ekaitz Zarraga <ekaitz@elenq.tech>
Date: Tue, 27 Jul 2021 10:00:30 +0200
Subject: [PATCH] Update guix helper files

Bump mescc-tools to 1.1.0
---
 guix/git/mes.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/guix/git/mes.scm b/guix/git/mes.scm
index 0c7c5566..21b8591a 100644
--- a/guix/git/mes.scm
+++ b/guix/git/mes.scm
@@ -54,7 +54,7 @@
 (define-public mescc-tools
   (package
     (name "mescc-tools")
-    (version "0.7.0")
+    (version "1.1.0")
     (source
      (origin
        (method url-fetch)
@@ -65,7 +65,7 @@
        (file-name (string-append name "-" version ".tar.gz"))
        (sha256
         (base32
-         "1p1ijia4rm3002f5sypidl9v5gq0mlch9b0n61rpxkdsaaxjqax3"))))
+         "12cjryqfd6m6j807pvhk7i4vr2q0jiibpfrpnq5s67iq9l4rrc6b"))))
     (build-system gnu-build-system)
     (supported-systems
      '("aarch64-linux" "armhf-linux" "i686-linux" "x86_64-linux"))
@@ -80,6 +80,7 @@
                       (substitute* "sha256.sh"
                         (("/usr/bin/sha256sum") (which "sha256sum")))
                       #t)))))
+    (propagated-inputs `(("which" ,which)))
     (synopsis "Tools for the full source bootstrapping process")
     (description
      "Mescc-tools is a collection of tools for use in a full source
-- 

2.31.0


[-- Attachment #1.2: publickey - ekaitz@elenq.tech - 0xEA84F52E.asc --]
[-- Type: application/pgp-keys, Size: 1807 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 509 bytes --]

bug#48595: `guix install mes` fails in 'check'-phase

[Ekaitz Zarraga]

BTW,

>     #t)))))
> -   (propagated-inputs `(("which" ,which)))
>

It's wrong. It should be `inputs` but you get what I mean.
:S

bug#48595: `guix install mes` fails in 'check'-phase

[Ludovic Courtès]

Hi!

Ekaitz Zarraga <ekaitz@elenq.tech> skribis:       

> I found the same issue while trying to set the environment for gnu-mes using the scripts the directory includes.
>
> I updated the mescc-tools version to 1.1.0 and it worked.
>
> I attach a possible patch for the `mes` repository that can easily be translated for the `guix` package.

I pushed this update on ‘core-updates’ as part of fixing
<https://issues.guix.gnu.org/49515>, which seems to be a duplicate of
this issue.

Is this needed on ‘master’ as well?  If so, I can cherry-pick those
changes.

Thanks!

Ludo’.