From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CEazITPsR2BqRAAA0tVLHw (envelope-from ) for ; Tue, 09 Mar 2021 21:44:19 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id SMh8HTPsR2D2OwAAB5/wlQ (envelope-from ) for ; Tue, 09 Mar 2021 21:44:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8909A1D1FC for ; Tue, 9 Mar 2021 22:44:18 +0100 (CET) Received: from localhost ([::1]:54540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJk9J-0005aM-MJ for larch@yhetil.org; Tue, 09 Mar 2021 16:44:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37266) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJk86-0004tu-V5 for bug-guix@gnu.org; Tue, 09 Mar 2021 16:43:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:36606) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJk86-0000kX-NT for bug-guix@gnu.org; Tue, 09 Mar 2021 16:43:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lJk86-0000EK-LK for bug-guix@gnu.org; Tue, 09 Mar 2021 16:43:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#47028: [PATCH 2/2] lint: Warn about single-character package names. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 09 Mar 2021 21:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47028 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 47028@debbugs.gnu.org Received: via spool by 47028-submit@debbugs.gnu.org id=B47028.1615326136820 (code B ref 47028); Tue, 09 Mar 2021 21:43:02 +0000 Received: (at 47028) by debbugs.gnu.org; 9 Mar 2021 21:42:16 +0000 Received: from localhost ([127.0.0.1]:48151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJk7L-0000DA-Qy for submit@debbugs.gnu.org; Tue, 09 Mar 2021 16:42:16 -0500 Received: from tobias.gr ([80.241.217.52]:46524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJk7H-0000Cj-5o for 47028@debbugs.gnu.org; Tue, 09 Mar 2021 16:42:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobias.gr; s=2018; bh=4CAUGUHgmp85V7uNBSG9S5XHVgEv0q84Qzptv8yVfFk=; h=references: in-reply-to:date:subject:to:from; b=BvxfRsKDHwxaV9ciejwSmlBSzi10F0cids iTShUhRIuYxOSIq3/W8D0lF1NqsCNc7hnVfZ5f9mN2L4wUOKqeg+VKFYmLqTWpy7GUPtYt e0d8O3qaGOfaA1jwqvRSdk0RTZPjqnTG/VUXjJjTOENZ6o0SllajyKXMzP2J+sD0AX94QG lNddUIPyZZyUruyHZt8D/ymAZVCfIWy4PPHTEoFHOb4xYzw183LDmAZyFxdBaVJ6KILWw2 NX2D0YKaiAcRX/6O6pIi/nD5u7S0SNLsEHCmw2HuIJmPvtdOXIgZXniAibmhbtPO8ffz3V RgF29nsIao/OwgZtH1h8UTfp63LQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 1aa0e30d (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO) for <47028@debbugs.gnu.org>; Tue, 9 Mar 2021 21:43:06 +0000 (UTC) Date: Tue, 9 Mar 2021 22:41:58 +0100 Message-Id: <20210309214158.31754-2-me@tobias.gr> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210309214158.31754-1-me@tobias.gr> References: <87eegom2gk.fsf@nckx> <20210309214158.31754-1-me@tobias.gr> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" Reply-to: Tobias Geerinckx-Rice From: Tobias Geerinckx-Rice via Bug reports for GNU Guix X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1615326258; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=4CAUGUHgmp85V7uNBSG9S5XHVgEv0q84Qzptv8yVfFk=; b=QfH6Cti9Esxu7SDQ6dQlyxcRVJDrv9g6cv8hJld+zq9j5Ex7aF2Zaam5ojTLG/2ZldKTL/ KclGK7NqTYMDA8/mzIBlcHizbcmw+gOZhxVKsd7AkoqjfcGi9oy3rJb0rVa7tm5dUKJk8P yaV4bHmNzdRAqRyRko1d43bGH7YZCI+4gjEJ9H5b2Gu+RCq2AXrg0JhhQKZ5zNqtWJiWEl TdB7bZTcGlj55H0G+D/dbnuiT9bzj98tdcjMIeUuRcbkqADtKEeim6xYeitAKEQV0XdDx/ TLyaj0Mv9wlqUTchJqCIXfdnDeVAdhgl3gHAhZFNNq8NvBLoLTY3RKA4+Kgwvw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1615326258; a=rsa-sha256; cv=none; b=cfhAR83c5szBpZbq0KNSt+tFqDWdng4O6Psi/Wh0pVd7BmaTpUQCS2OuwVxR4LFNMqPxOz rYfOfBLM3ok1ek6Oq+A7ILEr0Edd69TvaTo4XeKSqUlSe6KRcuwefcFykcK4tSfYoeSYxn AI9hbhC5Ze6UXUsbOb3lRF9XZ+ZbU9xenFNUc33qwVqRmxvO9x1rfYLeIx+LKyHGQxtYru 7aKsKTLVUNNNyrn0zqp2mETouQjL6v1qpj06rGisgjcQdCyAZRDWmzqu0cCmgGZXcb86yc 9Ycvi2kjUdXKphOWbYyGf3BQ3yeADR7GZ/Yz+xLTVLOfc5CU5sKTa0LSasBoTQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=BvxfRsKD; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -2.88 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=BvxfRsKD; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 8909A1D1FC X-Spam-Score: -2.88 X-Migadu-Scanner: scn1.migadu.com X-TUID: Yvj2JjLhPYTj * guix/lint.scm (check-name): New procedure. (%local-checkers): Add it. --- guix/lint.scm | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/guix/lint.scm b/guix/lint.scm index 311bc94cc3..5144fa139d 100644 --- a/guix/lint.scm +++ b/guix/lint.scm @@ -6,7 +6,7 @@ ;;; Copyright © 2016 Danny Milosavljevic ;;; Copyright © 2016 Hartmut Goebel ;;; Copyright © 2017 Alex Kost -;;; Copyright © 2017 Tobias Geerinckx-Rice +;;; Copyright © 2017, 2021 Tobias Geerinckx-Rice ;;; Copyright © 2017, 2018, 2020 Efraim Flashner ;;; Copyright © 2018, 2019 Arun Isaac ;;; Copyright © 2020 Chris Marusich @@ -170,6 +170,16 @@ (requires-store? lint-checker-requires-store? (default #f))) +(define (check-name package) + "Check whether PACKAGE's name matches our guidelines." + ;; Currently checks only whether the name is too short. + (if (<= (string-length (package-name package)) 1) + (list + (make-warning package + (G_ "name should be longer than a single character") + #:field 'name)) + '())) + (define (properly-starts-sentence? s) (string-match "^[(\"'`[:upper:][:digit:]]" s)) @@ -1445,6 +1455,10 @@ them for PACKAGE." (define %local-checkers (list + (lint-checker + (name 'name) + (description "Validate package names") + (check check-name)) (lint-checker (name 'description) (description "Validate package descriptions") -- 2.30.1