From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id JRttJ68L8F//HQAA0tVLHw (envelope-from ) for ; Sat, 02 Jan 2021 05:59:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id qL7aIq8L8F9xZAAA1q6Kng (envelope-from ) for ; Sat, 02 Jan 2021 05:59:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 558F9940148 for ; Sat, 2 Jan 2021 05:59:10 +0000 (UTC) Received: from localhost ([::1]:53520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kvZwS-0003zS-Op for larch@yhetil.org; Sat, 02 Jan 2021 00:59:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33658) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kvZwM-0003z8-81 for bug-guix@gnu.org; Sat, 02 Jan 2021 00:59:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:55582) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kvZwL-000308-Vy for bug-guix@gnu.org; Sat, 02 Jan 2021 00:59:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kvZwL-0000zn-TI for bug-guix@gnu.org; Sat, 02 Jan 2021 00:59:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#45570: [PATCH] system: Assert, that user and group names are unique. References: In-Reply-To: Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 02 Jan 2021 05:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45570 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 45570@debbugs.gnu.org Received: via spool by 45570-submit@debbugs.gnu.org id=B45570.16095670973772 (code B ref 45570); Sat, 02 Jan 2021 05:59:01 +0000 Received: (at 45570) by debbugs.gnu.org; 2 Jan 2021 05:58:17 +0000 Received: from localhost ([127.0.0.1]:38895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvZvc-0000ym-Un for submit@debbugs.gnu.org; Sat, 02 Jan 2021 00:58:17 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:55384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvZvZ-0000yc-Vq for 45570@debbugs.gnu.org; Sat, 02 Jan 2021 00:58:15 -0500 Received: from localhost.localdomain (217-149-174-13.nat.highway.telekom.at [217.149.174.13]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4D7B5G1wswz3wYT; Sat, 2 Jan 2021 06:58:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1609567090; bh=qHngEiAILzlDjqsIcVken0ZTK4ydmKtUyjebdQBf9fU=; h=From:To:Cc:Subject:Date; b=JWWyUUHv3d71mj47/ydYPD5S2oBwFcU3tSfjnh8kTdEckPkZTr+7R6nKvKObsRQ8f lXbhkhgmkTOVwXLKWcShBDZmpie/jjU08eUvmMAWUvVPSXoho7KopGKJLojJ9o3xhb UtjiToKd/lN6sjVgUUucl4ciT1RbiGfJKbzINC8o= From: Leo Prikler Date: Sat, 2 Jan 2021 06:57:29 +0100 Message-Id: <20210102055728.22594-1-leo.prikler@student.tugraz.at> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: conjaroy@gmail.com Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 3.77 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=tugraz.at header.s=mailrelay header.b=JWWyUUHv; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 558F9940148 X-Spam-Score: 3.77 X-Migadu-Scanner: scn1.migadu.com X-TUID: B4PeNWAOWjB2 *gnu/system/shadow.scm (find-duplicates): New variable. (assert-unique-account-names, assert-unique-group-names): New variables. (account-activation): Use them here. --- gnu/system/shadow.scm | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/gnu/system/shadow.scm b/gnu/system/shadow.scm index a69339bc07..3a5ea4dc70 100644 --- a/gnu/system/shadow.scm +++ b/gnu/system/shadow.scm @@ -34,6 +34,7 @@ #:use-module ((gnu packages admin) #:select (shadow)) #:use-module (gnu packages bash) + #:use-module (ice-9 match) #:use-module (srfi srfi-1) #:use-module (srfi srfi-26) #:use-module (srfi srfi-34) @@ -222,6 +223,38 @@ for a colorful Guile experience.\\n\\n\"))))\n")) (rename-file ".nanorc" ".config/nano/nanorc")) #t)))) +(define (find-duplicates list =) + (match list + ('() '()) + ((first . rest) + (if (member first rest =) ; (srfi srfi-1) member + (cons first (find-duplicates rest =)) + (find-duplicates rest =))))) + +(define (assert-unique-account-names users) + (for-each + (lambda (account) + (raise (condition + (&message + (message + (format #f (G_ "account with name '~a' found twice.") + (user-account-name account))))))) + (find-duplicates users (lambda (alice bob) + (string=? (user-account-name alice) + (user-account-name bob)))))) + +(define (assert-unique-group-names groups) + (for-each + (lambda (group) + (raise (condition + (&message + (message + (format #f (G_ "group with name '~a' found twice.") + (user-group-name group))))))) + (find-duplicates groups (lambda (red blue) + (string=? (user-group-name red) + (user-group-name blue)))))) + (define (assert-valid-users/groups users groups) "Raise an error if USERS refer to groups not listed in GROUPS." (let ((groups (list->set (map user-group-name groups)))) @@ -292,6 +325,8 @@ group." (define group-specs (map user-group->gexp groups)) + (assert-unique-account-names accounts) + (assert-unique-group-names groups) (assert-valid-users/groups accounts groups) ;; Add users and user groups. -- 2.29.2