From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id ILQ0M5fJ719uNgAA0tVLHw (envelope-from ) for ; Sat, 02 Jan 2021 01:17:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id sCn3LpfJ718qFgAA1q6Kng (envelope-from ) for ; Sat, 02 Jan 2021 01:17:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 00034940148 for ; Sat, 2 Jan 2021 01:17:10 +0000 (UTC) Received: from localhost ([::1]:40418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kvVXZ-0004F0-JG for larch@yhetil.org; Fri, 01 Jan 2021 20:17:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58924) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kvVXS-0004Es-7N for bug-guix@gnu.org; Fri, 01 Jan 2021 20:17:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51760) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kvVXS-0002pT-0J for bug-guix@gnu.org; Fri, 01 Jan 2021 20:17:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kvVXR-0007D9-Qt for bug-guix@gnu.org; Fri, 01 Jan 2021 20:17:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#45570: [PATCH] system: Assert, that user and group names are unique. Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 02 Jan 2021 01:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45570 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Leo Prikler Received: via spool by 45570-submit@debbugs.gnu.org id=B45570.160955017127658 (code B ref 45570); Sat, 02 Jan 2021 01:17:01 +0000 Received: (at 45570) by debbugs.gnu.org; 2 Jan 2021 01:16:11 +0000 Received: from localhost ([127.0.0.1]:35073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvVWd-0007C2-9u for submit@debbugs.gnu.org; Fri, 01 Jan 2021 20:16:11 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:32802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvVWZ-0007Bp-64 for 45570@debbugs.gnu.org; Fri, 01 Jan 2021 20:16:09 -0500 Received: from localhost (80-110-127-104.cgn.dynamic.surfer.at [80.110.127.104]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 897A23361792; Sat, 2 Jan 2021 02:16:04 +0100 (CET) Date: Sat, 2 Jan 2021 02:16:01 +0100 From: Danny Milosavljevic Message-ID: <20210102021601.74c2205a@scratchpost.org> In-Reply-To: <20210101111309.7701-1-leo.prikler@student.tugraz.at> References: <20210101111309.7701-1-leo.prikler@student.tugraz.at> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/21LS2xbdBxkYFvtqhB//Y+J"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45570@debbugs.gnu.org, conjaroy@gmail.com Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.43 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 00034940148 X-Spam-Score: -2.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: E3PBkQvtaLlC --Sig_/21LS2xbdBxkYFvtqhB//Y+J Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Leo, I agree that this is a good idea. Please use (ice-9 match) instead of car and cdr. Something among these lines would be more transparent: (define (find-duplicates list accessor) (match list (() '()) ((head . tail) (if (member head tail accessor) ; (srfi srfi-1) member (cons head (find-duplicates tail accessor)) (find-duplicates tail accessor))))) (find-duplicates users (lambda (a b) (string=3D? (user-account-name a) (user-account-name b))) (I think one could also use srfi-1 delete-duplicates and then compare the lengths. Then the entire thing is a one-liner--the only complication is to find the duplicates again after doing it (for the error message)) --Sig_/21LS2xbdBxkYFvtqhB//Y+J Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl/vyVEACgkQ5xo1VCww uqWekAgAp5r/QdsNKZ96v1UhGjbotHLNOS0BfMsvDZafTK/h8FToyel/E7wOrKca 0NjR+C01HkhhYYGl5/WoLLpR103fSo/NXtH0TykyBe7D4WwUn46gE2x7D59G2qmW f7ztIrkZke/JWEjQrSzsJwEY5uYT6D7b9dtYeUj7zBPU0Z+J+6+2nQYjZNLPrkDG 7GCZS8aJwmVBza6YKq/dmCM/nql8yV4kBpSXXEffhV4KEQAWdb51aS14wBIlEfj7 0y3Z64c0Xlgfd/6N5YSHlirn9gpNcRkO7jYiPwryweUK6LQRcWoeMXqM4oGJbTlU V0gqbnNxQqWwQIASBIUN/FXW7vpIoQ== =yiKX -----END PGP SIGNATURE----- --Sig_/21LS2xbdBxkYFvtqhB//Y+J--