From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 0gWkJkoE71/lPAAA0tVLHw (envelope-from ) for ; Fri, 01 Jan 2021 11:15:22 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 6GvzIUoE71+9cQAAB5/wlQ (envelope-from ) for ; Fri, 01 Jan 2021 11:15:22 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B9E519404D9 for ; Fri, 1 Jan 2021 11:15:21 +0000 (UTC) Received: from localhost ([::1]:37032 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kvIOu-00089q-JY for larch@yhetil.org; Fri, 01 Jan 2021 06:15:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46940) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kvIOc-00088w-JW for bug-guix@gnu.org; Fri, 01 Jan 2021 06:15:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:43962) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kvIOc-0002bz-CC for bug-guix@gnu.org; Fri, 01 Jan 2021 06:15:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kvIOc-0006hO-7l for bug-guix@gnu.org; Fri, 01 Jan 2021 06:15:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#45570: [PATCH] system: Assert, that user and group names are unique. References: In-Reply-To: Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 01 Jan 2021 11:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45570 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 45570@debbugs.gnu.org Received: via spool by 45570-submit@debbugs.gnu.org id=B45570.160949968125708 (code B ref 45570); Fri, 01 Jan 2021 11:15:02 +0000 Received: (at 45570) by debbugs.gnu.org; 1 Jan 2021 11:14:41 +0000 Received: from localhost ([127.0.0.1]:55508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvIOG-0006gZ-SB for submit@debbugs.gnu.org; Fri, 01 Jan 2021 06:14:41 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:38618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvIOE-0006gQ-HY for 45570@debbugs.gnu.org; Fri, 01 Jan 2021 06:14:39 -0500 Received: from localhost.localdomain (217-149-174-13.nat.highway.telekom.at [217.149.174.13]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4D6j8r1frVz1LLyW; Fri, 1 Jan 2021 12:14:35 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4D6j8r1frVz1LLyW DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1609499676; bh=MlpwKQEw7KPCPFqcfOr3JEh9A6sNPniuqaxyX3NNX98=; h=From:To:Cc:Subject:Date:From; b=mur3SKGyD9b2w6/CcG3WO600u4XQ0MQejJMtLghKeaeRGZUg3HA+yklQdzjz1tptP x++gyoK6iRY+6wRPi0fjbBtSGuZVEblZ9137WVp5jAsWecfU3RANRVlQAmn9mNWjsh P5YlPEmk51Fknn65ZaDX2XfN5Jv9AakgT87trSHs= From: Leo Prikler Date: Fri, 1 Jan 2021 12:13:10 +0100 Message-Id: <20210101111309.7701-1-leo.prikler@student.tugraz.at> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: conjaroy@gmail.com Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 3.77 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=tugraz.at header.s=mailrelay header.b=mur3SKGy; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: B9E519404D9 X-Spam-Score: 3.77 X-Migadu-Scanner: scn1.migadu.com X-TUID: VcidBS5HPYdd *gnu/system/shadow.scm (assert-unique-account-names) (assert-unique-group-names): New variables. (account-activation): Use them here. --- gnu/system/shadow.scm | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/gnu/system/shadow.scm b/gnu/system/shadow.scm index a69339bc07..61562f225e 100644 --- a/gnu/system/shadow.scm +++ b/gnu/system/shadow.scm @@ -222,6 +222,32 @@ for a colorful Guile experience.\\n\\n\"))))\n")) (rename-file ".nanorc" ".config/nano/nanorc")) #t)))) +(define (assert-unique-account-names users) + (let loop ((names '()) + (users users)) + (unless (null? users) + (let ((name (user-account-name (car users)))) + (if (member name names) + (raise (condition + (&message + (message + (format #f (G_ "account with name '~a' found twice") + name))))) + (loop (cons name names) (cdr users))))))) + +(define (assert-unique-group-names groups) + (let loop ((names '()) + (groups groups)) + (unless (null? groups) + (let ((name (user-account-name (car groups)))) + (if (member name names) + (raise (condition + (&message + (message + (format #f (G_ "group with name '~a' found twice") + name))))) + (loop (cons name names) (cdr groups))))))) + (define (assert-valid-users/groups users groups) "Raise an error if USERS refer to groups not listed in GROUPS." (let ((groups (list->set (map user-group-name groups)))) @@ -292,6 +318,8 @@ group." (define group-specs (map user-group->gexp groups)) + (assert-unique-account-names accounts) + (assert-unique-group-names groups) (assert-valid-users/groups accounts groups) ;; Add users and user groups. -- 2.29.2