unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: 44760@debbugs.gnu.org
Subject: bug#44760: [PATCH 00/15] Speed up 'guix system init' & co.
Date: Fri, 11 Dec 2020 16:09:10 +0100	[thread overview]
Message-ID: <20201211150919.18435-1-ludo@gnu.org> (raw)
In-Reply-To: <87h7pkffzy.fsf@inria.fr>

Hi there!

Here’s a long and rather boring patch series to address
<https://issues.guix.gnu.org/44760> and a bit more.

To avoid traversing store items repeatedly as described in the
issue above, the strategy here is to gradually move the
reset-timestamps and deduplicate phases as part of the file
copying process, such that each file is accessed only once.
Consequently, the kitchen sink that ‘register-items’ once was
is now very focused.

Furthermore, it changes ‘guix system init’ so that it reuses
the already-known store item hashes when populating the target
database instead of re-traversing store items.

On my laptop (SSD, warm cache, derivations already built), the
command:

  guix system init gnu/system/examples/bare-bones.tmpl /tmp/sys

goes from 32s to 22s, a 33% improvement.

Feedback welcome!

Ludo’.

Ludovic Courtès (15):
  serialization: 'fold-archive' notifies about directory processing
    completion.
  serialization: 'restore-file' sets canonical timestamp and
    permissions.
  nar: Deduplicate files right as they are restored.
  store-copy: 'populate-store' resets timestamps.
  image: 'register-closure' assumes already-reset timestamps.
  database: Remove #:reset-timestamps? from 'register-items'.
  store-copy: 'populate-store' can optionally deduplicate files.
  image: 'register-closure' leaves it up to the caller to deduplicate.
  database: Remove #:deduplicate? from 'register-items'.
  guix system: 'init' copies, resets timestamps, and deduplicates at
    once.
  database: Remove #:deduplicate? and #:reset-timestamps? from
    'register-path'.
  system: 'init' does not recompute the hash of each store item.
  database: Remove 'register-path'.
  database: Honor 'SOURCE_DATE_EPOCH'.
  deduplicate: Create the '.links' directory lazily.

 .dir-locals.el                |   1 +
 gnu/build/image.scm           |  16 +-
 gnu/build/install.scm         |   3 +-
 gnu/build/linux-initrd.scm    |   3 +-
 gnu/build/vm.scm              |  14 +-
 gnu/system/install.scm        |  12 +-
 gnu/system/linux-initrd.scm   |  10 +-
 guix/build/store-copy.scm     | 133 ++++++++++++----
 guix/nar.scm                  |   8 +-
 guix/scripts/archive.scm      |   2 +
 guix/scripts/challenge.scm    |   1 +
 guix/scripts/pack.scm         | 276 +++++++++++++++++-----------------
 guix/scripts/system.scm       |  64 ++++----
 guix/serialization.scm        |  36 +++--
 guix/store/database.scm       |  58 ++-----
 guix/store/deduplication.scm  | 167 ++++++++++++++------
 tests/gexp.scm                |  20 ++-
 tests/guix-archive.sh         |   4 +-
 tests/nar.scm                 |  21 ++-
 tests/store-database.scm      |  18 ++-
 tests/store-deduplication.scm |  20 ++-
 21 files changed, 544 insertions(+), 343 deletions(-)

-- 
2.29.2





  parent reply	other threads:[~2020-12-11 15:12 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-20 11:02 bug#44760: Closure copy in ‘guix system init’ is inefficient Ludovic Courtès
2020-11-22 19:46 ` raingloom
2020-11-22 21:10   ` Ludovic Courtès
2020-12-11 15:09 ` Ludovic Courtès [this message]
2020-12-11 15:09   ` bug#44760: [PATCH 01/15] serialization: 'fold-archive' notifies about directory processing completion Ludovic Courtès
2020-12-11 15:09   ` bug#44760: [PATCH 02/15] serialization: 'restore-file' sets canonical timestamp and permissions Ludovic Courtès
2020-12-11 15:09   ` bug#44760: [PATCH 03/15] nar: Deduplicate files right as they are restored Ludovic Courtès
2020-12-11 15:09   ` bug#44760: [PATCH 04/15] store-copy: 'populate-store' resets timestamps Ludovic Courtès
2020-12-11 15:09   ` bug#44760: [PATCH 05/15] image: 'register-closure' assumes already-reset timestamps Ludovic Courtès
2020-12-11 15:09   ` bug#44760: [PATCH 06/15] database: Remove #:reset-timestamps? from 'register-items' Ludovic Courtès
2020-12-11 15:09   ` bug#44760: [PATCH 07/15] store-copy: 'populate-store' can optionally deduplicate files Ludovic Courtès
2020-12-11 15:09   ` bug#44760: [PATCH 08/15] image: 'register-closure' leaves it up to the caller to deduplicate Ludovic Courtès
2020-12-11 15:09   ` bug#44760: [PATCH 09/15] database: Remove #:deduplicate? from 'register-items' Ludovic Courtès
2020-12-15 16:33   ` bug#44760: [PATCH 00/15] Speed up 'guix system init' & co Ludovic Courtès
2020-12-11 15:09 ` bug#44760: [PATCH 10/15] guix system: 'init' copies, resets timestamps, and deduplicates at once Ludovic Courtès
2020-12-11 15:09   ` bug#44760: [PATCH 11/15] database: Remove #:deduplicate? and #:reset-timestamps? from 'register-path' Ludovic Courtès
2020-12-11 15:09   ` bug#44760: [PATCH 12/15] system: 'init' does not recompute the hash of each store item Ludovic Courtès
2020-12-11 15:09   ` bug#44760: [PATCH 13/15] database: Remove 'register-path' Ludovic Courtès
2020-12-11 15:09   ` bug#44760: [PATCH 14/15] database: Honor 'SOURCE_DATE_EPOCH' Ludovic Courtès
2020-12-11 15:09   ` bug#44760: [PATCH 15/15] deduplicate: Create the '.links' directory lazily Ludovic Courtès
2020-12-15 16:38 ` bug#44760: Closure copy in ‘guix system init’ is inefficient Ludovic Courtès
2020-12-16 21:53 ` Jonathan Brielmaier
2020-12-17 13:24   ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201211150919.18435-1-ludo@gnu.org \
    --to=ludo@gnu.org \
    --cc=44760@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).