From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id sC2GHrVGsV8TLAAA0tVLHw (envelope-from ) for ; Sun, 15 Nov 2020 15:18:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id oN2PGrVGsV+pSwAA1q6Kng (envelope-from ) for ; Sun, 15 Nov 2020 15:18:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 38E0B9403CA for ; Sun, 15 Nov 2020 15:18:12 +0000 (UTC) Received: from localhost ([::1]:59894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keJn9-0008Ao-0i for larch@yhetil.org; Sun, 15 Nov 2020 10:18:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35386) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keJn0-0008AW-95 for bug-guix@gnu.org; Sun, 15 Nov 2020 10:18:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:42421) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1keJn0-0007Xj-0C for bug-guix@gnu.org; Sun, 15 Nov 2020 10:18:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1keJmz-0005Rz-SW for bug-guix@gnu.org; Sun, 15 Nov 2020 10:18:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#44650: Do not suggest `guix pull --news' after first pull Resent-From: "pelzflorian (Florian Pelz)" Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 15 Nov 2020 15:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44650 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 44650@debbugs.gnu.org Received: via spool by 44650-submit@debbugs.gnu.org id=B44650.160545345220912 (code B ref 44650); Sun, 15 Nov 2020 15:18:01 +0000 Received: (at 44650) by debbugs.gnu.org; 15 Nov 2020 15:17:32 +0000 Received: from localhost ([127.0.0.1]:53967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keJmW-0005RD-83 for submit@debbugs.gnu.org; Sun, 15 Nov 2020 10:17:32 -0500 Received: from pelzflorian.de ([5.45.111.108]:53756 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keJmT-0005R4-6f for 44650@debbugs.gnu.org; Sun, 15 Nov 2020 10:17:30 -0500 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id AA8BD3605A8 for <44650@debbugs.gnu.org>; Sun, 15 Nov 2020 16:17:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1605453447; bh=Yct3RlHFz1ONcoBSyqi+ZCBRp3hP06ko8wGwfAHm0+4=; h=Date:From:To:Subject:References:In-Reply-To; b=XJpS7vTbPV3swVSgLTkjvoQWt02oQcXdjA14svg2AvfuNlHvOjIk7/hsOo4+N4IX1 dkFo7ZoAJL2/n1AqLCq/mDhyVWeoG92t1VWZG6lxdeSJGB1UcBzOk4/jVzRaUcOaNP mRtcJ0y5gMbp7MvM6VQv8Pj9gLKQm4XfJlntNPzE= Date: Sun, 15 Nov 2020 16:17:17 +0100 From: "pelzflorian (Florian Pelz)" Message-ID: <20201115151717.myo6hcb5prambmho@pelzflorian.localdomain> References: <20201115015630.aknnrsoggtsabmfo@pelzflorian.localdomain> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="bymt4oj3t7xtjdgx" Content-Disposition: inline In-Reply-To: <20201115015630.aknnrsoggtsabmfo@pelzflorian.localdomain> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=pelzflorian.de header.s=mail header.b=XJpS7vTb; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: 0.99 X-TUID: pPNuSDgrsah/ --bymt4oj3t7xtjdgx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Nov 15, 2020 at 02:56:30AM +0100, pelzflorian (Florian Pelz) wrote: > - (when previous > + (if previous > (let ((old-channels (profile-channels previous)) > (new-channels (profile-channels profile))) > ;; Find the channels present in both PROFILE and PREVIOUS, and print > @@ -405,7 +405,8 @@ previous generation. Return true if there are news to display." > #:concise? #t))) > channels)) > > - (any ->bool more?)))))) > + (any ->bool more?)))) > + #f)) I changed the patch to use `and` instead of `if` (attached). I confirmed that channel news display fine on a later `guix pull`. Should I add a copyright line? I believe no. Regards, Florian --bymt4oj3t7xtjdgx Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-pull-Do-not-suggest-running-guix-pull-news-on-the-fi.patch" >From 8b1557004f618a47d4bea3a65a5b88c4cb718c4c Mon Sep 17 00:00:00 2001 From: Florian Pelz Date: Sat, 14 Nov 2020 23:36:52 +0100 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [PATCH] pull: Do not suggest running `guix pull --news' on the first run. * guix/scripts/pull.scm (display-channel-news-headlines): If there are no news to display, return false instead of . --- guix/scripts/pull.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/scripts/pull.scm b/guix/scripts/pull.scm index bb1b560a22..7fd8b3f1a4 100644 --- a/guix/scripts/pull.scm +++ b/guix/scripts/pull.scm @@ -385,7 +385,7 @@ previous generation. Return true if there are news to display." (and=> (relative-generation profile -1) (cut generation-file-name profile <>))) - (when previous + (and previous (let ((old-channels (profile-channels previous)) (new-channels (profile-channels profile))) ;; Find the channels present in both PROFILE and PREVIOUS, and print -- 2.29.1 --bymt4oj3t7xtjdgx--