From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 0LspCRyLsF8kLgAA0tVLHw (envelope-from ) for ; Sun, 15 Nov 2020 01:57:48 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 0OPnBByLsF/5PwAA1q6Kng (envelope-from ) for ; Sun, 15 Nov 2020 01:57:48 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 71E4294014A for ; Sun, 15 Nov 2020 01:57:47 +0000 (UTC) Received: from localhost ([::1]:41744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ke7IX-0002TM-VU for larch@yhetil.org; Sat, 14 Nov 2020 20:57:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ke7Hq-0002Sz-TB for bug-guix@gnu.org; Sat, 14 Nov 2020 20:57:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:40763) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ke7Hq-0001Ks-Jq for bug-guix@gnu.org; Sat, 14 Nov 2020 20:57:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ke7Hq-0004Ui-JH for bug-guix@gnu.org; Sat, 14 Nov 2020 20:57:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#44650: Do not suggest `guix pull --news' after first pull Resent-From: "pelzflorian (Florian Pelz)" Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 15 Nov 2020 01:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 44650 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 44650@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.160540541017256 (code B ref -1); Sun, 15 Nov 2020 01:57:02 +0000 Received: (at submit) by debbugs.gnu.org; 15 Nov 2020 01:56:50 +0000 Received: from localhost ([127.0.0.1]:52309 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ke7Hd-0004UG-Nv for submit@debbugs.gnu.org; Sat, 14 Nov 2020 20:56:50 -0500 Received: from lists.gnu.org ([209.51.188.17]:58736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ke7Hb-0004U8-9u for submit@debbugs.gnu.org; Sat, 14 Nov 2020 20:56:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45372) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ke7Hb-0002RG-1b for bug-guix@gnu.org; Sat, 14 Nov 2020 20:56:47 -0500 Received: from pelzflorian.de ([5.45.111.108]:52194 helo=mail.pelzflorian.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ke7HY-0001Iy-7S for bug-guix@gnu.org; Sat, 14 Nov 2020 20:56:46 -0500 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 8D5C83605A8 for ; Sun, 15 Nov 2020 02:56:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1605405400; bh=2tU+9Lvo2k6R0Y/i7mFGY7XfDdHUUDZXoNH0C8vSKEk=; h=Date:From:To:Subject; b=DP50UQyPpupF/YXBzhPS63IKPuK6PWkxt7VBBCjOKo6rzqKTKAptvphC84h1dOhQ9 KKTNrAu7bV3RLOmevtev4YoWn+h/ljnCfCeyOxLtRwNA7yilaW5cHiyhNwAfF0g6zi dRBiJpdkjyVQvbIZ5HS40z05JYepfW7AGwH6K79k= Date: Sun, 15 Nov 2020 02:56:30 +0100 From: "pelzflorian (Florian Pelz)" Message-ID: <20201115015630.aknnrsoggtsabmfo@pelzflorian.localdomain> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="jslxp5ikgorywcrr" Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=5.45.111.108; envelope-from=pelzflorian@pelzflorian.de; helo=mail.pelzflorian.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/14 20:56:40 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -2.4 (--) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=pelzflorian.de header.s=mail header.b=DP50UQyP; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: 0.99 X-TUID: EfdJpA4WEeZC --jslxp5ikgorywcrr Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit After doing a `guix pull` on the new VM image , the following is displayed: > hint: Run `guix pull --news' to read all the news. > > hint: After setting `PATH', run `hash guix' to make sure your shell refers to `/home/guest/.config/guix/current/bin/guix'. The former `guix pull --news` is without effect (it is the very first time I did a `guix pull`). It is a no-op. Users should not get the suggestion to run `guix pull --news`. Within (guix scripts pull)’ build-and-install procedure, the value of (display-channel-news-headlines profile) is . The attached patch changes it to return #f. I have verified running `guix pull --news' is not suggested anymore with it (although I have not tested if news are still displayed). It would perhaps be nicer if the news since version 1.2.0 were displayed, but I do not know how to make it so. I guess since the original guix package must come from the guix package in (gnu packages package-management), it is impossible to determine the version from which news should be computed. Regards, Florian --jslxp5ikgorywcrr Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-pull-Do-not-suggest-running-guix-pull-news-on-the-fi.patch" >From 8da37dc91f2f82da5f1da0ed2b6f0c0602599e5c Mon Sep 17 00:00:00 2001 From: Florian Pelz Date: Sat, 14 Nov 2020 23:36:52 +0100 Subject: [PATCH] pull: Do not suggest running `guix pull --news' on the first run. * guix/scripts/pull.scm (display-channel-news-headlines): If there are no news to display, return false instead of . --- guix/scripts/pull.scm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/guix/scripts/pull.scm b/guix/scripts/pull.scm index bb1b560a22..38405fb79d 100644 --- a/guix/scripts/pull.scm +++ b/guix/scripts/pull.scm @@ -385,7 +385,7 @@ previous generation. Return true if there are news to display." (and=> (relative-generation profile -1) (cut generation-file-name profile <>))) - (when previous + (if previous (let ((old-channels (profile-channels previous)) (new-channels (profile-channels profile))) ;; Find the channels present in both PROFILE and PREVIOUS, and print @@ -405,7 +405,8 @@ previous generation. Return true if there are news to display." #:concise? #t))) channels)) - (any ->bool more?)))))) + (any ->bool more?)))) + #f)) (define (display-news profile) ;; Display profile news, with the understanding that this process represents -- 2.29.1 --jslxp5ikgorywcrr--