From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id sFFbOSLSm1+ELwAA0tVLHw (envelope-from ) for ; Fri, 30 Oct 2020 08:43:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id MKwbNSLSm18eJgAAbx9fmQ (envelope-from ) for ; Fri, 30 Oct 2020 08:43:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 562FA94042F for ; Fri, 30 Oct 2020 08:43:14 +0000 (UTC) Received: from localhost ([::1]:45908 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYQ07-0007uR-K0 for larch@yhetil.org; Fri, 30 Oct 2020 04:43:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50226) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYPzy-0007s1-8S for bug-guix@gnu.org; Fri, 30 Oct 2020 04:43:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44469) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYPzx-0004vq-Vf for bug-guix@gnu.org; Fri, 30 Oct 2020 04:43:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kYPzx-0002SZ-TN for bug-guix@gnu.org; Fri, 30 Oct 2020 04:43:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#44254: Performance of package input rewriting References: <20201027132614.GB3081@zpidnp36> Resent-From: Lars-Dominik Braun Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 30 Oct 2020 08:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44254 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ricardo Wurmus , Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 44254-submit@debbugs.gnu.org id=B44254.16040473749439 (code B ref 44254); Fri, 30 Oct 2020 08:43:01 +0000 Received: (at 44254) by debbugs.gnu.org; 30 Oct 2020 08:42:54 +0000 Received: from localhost ([127.0.0.1]:56015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYPzq-0002SB-3p for submit@debbugs.gnu.org; Fri, 30 Oct 2020 04:42:54 -0400 Received: from mail-wr1-f47.google.com ([209.85.221.47]:33819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYPzo-0002Rz-M2 for 44254@debbugs.gnu.org; Fri, 30 Oct 2020 04:42:52 -0400 Received: by mail-wr1-f47.google.com with SMTP id i16so108822wrv.1 for <44254@debbugs.gnu.org>; Fri, 30 Oct 2020 01:42:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leibniz-psychology-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :in-reply-to; bh=IHKRB6j6c3w9bX1I5IGfRbFo/bZCO5whWqO394koJWU=; b=UlZFmWQMdWwGIQ4AfqGonyqNumeqEABou73gsSoIq8X364zNy5S/X2zwVt/k2YKYH5 O9TOQy14gDz5yQ+MJAnLL/0VDJJdF1lAloRuyKbTqV6GpMy4rOWm04Peq+FLma+RKeC+ j+dL64vyIfLcAltMW93Iq2SsNnMaCRgd5eAiNzZfypOHmsS9oph7D9aZeDlKtHMi2HRJ EDAvvmCMEDaRFgTWtqa1G3SZF9jlQ0x1saK7oRAQ30mGyuNFEylausgkR+s6qmZSUVXD sZ7eaeqsP2AftZz6JxFMJKV27UeoJnXYoEbeq+3dvgQs7ljtV8a9NXRuwRMRBNxjo1wb Cd5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:in-reply-to; bh=IHKRB6j6c3w9bX1I5IGfRbFo/bZCO5whWqO394koJWU=; b=o0SO69ELM78t268rVBkjxDFSJiw42ymIQ2ZWRu51vE43y8r6Xh177Z66i7g0eQY5j/ OxA2gagzw973ao3ZWgw/PjSHag7jX8MQAfNZrEu6EX3cT26cOXWZedjFZae1BHD2JFtE DbhhnxpsKdecJ/oDwMhYRW0eGPFkDxTOQm0++EVA5y/vhXG452FNaC4iHrRvVmMFaX/r 7CNPEO4MJlRJ6G6Uc47auGQwsuw7v9RLmesQo4BaTx5A46BQbAiNeAw1Kb+p5Ykl81L0 xmb/3s6sDo+MO79i8f+2Pc/QrNYHClQgY0LNDeKI9vmBTaMBdobo9oVEYXlySNuU/V52 OKyg== X-Gm-Message-State: AOAM5331QmZRHzytcXr/WIG2jJS84A7OXsGR1UtK0Qxdi5GqN+Erqe/v jI/pVFfsRGzo6BJeR7Jil7u8G0a/Q2h5SHwruU+8NST+WUYEI9Q6BDMAsWQem2vMCOnsbvEuvWW IcucUx4PRoOlwSST+i1eJNK8Dc2rt1ACxQx4+cFDlkY0YLNg0+lYbtJrkte/dqaRF/6XlhTwFTp 48ntk= X-Google-Smtp-Source: ABdhPJwKtiL8B+26nu6kjB5gvXri41Kbjjb1GJgJlIVrzZvQk/KjM1iUmjcVZgH/warE5NcP98rOfw== X-Received: by 2002:a5d:54c1:: with SMTP id x1mr1749583wrv.172.1604047366454; Fri, 30 Oct 2020 01:42:46 -0700 (PDT) Received: from localhost (dynamic-2a01-0c22-c82e-e900-3cb0-1527-c3b4-f9df.c22.pool.telefonica.de. [2a01:c22:c82e:e900:3cb0:1527:c3b4:f9df]) by smtp.gmail.com with ESMTPSA id y7sm3837614wmg.40.2020.10.30.01.42.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Oct 2020 01:42:45 -0700 (PDT) Date: Fri, 30 Oct 2020 09:42:45 +0100 From: Lars-Dominik Braun Message-ID: <20201030084245.GB3128@zpidnp36> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="f2QGlHpHGjS2mn6Y" Content-Disposition: inline In-Reply-To: <87o8km301f.fsf@gnu.org> <87imav1lwp.fsf@elephly.net> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44254@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=leibniz-psychology-org.20150623.gappssmtp.com header.s=20150623 header.b=UlZFmWQM; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.61 X-TUID: bfYqQ8R0lfcE --f2QGlHpHGjS2mn6Y Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, > Yes, that=E2=80=99s a possible culprit. Try passing #:deep? #f if it wor= ks for > your use case. Yeah, that brings it down to ~8s, which is still alot. > Another thing to look at is the object graph (as show by =E2=80= =98guix > graph=E2=80=99). Input rewriting can duplicate parts of the graph, which= in > turn defeats package->derivation memoization. Just looking at the > number of nodes in the graph can give hints. Aha, it=E2=80=99s 913 nodes without rewriting, 13916 with rewriting (#:deep= ? #t) and 4286 with rewriting (#:deep? #f) as determined by a rather ad-hoc `guix gra= ph -L . -t package python-jupyterlab | grep 'shape =3D box' | wc -l`. That see= ms way too much. Does that mean I=E2=80=99m using package rewriting in the wrong w= ay or is that a bug? Unfortunately I don=E2=80=99t have a short reproducer right now. I=E2=80=99= ll look at the graph more closely to figure out which parts are actually duplicated. Maybe I can create a reproducing testcase with more information. Cheers, Lars --f2QGlHpHGjS2mn6Y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEyk+M9DfXR4/aBV/UQhN3ARo3hEYFAl+b0gEACgkQQhN3ARo3 hEZKNgv/XsWkY+fy4zRIPx/SK5XuAOjLzvKI9w4ahuvN8ewSGzpuuhRTyzU6TIN6 AWgTJJjSkHkeFY8iDgHXwgJ9KIOBtNOz7Pwvg6yUG6+nEIVjxAmmL6T2q43FPHxz gLou6pWJjsNOx10gNsKduWDcwUdeYW9KDLN2HdY3RQHnzf93cK13YuF6DiCp63Hb sq454Q7MFHo7EMrGaNx6QwuSG4tqHW8wjs9er2ioECJ4DT9XJseUXEvNKjcfuUkW TpJWuMraO1Rzb4JZD5GkqzKzX32Dgf355b8MxR//XUwfgxI4hD57CS+xedrqCUFN XhJoQgHds3cAqO54Mv2b9004kDlqHc4tb/PFnsjVEjtBwG19ARTOwA+v+avHlGop hYT8tnlrl9B+mufMqILVdq9eU/KvOHmv6wtxQycb/yX30gxecc7Bqqk0MaZ//B23 hSSnReGdqmNtY/9hKnSva90iwLvZXoq9nBJo/BuBhcWcSEr2MrTwu7GIO3NAhnuH dYdKQhzq =Of5M -----END PGP SIGNATURE----- --f2QGlHpHGjS2mn6Y--