unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / Atom feed
* bug#43810: ripgrep and fd create .crates.toml which reference to build dir.
@ 2020-10-05  7:45 Zhu Zihao
  2020-10-06  7:12 ` Efraim Flashner
  2020-10-06  7:40 ` Efraim Flashner
  0 siblings, 2 replies; 3+ messages in thread
From: Zhu Zihao @ 2020-10-05  7:45 UTC (permalink / raw)
  To: 43810

[-- Attachment #1: Type: text/plain, Size: 651 bytes --]

In Guix commit 7cb4440951fa3a91d48c63ac5be123636abfcf82. I found that ripgrep and fd will emit a `.crates.toml` file outside of FHS structure(at the root of profile).


For example, the .crates.toml file from fd looks like.



```

[v1]
"fd-find 8.1.1 (path+file:///tmp/guix-build-fd-8.1.1.drv-0/fd-find-8.1.1)" = ["fd"]
```


This file records the build directory, I think we'd better to exclude this to improve the determinisitc(If this file doesn't affect the functionality).


If we can't exclude it, it's better to place it in a proper place, if we leave it in the root of profile, .crates.toml from different rust apps will override each other.

[-- Attachment #2: Type: text/html, Size: 1122 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#43810: ripgrep and fd create .crates.toml which reference to build dir.
  2020-10-05  7:45 bug#43810: ripgrep and fd create .crates.toml which reference to build dir Zhu Zihao
@ 2020-10-06  7:12 ` Efraim Flashner
  2020-10-06  7:40 ` Efraim Flashner
  1 sibling, 0 replies; 3+ messages in thread
From: Efraim Flashner @ 2020-10-06  7:12 UTC (permalink / raw)
  To: Zhu Zihao; +Cc: 43810

[-- Attachment #1: Type: text/plain, Size: 1207 bytes --]

On Mon, Oct 05, 2020 at 03:45:45PM +0800, Zhu Zihao wrote:
> In Guix commit 7cb4440951fa3a91d48c63ac5be123636abfcf82. I found that ripgrep and fd will emit a `.crates.toml` file outside of FHS structure(at the root of profile).
> 
> 
> For example, the .crates.toml file from fd looks like.
> 
> 
> 
> ```
> 
> [v1]
> "fd-find 8.1.1 (path+file:///tmp/guix-build-fd-8.1.1.drv-0/fd-find-8.1.1)" = ["fd"]
> ```
> 
> 
> This file records the build directory, I think we'd better to exclude this to improve the determinisitc(If this file doesn't affect the functionality).
> 
> 
> If we can't exclude it, it's better to place it in a proper place, if we leave it in the root of profile, .crates.toml from different rust apps will override each other.

It turns out this file seems to exist in other crate packages too. I
just checked rust-cbindgen. Luckily the rust bootstrap process doesn't
use the cargo-build-system so it's something we can fix on master and
not staging.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#43810: ripgrep and fd create .crates.toml which reference to build dir.
  2020-10-05  7:45 bug#43810: ripgrep and fd create .crates.toml which reference to build dir Zhu Zihao
  2020-10-06  7:12 ` Efraim Flashner
@ 2020-10-06  7:40 ` Efraim Flashner
  1 sibling, 0 replies; 3+ messages in thread
From: Efraim Flashner @ 2020-10-06  7:40 UTC (permalink / raw)
  To: Zhu Zihao; +Cc: 43810-done

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

I've pushed a patch to remove this file during the install phase when
building crates & rust apps.


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-10-06  8:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-05  7:45 bug#43810: ripgrep and fd create .crates.toml which reference to build dir Zhu Zihao
2020-10-06  7:12 ` Efraim Flashner
2020-10-06  7:40 ` Efraim Flashner

unofficial mirror of bug-guix@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix-bugs/0 guix-bugs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-bugs guix-bugs/ https://yhetil.org/guix-bugs \
		bug-guix@gnu.org
	public-inbox-index guix-bugs

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.bugs
	nntp://news.gmane.io/gmane.comp.gnu.guix.bugs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git