unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: Zhu Zihao <all_but_last@163.com>
Cc: 43810@debbugs.gnu.org
Subject: bug#43810: ripgrep and fd create .crates.toml which reference to build dir.
Date: Tue, 6 Oct 2020 10:12:58 +0300	[thread overview]
Message-ID: <20201006071258.GC21174@E5400> (raw)
In-Reply-To: <1a426c2b.160d.174f7b9389f.Coremail.all_but_last@163.com>

[-- Attachment #1: Type: text/plain, Size: 1207 bytes --]

On Mon, Oct 05, 2020 at 03:45:45PM +0800, Zhu Zihao wrote:
> In Guix commit 7cb4440951fa3a91d48c63ac5be123636abfcf82. I found that ripgrep and fd will emit a `.crates.toml` file outside of FHS structure(at the root of profile).
> 
> 
> For example, the .crates.toml file from fd looks like.
> 
> 
> 
> ```
> 
> [v1]
> "fd-find 8.1.1 (path+file:///tmp/guix-build-fd-8.1.1.drv-0/fd-find-8.1.1)" = ["fd"]
> ```
> 
> 
> This file records the build directory, I think we'd better to exclude this to improve the determinisitc(If this file doesn't affect the functionality).
> 
> 
> If we can't exclude it, it's better to place it in a proper place, if we leave it in the root of profile, .crates.toml from different rust apps will override each other.

It turns out this file seems to exist in other crate packages too. I
just checked rust-cbindgen. Luckily the rust bootstrap process doesn't
use the cargo-build-system so it's something we can fix on master and
not staging.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-10-06  7:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-05  7:45 bug#43810: ripgrep and fd create .crates.toml which reference to build dir Zhu Zihao
2020-10-06  7:12 ` Efraim Flashner [this message]
2020-10-06  7:40 ` Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201006071258.GC21174@E5400 \
    --to=efraim@flashner.co.il \
    --cc=43810@debbugs.gnu.org \
    --cc=all_but_last@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).