From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id yPpaI2eud1+zXwAA0tVLHw (envelope-from ) for ; Fri, 02 Oct 2020 22:49:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id kJEPH2eud1+LcAAAbx9fmQ (envelope-from ) for ; Fri, 02 Oct 2020 22:49:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E860F9401DF for ; Fri, 2 Oct 2020 22:49:10 +0000 (UTC) Received: from localhost ([::1]:33236 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kOTrR-0004dt-BJ for larch@yhetil.org; Fri, 02 Oct 2020 18:49:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43062) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kOTrK-0004dl-CY for bug-guix@gnu.org; Fri, 02 Oct 2020 18:49:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59400) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kOTrK-0004FQ-3A for bug-guix@gnu.org; Fri, 02 Oct 2020 18:49:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kOTrK-0002GV-11 for bug-guix@gnu.org; Fri, 02 Oct 2020 18:49:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#43746: What to do about packages that don't support --without-tests / #:tests? #f setting Resent-From: "pelzflorian (Florian Pelz)" Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 02 Oct 2020 22:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43746 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 43746-submit@debbugs.gnu.org id=B43746.16016789168668 (code B ref 43746); Fri, 02 Oct 2020 22:49:01 +0000 Received: (at 43746) by debbugs.gnu.org; 2 Oct 2020 22:48:36 +0000 Received: from localhost ([127.0.0.1]:42713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOTqu-0002Fj-3e for submit@debbugs.gnu.org; Fri, 02 Oct 2020 18:48:36 -0400 Received: from pelzflorian.de ([5.45.111.108]:48452 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOTqq-0002Fa-RX for 43746@debbugs.gnu.org; Fri, 02 Oct 2020 18:48:35 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 374C736057E; Sat, 3 Oct 2020 00:48:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1601678911; bh=RHgnNjWt3UfQoDiqIkvoyVNfxY/YcpwKuWrl2yXXYWE=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=qwVNXZP3aOqlgWZrm21UgWQCvc+FYFT5C2ABPjYH0ziJTX9tWSx+MNYP7gK9A5ORO LVeO2vRFemMWM45NqQGezavqKAUsUoqIC8zqB3kzJLAxRB7QKHbEWLnkyeOxbz1IA0 5FwDZRcR6QGagmxL8Xa0FUn4YLtnT3B54831OScE= Date: Sat, 3 Oct 2020 00:48:21 +0200 From: "pelzflorian (Florian Pelz)" Message-ID: <20201002224821.64mmk3fzk27c5pvi@pelzflorian.localdomain> References: <20201001143136.mu224kslmtpj4std@pelzflorian.localdomain> <87d021mz85.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="4adkinx4atnqgcuo" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87d021mz85.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 43746@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=pelzflorian.de header.s=mail header.b=qwVNXZP3; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: 0.99 X-TUID: K6lvBvRvePW7 --4adkinx4atnqgcuo Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Thu, Oct 01, 2020 at 11:07:54PM +0200, Ludovic Courtès wrote: > Oh, we should fix ‘glib’ in ‘core-updates’. I verified the attached patch fixes glib on the ‘master’ branch. I’m not sure about adding a copyright. Anyway. Shall I push it to ‘core-updates’ or wait until I can test it on ‘core-updates’ without rebuilding the world? > I’m inclined to apply the patch you propose and leaving phases > unchanged. > […] > I’d change the last sentence to: > > Therefore, @option{--without-tests} has no effect on these packages. I changed it and pushed the patch to the documentation as 3c01fcc1bb9c086f487d9694cb91a57d7abd0880. Thank you! (I maybe should have written in the commit message “Fixes .” Oh well. I will leave the bug open though because glib is not fixed yet.) Regards, Florian --4adkinx4atnqgcuo Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: attachment; filename="0001-gnu-glib-Adhere-to-without-tests-option.patch" Content-Transfer-Encoding: 8bit >From 505cfd0fa3411a21c8794ab84473dc1dd2b8754c Mon Sep 17 00:00:00 2001 From: Florian Pelz Date: Sat, 3 Oct 2020 00:29:56 +0200 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [PATCH] gnu: glib: Adhere to '--without-tests' option. * gnu/packages/glib.scm (glib)[arguments]<#:phases>[configure]: Only run tests if 'tests?' is true. --- gnu/packages/glib.scm | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/gnu/packages/glib.scm b/gnu/packages/glib.scm index ca037d3b24..c703894155 100644 --- a/gnu/packages/glib.scm +++ b/gnu/packages/glib.scm @@ -13,6 +13,7 @@ ;;; Copyright 2019 Giacomo Leidi ;;; Copyright 2019, 2020 Marius Bakke ;;; Copyright 2020 Nicol Balzarotti +;;; Copyright 2020 Florian Pelz ;;; ;;; This file is part of GNU Guix. ;;; @@ -325,11 +326,14 @@ shared NFS home directories.") (for-each (lambda (x) (apply disable x)) failing-tests) #t))) (replace 'check - (lambda _ - (setenv "MESON_TESTTHREADS" - (number->string (parallel-job-count))) - ;; Do not run tests marked as "flaky". - (invoke "meson" "test" "--no-suite" "flaky"))) + (lambda* (#:key tests? #:allow-other-keys) + (if tests? + (begin + (setenv "MESON_TESTTHREADS" + (number->string (parallel-job-count))) + ;; Do not run tests marked as "flaky". + (invoke "meson" "test" "--no-suite" "flaky")) + #t))) ;; TODO: meson does not permit the bindir to be outside of prefix. ;; See https://github.com/mesonbuild/meson/issues/2561 ;; We can remove this once meson is patched. -- 2.28.0 --4adkinx4atnqgcuo--