From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id PNEcDbnpdV+jbAAA0tVLHw (envelope-from ) for ; Thu, 01 Oct 2020 14:37:45 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id aFNfCLnpdV96dgAAbx9fmQ (envelope-from ) for ; Thu, 01 Oct 2020 14:37:45 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A7D859402DD for ; Thu, 1 Oct 2020 14:37:44 +0000 (UTC) Received: from localhost ([::1]:39054 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNziJ-0005G9-LZ for larch@yhetil.org; Thu, 01 Oct 2020 10:37:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37724) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNzco-000259-ED for bug-guix@gnu.org; Thu, 01 Oct 2020 10:32:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54551) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kNzco-0000rJ-4Y for bug-guix@gnu.org; Thu, 01 Oct 2020 10:32:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kNzco-0003mo-1I for bug-guix@gnu.org; Thu, 01 Oct 2020 10:32:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#43746: What to do about packages that don't support --without-tests / #:tests? #f setting Resent-From: "pelzflorian (Florian Pelz)" Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 01 Oct 2020 14:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43746 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 43746@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.160156272114549 (code B ref -1); Thu, 01 Oct 2020 14:32:01 +0000 Received: (at submit) by debbugs.gnu.org; 1 Oct 2020 14:32:01 +0000 Received: from localhost ([127.0.0.1]:37864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNzcn-0003mX-2h for submit@debbugs.gnu.org; Thu, 01 Oct 2020 10:32:01 -0400 Received: from lists.gnu.org ([209.51.188.17]:49176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNzcl-0003mO-6T for submit@debbugs.gnu.org; Thu, 01 Oct 2020 10:32:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNzck-00023s-Vj for bug-guix@gnu.org; Thu, 01 Oct 2020 10:31:58 -0400 Received: from pelzflorian.de ([5.45.111.108]:51966 helo=mail.pelzflorian.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNzcg-0000qn-U0 for bug-guix@gnu.org; Thu, 01 Oct 2020 10:31:58 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 6999736057E for ; Thu, 1 Oct 2020 16:31:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1601562709; bh=67taK1yvUJJUD/TrnTLVygm6DRSgh3egLmvFMUVftuM=; h=Date:From:To:Subject; b=MFi3/C7vjSWIFJQylyHoWSrVasQ/4yZOZ1CatZ3o8EjJDXhEhKg3FjS7wUrOV3q7c DUhM2xdT8rJP7QetHFLw5XSSbuOG7d7FDvhromt9xfgo8Y5gx0/FZKsABZuhhKw2FR AQMQjndcgr6zb2CHvuS9XMTpeTxItVX1CslP1x5U= Date: Thu, 1 Oct 2020 16:31:36 +0200 From: "pelzflorian (Florian Pelz)" Message-ID: <20201001143136.mu224kslmtpj4std@pelzflorian.localdomain> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="cub5r7pcqwkxe55n" Content-Disposition: inline Received-SPF: pass client-ip=5.45.111.108; envelope-from=pelzflorian@pelzflorian.de; helo=mail.pelzflorian.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/01 10:31:49 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -2.4 (--) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=pelzflorian.de header.s=mail header.b=MFi3/C7v; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: 0.99 X-TUID: csYsZ0hqyjFa --cub5r7pcqwkxe55n Content-Type: text/plain; charset=us-ascii Content-Disposition: inline The new package transformation option --without-tests works by setting #:tests? #f in the specified packages. But some packages replace their 'check phase and no longer honor #tests?. glib for example. Attached is an attempt to document this current behavior. Shall I push it? Alternatively, it should be documented to write a check phase that honors #:tests?. Or the package transformation should be changed to remove any check phase it finds. Regards, Florian --cub5r7pcqwkxe55n Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-doc-Explain-why-without-tests-may-fail-with-modified.patch" >From b55e6ee01fe674b282e7ec75d0e4c8a839262261 Mon Sep 17 00:00:00 2001 From: Florian Pelz Date: Thu, 1 Oct 2020 15:35:52 +0200 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [PATCH] doc: Explain why '--without-tests' may fail with modified 'check' phase. * doc/guix.texi (Package Transformation Options): Explain. --- doc/guix.texi | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/doc/guix.texi b/doc/guix.texi index e8458ad8d8..6a2bd629cb 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -9350,6 +9350,12 @@ The command above installs @code{python-notebook} on top of rebuilds everything that depends on @code{python}, including @code{python-notebook} itself. +Internally, @code{--without-tests} relies on changing the +@code{#:tests?} option of a package's @code{check} phase (@pxref{Build +Systems}). Note that some packages use a customized @code{check} phase +that does not respect a @code{#:tests? #f} setting. Therefore there are +some packages for which @code{--without-tests} cannot disable tests. + @end table @node Additional Build Options -- 2.28.0 --cub5r7pcqwkxe55n--