From: Danny Milosavljevic <dannym@scratchpost.org>
To: Leo Famulari <leo@famulari.name>
Cc: Mathieu Othacehe <othacehe@gnu.org>, 43344@debbugs.gnu.org
Subject: bug#43344: "basic" system tests fail (and all the other ones) on guix master
Date: Thu, 17 Sep 2020 17:28:06 +0200 [thread overview]
Message-ID: <20200917172806.1d03de5c@scratchpost.org> (raw)
In-Reply-To: <20200917140544.GA14066@jasmine.lan>
[-- Attachment #1: Type: text/plain, Size: 1401 bytes --]
Hi Leo,
On Thu, 17 Sep 2020 10:05:44 -0400
Leo Famulari <leo@famulari.name> wrote:
> On Wed, Sep 16, 2020 at 09:36:49PM -0400, Mark H Weaver wrote:
> > > On Wed, Sep 16, 2020 at 04:52:45PM +0200, Danny Milosavljevic wrote:
> > >> commit 692d0626557451c4b557397f20b7394b612d0289
> > >> Author: Christoph Hellwig <hch@lst.de>
> > >> Date: Tue Sep 1 11:59:41 2020 +0200
> > >>
> > >> block: fix locking in bdev_del_partition
>
> > Next, it probably makes sense to test 5.8.9 with the above commit
> > reverted. Would someone like to try it? If that works, we can avoid
> > the bisection, resume kernel updates, and revert this change across all
> > of our kernels until a better solution is found.
>
> Using linux-libre 5.8.9 with that commit reverted, `guix system vm` does
> work again.
Thanks for testing it!
What the commit does is lock the drive whose partition table is being
modified. That sounds like a good idea in general. But parted does not
expect the error code ENOMEM and thus misjudges the situation.
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=88ce2a530cc9865a894454b2e40eba5957a60e1a
for the fix that goes into Linux 5.9.
We could also patch parted to also accept ENOMEM in addition to ENXIO if we
wanted to. I wouldn't (it diverges from what upstream is doing--too much work).
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-09-17 15:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 17:50 bug#43344: "basic" system tests fail (and all the other ones) on guix master Danny Milosavljevic
2020-09-14 13:26 ` Mathieu Othacehe
2020-09-14 16:31 ` Danny Milosavljevic
2020-09-15 22:34 ` Mark H Weaver
2020-09-15 23:06 ` Leo Famulari
2020-09-16 14:12 ` Leo Famulari
2020-09-16 14:52 ` Danny Milosavljevic
2020-09-16 15:02 ` Danny Milosavljevic
2020-09-16 16:22 ` Leo Famulari
2020-09-17 1:36 ` Mark H Weaver
2020-09-17 2:21 ` Leo Famulari
2020-09-17 8:40 ` Marius Bakke
2020-09-17 14:20 ` Leo Famulari
2020-09-17 19:08 ` Mark H Weaver
2020-09-17 14:05 ` Leo Famulari
2020-09-17 15:28 ` Danny Milosavljevic [this message]
2020-09-16 13:59 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917172806.1d03de5c@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=43344@debbugs.gnu.org \
--cc=leo@famulari.name \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).