From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 6Ca0IzYpYl9pPgAA0tVLHw (envelope-from ) for ; Wed, 16 Sep 2020 15:03:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id oDm2HzYpYl8zQQAAB5/wlQ (envelope-from ) for ; Wed, 16 Sep 2020 15:03:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 052B2940142 for ; Wed, 16 Sep 2020 15:03:18 +0000 (UTC) Received: from localhost ([::1]:55912 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIYxo-0000Gm-W7 for larch@yhetil.org; Wed, 16 Sep 2020 11:03:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55118) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIYxb-0000EM-D5 for bug-guix@gnu.org; Wed, 16 Sep 2020 11:03:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52375) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIYxa-0002Oo-56 for bug-guix@gnu.org; Wed, 16 Sep 2020 11:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kIYxa-0001HR-1a for bug-guix@gnu.org; Wed, 16 Sep 2020 11:03:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#43344: "basic" system tests fail (and all the other ones) on guix master Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 16 Sep 2020 15:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43344 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Leo Famulari Received: via spool by 43344-submit@debbugs.gnu.org id=B43344.16002685784907 (code B ref 43344); Wed, 16 Sep 2020 15:03:01 +0000 Received: (at 43344) by debbugs.gnu.org; 16 Sep 2020 15:02:58 +0000 Received: from localhost ([127.0.0.1]:35688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIYxW-0001H4-GU for submit@debbugs.gnu.org; Wed, 16 Sep 2020 11:02:58 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:32790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIYxU-0001Gu-E6 for 43344@debbugs.gnu.org; Wed, 16 Sep 2020 11:02:57 -0400 Received: from localhost (80-110-126-103.cgn.dynamic.surfer.at [80.110.126.103]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 0E9123360304; Wed, 16 Sep 2020 17:02:55 +0200 (CEST) Date: Wed, 16 Sep 2020 17:02:39 +0200 From: Danny Milosavljevic Message-ID: <20200916170239.580ac59a@scratchpost.org> In-Reply-To: <20200916165245.421e3c4c@scratchpost.org> References: <20200911195058.6dc013b4@scratchpost.org> <877dsw7alf.fsf@gnu.org> <20200914183037.624cc347@scratchpost.org> <87y2laactz.fsf@netris.org> <20200915230628.GA20807@jasmine.lan> <20200916141231.GA28015@jasmine.lan> <20200916165245.421e3c4c@scratchpost.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/gWDy=VJGiW_YNW208ed5_i7"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mathieu Othacehe , 43344@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.11 X-TUID: zO9TwcopOvDt --Sig_/gWDy=VJGiW_YNW208ed5_i7 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 16 Sep 2020 16:52:45 +0200 Danny Milosavljevic wrote: > commit 692d0626557451c4b557397f20b7394b612d0289 > Author: Christoph Hellwig > Date: Tue Sep 1 11:59:41 2020 +0200 >=20 > block: fix locking in bdev_del_partition > =20 > [ Upstream commit 08fc1ab6d748ab1a690fd483f41e2938984ce353 ] > =20 > We need to hold the whole device bd_mutex to protect against > other thread concurrently deleting out partition before we get > to it, and thus causing a use after free. > =20 > Fixes: cddae808aeb7 ("block: pass a hd_struct to delete_partition") > Reported-by: syzbot+6448f3c229bc52b82f69@syzkaller.appspotmail.com > Signed-off-by: Christoph Hellwig > Signed-off-by: Jens Axboe > Signed-off-by: Sasha Levin >=20 int bdev_del_partition(struct block_device *bdev, int partno) { struct block_device *bdevp; struct hd_struct *part =3D NULL; int ret; bdevp =3D bdget_disk(bdev->bd_disk, partno); if (!bdevp) return -ENOMEM; <-------------- ... } struct block_device *bdget_disk(struct gendisk *disk, int partno) { struct hd_struct *part; struct block_device *bdev =3D NULL; part =3D disk_get_part(disk, partno); if (part) bdev =3D bdget(part_devt(part)); disk_put_part(part); return bdev; } struct block_device *bdget(dev_t dev) { struct block_device *bdev; struct inode *inode; inode =3D iget5_locked(blockdev_superblock, hash(dev), bdev_test, bdev_set, &dev); if (!inode) return NULL; <-------------------- [...] } --Sig_/gWDy=VJGiW_YNW208ed5_i7 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl9iKQ8ACgkQ5xo1VCww uqWWPQf+KN0J6gI0j5qCLy9glxGYn52k+m4TbXE83/Zb68h80/ytGW0F8GIPXCnw +qSuSEErK+Nr/RBTViAKDAS0X7jcYpMlmL42Exyt3vyEnIYwxN8k3pTwqrYwzMjh Vr2Srdh3SS/NW7rVcR0dOXsgitEPTUVsvgBjvGaofKvoU0Ny2SYi44nnPKGYqskv wZE42iRH4c8qZz8+LkjO/MFqjgbOcOFcodrGE9DUjxx4RnpmijHIsoTPKJiZ4qjZ BrAAN+xj2dBh03dK+ZnCodWLqBZmuz4O/6DsiNkiFxLhSQo+RQY1NaEahz/Gns9s wti5qCbPep8FkTDzKutOSkq9oUceRg== =bTO1 -----END PGP SIGNATURE----- --Sig_/gWDy=VJGiW_YNW208ed5_i7--