From: Danny Milosavljevic <dannym@scratchpost.org>
To: Leo Famulari <leo@famulari.name>
Cc: Mathieu Othacehe <othacehe@gnu.org>, 43344@debbugs.gnu.org
Subject: bug#43344: "basic" system tests fail (and all the other ones) on guix master
Date: Wed, 16 Sep 2020 17:02:39 +0200 [thread overview]
Message-ID: <20200916170239.580ac59a@scratchpost.org> (raw)
In-Reply-To: <20200916165245.421e3c4c@scratchpost.org>
[-- Attachment #1: Type: text/plain, Size: 1795 bytes --]
On Wed, 16 Sep 2020 16:52:45 +0200
Danny Milosavljevic <dannym@scratchpost.org> wrote:
> commit 692d0626557451c4b557397f20b7394b612d0289
> Author: Christoph Hellwig <hch@lst.de>
> Date: Tue Sep 1 11:59:41 2020 +0200
>
> block: fix locking in bdev_del_partition
>
> [ Upstream commit 08fc1ab6d748ab1a690fd483f41e2938984ce353 ]
>
> We need to hold the whole device bd_mutex to protect against
> other thread concurrently deleting out partition before we get
> to it, and thus causing a use after free.
>
> Fixes: cddae808aeb7 ("block: pass a hd_struct to delete_partition")
> Reported-by: syzbot+6448f3c229bc52b82f69@syzkaller.appspotmail.com
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
>
int bdev_del_partition(struct block_device *bdev, int partno)
{
struct block_device *bdevp;
struct hd_struct *part = NULL;
int ret;
bdevp = bdget_disk(bdev->bd_disk, partno);
if (!bdevp)
return -ENOMEM; <--------------
...
}
struct block_device *bdget_disk(struct gendisk *disk, int partno)
{
struct hd_struct *part;
struct block_device *bdev = NULL;
part = disk_get_part(disk, partno);
if (part)
bdev = bdget(part_devt(part));
disk_put_part(part);
return bdev;
}
struct block_device *bdget(dev_t dev)
{
struct block_device *bdev;
struct inode *inode;
inode = iget5_locked(blockdev_superblock, hash(dev),
bdev_test, bdev_set, &dev);
if (!inode)
return NULL; <--------------------
[...]
}
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-09-16 15:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 17:50 bug#43344: "basic" system tests fail (and all the other ones) on guix master Danny Milosavljevic
2020-09-14 13:26 ` Mathieu Othacehe
2020-09-14 16:31 ` Danny Milosavljevic
2020-09-15 22:34 ` Mark H Weaver
2020-09-15 23:06 ` Leo Famulari
2020-09-16 14:12 ` Leo Famulari
2020-09-16 14:52 ` Danny Milosavljevic
2020-09-16 15:02 ` Danny Milosavljevic [this message]
2020-09-16 16:22 ` Leo Famulari
2020-09-17 1:36 ` Mark H Weaver
2020-09-17 2:21 ` Leo Famulari
2020-09-17 8:40 ` Marius Bakke
2020-09-17 14:20 ` Leo Famulari
2020-09-17 19:08 ` Mark H Weaver
2020-09-17 14:05 ` Leo Famulari
2020-09-17 15:28 ` Danny Milosavljevic
2020-09-16 13:59 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916170239.580ac59a@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=43344@debbugs.gnu.org \
--cc=leo@famulari.name \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).