unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: Mike Rosset <mike.rosset@gmail.com>
Cc: 43232@debbugs.gnu.org
Subject: bug#43232: [PATCH] gnu: jack-2: Update to 1.9.14.
Date: Tue, 15 Sep 2020 09:21:39 +0300	[thread overview]
Message-ID: <20200915062139.GF17272@E5400> (raw)
In-Reply-To: <20200915042525.4186311-1-mike.rosset@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2817 bytes --]

On Mon, Sep 14, 2020 at 09:25:25PM -0700, Mike Rosset wrote:
> * gnu/packages/audio.scm (jack-2): Update to 1.9.14.
> [arguments]: new 'declare-for-int phase after unpack that declares 'i in the
> for initialize statement.  Add -lstdc++ to LDFLAGS 'set-linkflags phase
> ensures -lstdc++ is at the tail.
> 
> This fixes issues that cause jack-2 to not build on system aarh64-linux.
> ---
>  gnu/packages/audio.scm | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index 38ee4f8bcc..83c08b718e 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -2030,7 +2030,7 @@ synchronous execution of all clients, and low latency operation.")
>  (define-public jack-2
>    (package (inherit jack-1)
>      (name "jack2")
> -    (version "1.9.13")
> +    (version "1.9.14")
>      (source (origin
>               (method url-fetch)
>               (uri (string-append "https://github.com/jackaudio/jack2/releases/"
> @@ -2039,7 +2039,7 @@ synchronous execution of all clients, and low latency operation.")
>               (file-name (string-append name "-" version ".tar.gz"))
>               (sha256
>                (base32
> -               "1d1d403jn4366mqig6g8ghr8057b3rn7gs26b5p3rkal34j20qw2"))))
> +               "0z11hf55a6mi8h50hfz5wry9pshlwl4mzfwgslghdh40cwv342m2"))))
>      (build-system waf-build-system)
>      (arguments
>       `(#:tests? #f  ; no check target
> @@ -2047,8 +2047,18 @@ synchronous execution of all clients, and low latency operation.")
>                             "--alsa")
>         #:phases
>         (modify-phases %standard-phases
> +         (add-after 'unpack 'declare-for-int
> +           (lambda _
> +             ;; Declare the for loop i incrementer.
> +             (substitute* "dbus/sigsegv.c"
> +               (("for\\(i = 0") "for(int i = 0"))
> +             #t))

Any chance of an upstream bug number or something for this? It seems
like the type of thing that might be put into a snippet.

>           (add-before 'configure 'set-linkflags
>             (lambda _
> +             ;; Ensure -lstdc++ is the tail of LDFLAGS or the simdtests.cpp
> +             ;; will not link with undefined reference to symbol
> +             ;; '__gxx_personality_v0@@CXXABI_1.3'
> +             (setenv "LDFLAGS" "-lstdc++")
>               ;; Add $libdir to the RUNPATH of all the binaries.
>               (substitute* "wscript"
>                 ((".*CFLAGS.*-Wall.*" m)
> -- 
> 2.28.0
> 
> 
> 
> 

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-09-15  6:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-06  3:53 bug#43232: jack2 fails to build on aarch64 Vitaliy Shatrov
2020-09-06  8:58 ` Andreas Enge
2020-09-06 10:02   ` Andreas Enge
2020-09-06 13:46   ` Mike Rosset
2020-09-15  4:25 ` bug#43232: [PATCH] gnu: jack-2: Update to 1.9.14 Mike Rosset
2020-09-15  6:21   ` Efraim Flashner [this message]
2020-09-15  7:29     ` Mike Rosset
2020-09-15 20:39     ` Mark H Weaver
2020-09-15 20:48       ` Mark H Weaver
2020-09-15 22:28         ` Mike Rosset
2020-09-15 22:45           ` Mark H Weaver
2020-09-15 21:07       ` Mike Rosset
2020-09-15  7:48 ` bug#43232: [PATCH 2/2] gnu: jack2: 'declare-for-int phase no longer required Mike Rosset
2020-09-15  8:02   ` Andreas Enge
2020-09-15  8:37     ` Mike Rosset
2020-09-15 18:48       ` Andreas Enge
2020-09-15 19:16         ` Mike Rosset
2020-09-15  8:33 ` bug#43232: [PATCH] gnu: jack-2: Update to 1.9.14 Mike Rosset

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200915062139.GF17272@E5400 \
    --to=efraim@flashner.co.il \
    --cc=43232@debbugs.gnu.org \
    --cc=mike.rosset@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).