unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#43151: Resolve Calibre run-time dependency
       [not found] <a99e52ae-decc-0396-6d4e-d3dff56dd5d2@brendan.scot>
@ 2020-09-07  8:15 ` Brendan Tildesley
  2020-09-08 20:11   ` Andreas Enge
  0 siblings, 1 reply; 2+ messages in thread
From: Brendan Tildesley @ 2020-09-07  8:15 UTC (permalink / raw)
  To: Prafulla Giri; +Cc: 43151

Sorry I tried sending this with a typo in your gmail address so I'm 
resending just for you:

On 7/9/20 6:12 pm, Brendan Tildesley wrote:
> There is actually a Bug report by Andreas for this very issue. I 
> created a bug report just for updating, and fixed this issue after it 
> while I could, without realising. Sorry for all the confusion with 
> things happening in 3 different threads.
>
> I created an updated patch just for this one here. 
> https://issues.guix.gnu.org/43151#5
>
> Your patch also works I think but it will wrap the programs twice, so 
> you will get calibre, .calibre-real, and ..calibre-real-real, etc for 
> every program, which seems ugly. My patch reproduces the same 
> PYTHONPATH that is set in python-build-system in addition to wrapping 
> PYTHONPATH (unless I made a mistake), although at the cost of code 
> duplication. I leave it to you and who ever is reviewing this to 
> decide which way is more correct and push one, haha.
>
>
> Please continue any discussion of the QtWebEngine bug on issue 43121: 
> 43151@debbugs.gnu.org / https://issues.guix.gnu.org/43151






^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#43151: Resolve Calibre run-time dependency
  2020-09-07  8:15 ` bug#43151: Resolve Calibre run-time dependency Brendan Tildesley
@ 2020-09-08 20:11   ` Andreas Enge
  0 siblings, 0 replies; 2+ messages in thread
From: Andreas Enge @ 2020-09-08 20:11 UTC (permalink / raw)
  To: Brendan Tildesley; +Cc: 42885, 43151-done, Prafulla Giri, 43249-done

Hello,

On Mon, Sep 07, 2020 at 06:15:15PM +1000, Brendan Tildesley wrote:
> Your patch also works I think but it will wrap the programs twice, so
> you will get calibre, .calibre-real, and ..calibre-real-real, etc for
> every program, which seems ugly. My patch reproduces the same PYTHONPATH
> that is set in python-build-system in addition to wrapping PYTHONPATH
> (unless I made a mistake), although at the cost of code duplication. I
> leave it to you and who ever is reviewing this to decide which way is
> more correct and push one, haha.

thanks to both of your for your patches! I just pushed Brendan's, which
wraps only once at the price of copy-pasting from another package. I confirm
that it works, also to click on an epub file from within calibre. Closing
the two bugs asking about qtwebengine.

Concerning the update, is mathjax a required input now, or could we just
leave it out and update nevertheless?

Andreas





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-08 20:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <a99e52ae-decc-0396-6d4e-d3dff56dd5d2@brendan.scot>
2020-09-07  8:15 ` bug#43151: Resolve Calibre run-time dependency Brendan Tildesley
2020-09-08 20:11   ` Andreas Enge

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).