unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#43180: [PATCH] scripts: system: Expand some help messages.
@ 2020-09-03 11:55 Efraim Flashner
  2020-09-03 12:46 ` Julien Lepiller
  0 siblings, 1 reply; 3+ messages in thread
From: Efraim Flashner @ 2020-09-03 11:55 UTC (permalink / raw)
  To: 43180

* guix/scripts/system.scm (show-help): Add to '--share=SPEC' and
'--expose=SPEC' that it also works for containers.
---
 guix/scripts/system.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/guix/scripts/system.scm b/guix/scripts/system.scm
index b75b0e5b60..be17bc1ba7 100644
--- a/guix/scripts/system.scm
+++ b/guix/scripts/system.scm
@@ -7,6 +7,7 @@
 ;;; Copyright © 2019 Christopher Baines <mail@cbaines.net>
 ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen <janneke@gnu.org>
 ;;; Copyright © 2020 Julien Lepiller <julien@lepiller.eu>
+;;; Copyright © 2020 Efraim Flashner <efraim@flashner.co.il>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -956,9 +957,11 @@ Some ACTIONS support additional ARGS.\n"))
   (display (G_ "
       --save-provenance  save provenance information"))
   (display (G_ "
-      --share=SPEC       for 'vm', share host file system according to SPEC"))
+      --share=SPEC       for 'vm' and 'container', share host file system
+                         according to SPEC"))
   (display (G_ "
-      --expose=SPEC      for 'vm', expose host file system according to SPEC"))
+      --expose=SPEC      for 'vm' and 'container', expose host file system
+                         according to SPEC"))
   (display (G_ "
   -N, --network          for 'container', allow containers to access the network"))
   (display (G_ "
-- 
2.28.0





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#43180: [PATCH] scripts: system: Expand some help messages.
  2020-09-03 11:55 bug#43180: [PATCH] scripts: system: Expand some help messages Efraim Flashner
@ 2020-09-03 12:46 ` Julien Lepiller
  2020-09-05 19:26   ` Efraim Flashner
  0 siblings, 1 reply; 3+ messages in thread
From: Julien Lepiller @ 2020-09-03 12:46 UTC (permalink / raw)
  To: Efraim Flashner; +Cc: 43180

Le Thu,  3 Sep 2020 14:55:42 +0300,
Efraim Flashner <efraim@flashner.co.il> a écrit :

> * guix/scripts/system.scm (show-help): Add to '--share=SPEC' and
> '--expose=SPEC' that it also works for containers.
> ---
>  guix/scripts/system.scm | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/guix/scripts/system.scm b/guix/scripts/system.scm
> index b75b0e5b60..be17bc1ba7 100644
> --- a/guix/scripts/system.scm
> +++ b/guix/scripts/system.scm
> @@ -7,6 +7,7 @@
>  ;;; Copyright © 2019 Christopher Baines <mail@cbaines.net>
>  ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen <janneke@gnu.org>
>  ;;; Copyright © 2020 Julien Lepiller <julien@lepiller.eu>
> +;;; Copyright © 2020 Efraim Flashner <efraim@flashner.co.il>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -956,9 +957,11 @@ Some ACTIONS support additional ARGS.\n"))
>    (display (G_ "
>        --save-provenance  save provenance information"))
>    (display (G_ "
> -      --share=SPEC       for 'vm', share host file system according
> to SPEC"))
> +      --share=SPEC       for 'vm' and 'container', share host file
> system
> +                         according to SPEC"))
>    (display (G_ "
> -      --expose=SPEC      for 'vm', expose host file system according
> to SPEC"))
> +      --expose=SPEC      for 'vm' and 'container', expose host file
> system
> +                         according to SPEC"))
>    (display (G_ "
>    -N, --network          for 'container', allow containers to access
> the network")) (display (G_ "

Should we say something about how sharing is read-write, exposing is
read-only?




^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#43180: [PATCH] scripts: system: Expand some help messages.
  2020-09-03 12:46 ` Julien Lepiller
@ 2020-09-05 19:26   ` Efraim Flashner
  0 siblings, 0 replies; 3+ messages in thread
From: Efraim Flashner @ 2020-09-05 19:26 UTC (permalink / raw)
  To: Julien Lepiller; +Cc: 43180-done

[-- Attachment #1: Type: text/plain, Size: 2119 bytes --]

On Thu, Sep 03, 2020 at 02:46:23PM +0200, Julien Lepiller wrote:
> Le Thu,  3 Sep 2020 14:55:42 +0300,
> Efraim Flashner <efraim@flashner.co.il> a écrit :
> 
> > * guix/scripts/system.scm (show-help): Add to '--share=SPEC' and
> > '--expose=SPEC' that it also works for containers.
> > ---
> >  guix/scripts/system.scm | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/guix/scripts/system.scm b/guix/scripts/system.scm
> > index b75b0e5b60..be17bc1ba7 100644
> > --- a/guix/scripts/system.scm
> > +++ b/guix/scripts/system.scm
> > @@ -7,6 +7,7 @@
> >  ;;; Copyright © 2019 Christopher Baines <mail@cbaines.net>
> >  ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen <janneke@gnu.org>
> >  ;;; Copyright © 2020 Julien Lepiller <julien@lepiller.eu>
> > +;;; Copyright © 2020 Efraim Flashner <efraim@flashner.co.il>
> >  ;;;
> >  ;;; This file is part of GNU Guix.
> >  ;;;
> > @@ -956,9 +957,11 @@ Some ACTIONS support additional ARGS.\n"))
> >    (display (G_ "
> >        --save-provenance  save provenance information"))
> >    (display (G_ "
> > -      --share=SPEC       for 'vm', share host file system according
> > to SPEC"))
> > +      --share=SPEC       for 'vm' and 'container', share host file
> > system
> > +                         according to SPEC"))
> >    (display (G_ "
> > -      --expose=SPEC      for 'vm', expose host file system according
> > to SPEC"))
> > +      --expose=SPEC      for 'vm' and 'container', expose host file
> > system
> > +                         according to SPEC"))
> >    (display (G_ "
> >    -N, --network          for 'container', allow containers to access
> > the network")) (display (G_ "
> 
> Should we say something about how sharing is read-write, exposing is
> read-only?

Sounds good. I expanded it a bit to mention share is read/write and
expose is read-only.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-09-05 19:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-03 11:55 bug#43180: [PATCH] scripts: system: Expand some help messages Efraim Flashner
2020-09-03 12:46 ` Julien Lepiller
2020-09-05 19:26   ` Efraim Flashner

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).