From: Efraim Flashner <efraim@flashner.co.il>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 43015@debbugs.gnu.org
Subject: bug#43015: git-fetched packages' working copy is not writable
Date: Mon, 24 Aug 2020 12:22:56 +0300 [thread overview]
Message-ID: <20200824092256.GH1392@E5400> (raw)
In-Reply-To: <20200824111359.4008ce30@scratchpost.org>
[-- Attachment #1: Type: text/plain, Size: 1615 bytes --]
On Mon, Aug 24, 2020 at 11:13:59AM +0200, Danny Milosavljevic wrote:
> Hi,
>
> the working copy of a package build when the package was git-fetched is not
> writable.
>
> On the other hand, if it's url-fetched, it's perfectly writable.
>
> Shall we fix this on core-updates ?
(ins)efraim@E5400 ~/workspace/guix$ git grep make-files-writable | grep unpack | grep gnu/packages
gnu/packages/bioinformatics.scm: (add-after 'unpack 'make-files-writable
gnu/packages/code.scm: (add-after 'unpack 'make-files-writable
gnu/packages/djvu.scm: (add-after 'unpack 'make-files-writable
gnu/packages/java.scm: (add-after 'unpack 'make-files-writable
gnu/packages/java.scm: (add-after 'unpack 'make-files-writable
gnu/packages/java.scm: (add-after 'unpack 'make-files-writable
gnu/packages/java.scm: (add-after 'unpack 'make-files-writable
gnu/packages/machine-learning.scm: (add-after 'unpack 'make-files-writable
gnu/packages/ocaml.scm: (add-after 'unpack 'make-files-writable
gnu/packages/ruby.scm: (add-after 'unpack 'make-files-writable
My only concern would be if there were files which weren't supposed to
be writable. We're building the package, not making changes to be
submitted upstream or anything, so I don't see that as being a reason to
hold back.
I'm in favor
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-08-24 9:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 9:13 bug#43015: git-fetched packages' working copy is not writable Danny Milosavljevic
2020-08-24 9:22 ` Efraim Flashner [this message]
2021-02-04 12:41 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824092256.GH1392@E5400 \
--to=efraim@flashner.co.il \
--cc=43015@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).