unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#42158: python-grequests broken, add zope dependencies to fix.
@ 2020-07-01 20:39 Christopher Lemmer Webber
  2020-07-02  7:27 ` Efraim Flashner
  0 siblings, 1 reply; 3+ messages in thread
From: Christopher Lemmer Webber @ 2020-07-01 20:39 UTC (permalink / raw)
  To: 42158

[-- Attachment #1: Type: text/plain, Size: 28 bytes --]

Fix attached.  Ok to push?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-python-grequests-Fix-tests-by-adding-zope-depend.patch --]
[-- Type: text/x-patch, Size: 1147 bytes --]

From 1fc31863857361e9f88d92cbea2099fd7ea03b10 Mon Sep 17 00:00:00 2001
From: Christopher Lemmer Webber <cwebber@dustycloud.org>
Date: Wed, 1 Jul 2020 16:36:29 -0400
Subject: [PATCH] gnu: python-grequests: Fix tests by adding zope dependencies.

* gnu/packages/python-web.scm (python-grequests): Add zope
  dependencies to native-inputs for tests.
---
 gnu/packages/python-web.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 030abef9c2..c929e254f7 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -2010,7 +2010,9 @@ library.")
      `(("python-gevent" ,python-gevent)
        ("python-requests" ,python-requests)))
     (native-inputs
-     `(("python-nose" ,python-nose)))
+     `(("python-nose" ,python-nose)
+       ("python-zope.interface" ,python-zope-interface)
+       ("python-zope.event" ,python-zope-event)))
     (home-page "https://github.com/kennethreitz/grequests")
     (synopsis "Python library for asynchronous HTTP requests")
     (description "GRequests is a Python library that allows you to use
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#42158: python-grequests broken, add zope dependencies to fix.
  2020-07-01 20:39 bug#42158: python-grequests broken, add zope dependencies to fix Christopher Lemmer Webber
@ 2020-07-02  7:27 ` Efraim Flashner
  2020-07-02 12:16   ` Christopher Lemmer Webber
  0 siblings, 1 reply; 3+ messages in thread
From: Efraim Flashner @ 2020-07-02  7:27 UTC (permalink / raw)
  To: Christopher Lemmer Webber; +Cc: 42158

[-- Attachment #1: Type: text/plain, Size: 1789 bytes --]

On Wed, Jul 01, 2020 at 04:39:05PM -0400, Christopher Lemmer Webber wrote:
> Fix attached.  Ok to push?
> 

Looks good to me. I will note however that the test suite doesn't seem
to actually be run.

> From 1fc31863857361e9f88d92cbea2099fd7ea03b10 Mon Sep 17 00:00:00 2001
> From: Christopher Lemmer Webber <cwebber@dustycloud.org>
> Date: Wed, 1 Jul 2020 16:36:29 -0400
> Subject: [PATCH] gnu: python-grequests: Fix tests by adding zope dependencies.
> 
> * gnu/packages/python-web.scm (python-grequests): Add zope
>   dependencies to native-inputs for tests.

should be:

* gnu/packages/python-web.scm (python-grequests)[native-inputs]:
Add python-zope.interface, python-zope.event.


> ---
>  gnu/packages/python-web.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
> index 030abef9c2..c929e254f7 100644
> --- a/gnu/packages/python-web.scm
> +++ b/gnu/packages/python-web.scm
> @@ -2010,7 +2010,9 @@ library.")
>       `(("python-gevent" ,python-gevent)
>         ("python-requests" ,python-requests)))
>      (native-inputs
> -     `(("python-nose" ,python-nose)))
> +     `(("python-nose" ,python-nose)
> +       ("python-zope.interface" ,python-zope-interface)
> +       ("python-zope.event" ,python-zope-event)))
>      (home-page "https://github.com/kennethreitz/grequests")
>      (synopsis "Python library for asynchronous HTTP requests")
>      (description "GRequests is a Python library that allows you to use
> -- 
> 2.26.2
> 


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#42158: python-grequests broken, add zope dependencies to fix.
  2020-07-02  7:27 ` Efraim Flashner
@ 2020-07-02 12:16   ` Christopher Lemmer Webber
  0 siblings, 0 replies; 3+ messages in thread
From: Christopher Lemmer Webber @ 2020-07-02 12:16 UTC (permalink / raw)
  To: Efraim Flashner; +Cc: 42158-done

Efraim Flashner writes:

> On Wed, Jul 01, 2020 at 04:39:05PM -0400, Christopher Lemmer Webber wrote:
>> Fix attached.  Ok to push?
>> 
>
> Looks good to me. I will note however that the test suite doesn't seem
> to actually be run.

Huh.  Well at least it's no longer breaking, which is what was happening
for me before.

>> From 1fc31863857361e9f88d92cbea2099fd7ea03b10 Mon Sep 17 00:00:00 2001
>> From: Christopher Lemmer Webber <cwebber@dustycloud.org>
>> Date: Wed, 1 Jul 2020 16:36:29 -0400
>> Subject: [PATCH] gnu: python-grequests: Fix tests by adding zope dependencies.
>> 
>> * gnu/packages/python-web.scm (python-grequests): Add zope
>>   dependencies to native-inputs for tests.
>
> should be:
>
> * gnu/packages/python-web.scm (python-grequests)[native-inputs]:
> Add python-zope.interface, python-zope.event.
>

Done.  Changed and pushed!

>> ---
>>  gnu/packages/python-web.scm | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>> 
>> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
>> index 030abef9c2..c929e254f7 100644
>> --- a/gnu/packages/python-web.scm
>> +++ b/gnu/packages/python-web.scm
>> @@ -2010,7 +2010,9 @@ library.")
>>       `(("python-gevent" ,python-gevent)
>>         ("python-requests" ,python-requests)))
>>      (native-inputs
>> -     `(("python-nose" ,python-nose)))
>> +     `(("python-nose" ,python-nose)
>> +       ("python-zope.interface" ,python-zope-interface)
>> +       ("python-zope.event" ,python-zope-event)))
>>      (home-page "https://github.com/kennethreitz/grequests")
>>      (synopsis "Python library for asynchronous HTTP requests")
>>      (description "GRequests is a Python library that allows you to use
>> -- 
>> 2.26.2
>> 





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-07-02 12:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-01 20:39 bug#42158: python-grequests broken, add zope dependencies to fix Christopher Lemmer Webber
2020-07-02  7:27 ` Efraim Flashner
2020-07-02 12:16   ` Christopher Lemmer Webber

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).