From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id aMekHIsk9V5DKgAA0tVLHw (envelope-from ) for ; Thu, 25 Jun 2020 22:26:19 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id MLJLGIsk9V7jOgAAbx9fmQ (envelope-from ) for ; Thu, 25 Jun 2020 22:26:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D5E359403C4 for ; Thu, 25 Jun 2020 22:26:18 +0000 (UTC) Received: from localhost ([::1]:38336 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joaK0-0007lQ-FV for larch@yhetil.org; Thu, 25 Jun 2020 18:26:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35758) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1joaJn-0007lK-Aq for bug-guix@gnu.org; Thu, 25 Jun 2020 18:26:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58138) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1joaJm-0005HY-L0 for bug-guix@gnu.org; Thu, 25 Jun 2020 18:26:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1joaJm-0006T2-Gj for bug-guix@gnu.org; Thu, 25 Jun 2020 18:26:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#42047: [PATCH 3/3] guix: gc: Support for the Hurd. Resent-From: Bengt Richter Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 25 Jun 2020 22:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42047 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 42047-submit@debbugs.gnu.org id=B42047.159312392224811 (code B ref 42047); Thu, 25 Jun 2020 22:26:02 +0000 Received: (at 42047) by debbugs.gnu.org; 25 Jun 2020 22:25:22 +0000 Received: from localhost ([127.0.0.1]:41451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1joaJ7-0006S7-Ur for submit@debbugs.gnu.org; Thu, 25 Jun 2020 18:25:22 -0400 Received: from imta-36.everyone.net ([216.200.145.36]:40194 helo=imta-38.everyone.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1joaJ5-0006Rz-WF for 42047@debbugs.gnu.org; Thu, 25 Jun 2020 18:25:21 -0400 Received: from pps.filterd (m0004960.ppops.net [127.0.0.1]) by imta-38.everyone.net (8.16.0.27/8.16.0.27) with SMTP id 05PMNfZn021895; Thu, 25 Jun 2020 15:25:18 -0700 X-Eon-Originating-Account: kgGEjAibEPDyM3Z7uCzxxRy5VUbatdFLzkxOyUtpmKA X-Eon-Dm: m0116953.ppops.net Received: by m0116953.mta.everyone.net (EON-AUTHRELAY2 - 53b923b2) id m0116953.5ef25221.33961; Thu, 25 Jun 2020 15:25:14 -0700 X-Eon-Sig: AQMHrIJe9SRKrJklNQIAAAAD,26bbbdd21a23643a69efd8125ce879e2 X-Eip: Wx18lzbkHebB2tg9FZy-0KAMNHPuXaTDje_GKxldEC4 Date: Fri, 26 Jun 2020 00:25:04 +0200 From: Bengt Richter Message-ID: <20200625222504.GA6055@LionPure> References: <20200625203850.25057-1-janneke@gnu.org> <20200625203850.25057-3-janneke@gnu.org> <87pn9mq3bo.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87pn9mq3bo.fsf@gnu.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.687 definitions=2020-06-25_19:2020-06-25, 2020-06-25 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1034 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-2004280000 definitions=main-2006250132 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Bengt Richter Cc: 42047@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -0.51 X-TUID: FYiPBOfVSea1 On +2020-06-25 22:48:43 +0200, Ludovic Courtès wrote: > "Jan (janneke) Nieuwenhuizen" skribis: > > > * guix/store/roots.scm (proc-environ-roots): Handle EIO, for the Hurd. > > * gnu/build/hurd-boot.scm (set-hurd-device-translators): Mount /proc. Add > > symlink to /etc/mtab. Remove duplicate calls to 'scope'. > > Nitpick: I see 3 mostly unrelated patches: (1) fix duplicate called to > ‘scope’, (2) mount /proc, and (3) handle EIO. I think it’s clearer to > view them separately. > > (1) and (2) LGTM! > > > - (mkdir* (scope "dev/vcs/1")) > > - (mkdir* (scope "dev/vcs/2")) > > - (mkdir* (scope "dev/vcs/2")) > > Was it creating like /some/root/some/root/dev/vcs/1? > > > (append-map rhs-file-names > > - (split-on-nul > > - (call-with-input-file environ > > - get-string-all)))) > > + (catch 'system-error > > + (lambda _ > > + (split-on-nul > > + (call-with-input-file environ > > + get-string-all))) > > + (lambda args > > + (if (= EIO (system-error-errno args)) > > + '() > > + (apply throw args)))))) > > This may be papering over a real problem. Before doing that, I think I fear paperings-over ;) Would this idea be worth implementing?: To make sure a "papering over" does not remain un-noticed in an executable, create a catch-wrapping macro that would generate code acting like catch but before entering catch, start emitting complaint messages on and after a calendar date, e.g. checked with (> (car (gettimeofday)) *macro-produced-date-constant*) E.g., something to use in place of catch, like (borrowing above for example) (catch-with-sunset "date-string" "complaint-message" 'system-error (lambda _ (split-on-nul ...etc... (apply throw args)))) "complaint-message" could obviously contain bug#number, commit id, or plea for report, etc. (gettimeofday) on my machine is about 50ns (i.e., often get 20 equal values within the microsecond resolution), so there shouldn't be a performance hit ;) > “we” :-) should investigate why procfs returns EIO in some cases and > look into fixing it. > > Then maybe we can still have the ‘catch’ above, but this time as a > temporary measure and with a reference to the upstream issue/commit. > > WDYT? > > Thank you! > > Ludo’. > > > -- Regards, Bengt Richter