bug#41596: [staging] 'librsvg-next' build failure

bug#41596: [staging] 'librsvg-next' build failure

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1193 bytes --]

On the 'staging' branch, "librsvg-next" (a dependency of GNOME) fails to
compile the 'xml-rs' Rust crate:

--8<---------------cut here---------------start------------->8---
   Compiling xml-rs v0.8.1
error[E0658]: `cfg(doctest)` is experimental and subject to change
 --> /tmp/guix-build-librsvg-2.46.4.drv-0/librsvg-2.46.4/vendor/rust-xml-rs-0.8.1.tar.gz/src/lib.rs:9:7
  |
9 | #[cfg(doctest)]
  |       ^^^^^^^
  |
  = note: for more information, see https://github.com/rust-lang/rust/issues/62210

error[E0658]: `cfg(doctest)` is experimental and subject to change
  --> /tmp/guix-build-librsvg-2.46.4.drv-0/librsvg-2.46.4/vendor/rust-xml-rs-0.8.1.tar.gz/src/lib.rs:13:7
   |
13 | #[cfg(doctest)]
   |       ^^^^^^^
   |
   = note: for more information, see https://github.com/rust-lang/rust/issues/62210

   Compiling downcast-rs v1.1.1
   Compiling rand_core v0.3.1
   Compiling rand_jitter v0.1.4
error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0658`.
error: could not compile `xml-rs`.
warning: build failed, waiting for other jobs to finish...
error: build failed
--8<---------------cut here---------------end--------------->8---

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#41596: [staging] 'librsvg-next' build failure

[Jakub Kądziołka]

[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]

On Fri, May 29, 2020 at 03:17:51PM +0200, Marius Bakke wrote:
> On the 'staging' branch, "librsvg-next" (a dependency of GNOME) fails to
> compile the 'xml-rs' Rust crate:
> 
> --8<---------------cut here---------------start------------->8---
>    Compiling xml-rs v0.8.1
> error[E0658]: `cfg(doctest)` is experimental and subject to change
>  --> /tmp/guix-build-librsvg-2.46.4.drv-0/librsvg-2.46.4/vendor/rust-xml-rs-0.8.1.tar.gz/src/lib.rs:9:7
>   |
> 9 | #[cfg(doctest)]
>   |       ^^^^^^^
>   |
>   = note: for more information, see https://github.com/rust-lang/rust/issues/62210

That's a feature that was stabilized in Rust 1.40. I have a WIP patch
that updates Rust upto 1.43.1, but it's blocked on a LLVM 9 patch backport I
haven't had time to prepare yet. I won't have the time to look into it
properly right now, but here are the relevant links:

https://github.com/rust-lang/llvm-project/commit/7d5e7c023053660ffe494d72ce471e48ecc7f49b
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=959877
https://github.com/rust-lang/llvm-project/pull/43

Regards,
Jakub Kądziołka

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#41596: [staging] 'librsvg-next' build failure

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1587 bytes --]

On Fri, May 29, 2020 at 03:37:36PM +0200, Jakub Kądziołka wrote:
> On Fri, May 29, 2020 at 03:17:51PM +0200, Marius Bakke wrote:
> > On the 'staging' branch, "librsvg-next" (a dependency of GNOME) fails to
> > compile the 'xml-rs' Rust crate:
> > 
> > --8<---------------cut here---------------start------------->8---
> >    Compiling xml-rs v0.8.1
> > error[E0658]: `cfg(doctest)` is experimental and subject to change
> >  --> /tmp/guix-build-librsvg-2.46.4.drv-0/librsvg-2.46.4/vendor/rust-xml-rs-0.8.1.tar.gz/src/lib.rs:9:7
> >   |
> > 9 | #[cfg(doctest)]
> >   |       ^^^^^^^
> >   |
> >   = note: for more information, see https://github.com/rust-lang/rust/issues/62210
> 
> That's a feature that was stabilized in Rust 1.40. I have a WIP patch
> that updates Rust upto 1.43.1, but it's blocked on a LLVM 9 patch backport I
> haven't had time to prepare yet. I won't have the time to look into it
> properly right now, but here are the relevant links:
> 
> https://github.com/rust-lang/llvm-project/commit/7d5e7c023053660ffe494d72ce471e48ecc7f49b
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=959877
> https://github.com/rust-lang/llvm-project/pull/43
> 
> Regards,
> Jakub Kądziołka

In any case, I worked around the issue by changing the doctest
declarations into test declarations. I also bumped rust-xml-rs-0.8 to
0.8.3.


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]