From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QNs0ADVctl4YPAAA0tVLHw (envelope-from ) for ; Sat, 09 May 2020 07:31:01 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id CAPAOUFctl6jJQAA1q6Kng (envelope-from ) for ; Sat, 09 May 2020 07:31:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7CA90940D66 for ; Sat, 9 May 2020 07:31:11 +0000 (UTC) Received: from localhost ([::1]:35092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jXJx0-0007Zp-QO for larch@yhetil.org; Sat, 09 May 2020 03:31:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36638) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jXJws-0007Zd-3B for bug-guix@gnu.org; Sat, 09 May 2020 03:31:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35190) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jXJwr-0002oK-Q7 for bug-guix@gnu.org; Sat, 09 May 2020 03:31:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jXJwr-00008I-NE for bug-guix@gnu.org; Sat, 09 May 2020 03:31:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#41140: =?UTF-8?Q?=E2=80=9Cguix_?= =?UTF-8?Q?system=E2=80=9D?= suggests wrong module import when using =?UTF-8?Q?=E2=80=9Cremove=E2=80=9D?= Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 09 May 2020 07:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41140 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ricardo Wurmus Received: via spool by 41140-submit@debbugs.gnu.org id=B41140.1589009427452 (code B ref 41140); Sat, 09 May 2020 07:31:01 +0000 Received: (at 41140) by debbugs.gnu.org; 9 May 2020 07:30:27 +0000 Received: from localhost ([127.0.0.1]:46736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jXJwI-00007E-IZ for submit@debbugs.gnu.org; Sat, 09 May 2020 03:30:26 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:33554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jXJwF-000071-J4 for 41140@debbugs.gnu.org; Sat, 09 May 2020 03:30:24 -0400 Received: from localhost (80-110-127-207.cgn.dynamic.surfer.at [80.110.127.207]) by dd26836.kasserver.com (Postfix) with ESMTPSA id B25FF336559F; Sat, 9 May 2020 09:30:21 +0200 (CEST) Date: Sat, 9 May 2020 09:30:18 +0200 From: Danny Milosavljevic Message-ID: <20200509093018.426a528d@scratchpost.org> In-Reply-To: <87lfm22il6.fsf@elephly.net> References: <87lfm22il6.fsf@elephly.net> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/siF6GzT7E0/dUp/0y_IldTI"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 41140@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 X-Spam-Score: -1.11 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Scan-Result: default: False [-1.11 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.54032189423746]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.51.188.0/24:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.09), country: US(-0.00), ip: 209.51.188.17(-0.54)]; DWL_DNSWL_BLOCKED(0.00)[209.51.188.17:from]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; RCPT_COUNT_TWO(0.00)[2]; MAILLIST(-0.20)[mailman]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_IN_DNSWL_FAIL(0.00)[209.51.188.17:server fail]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:22989, ipnet:209.51.188.0/24, country:US]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; ARC_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[dannym@scratchpost.org,bug-guix-bounces@gnu.org]; FROM_HAS_DN(0.00)[]; URIBL_BLOCKED(0.00)[elephly.net:email]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; MIME_TRACE(0.00)[0:+,1:+,2:~]; DMARC_NA(0.00)[scratchpost.org]; HAS_LIST_UNSUB(-0.01)[]; RECEIVED_SPAMHAUS_PBL(0.00)[80.110.127.207:received]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.51.188.17:from]; RCVD_COUNT_SEVEN(0.00)[8]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: 06VDTk2JUceE --Sig_/siF6GzT7E0/dUp/0y_IldTI Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ricardo, On Sat, 09 May 2020 00:00:05 +0200 Ricardo Wurmus wrote: > * can we prefer (srfi srfi-1) over (rnrs lists) in the suggestions for = =E2=80=9Cremove=E2=80=9D? If possible, I'd just make it search all the modules with that binding that are available in the search path. It's okay if that's slow--since it's a fatal error case anyway. Then it could say "either (rnrs lists) or (srfi srfi-1), but probably not both". Better than hardcoding preferences... So in short, known-variable-definition shouldn't find the "best" module but rather all modules with such a binding. Also, it sounds like that just searches the currently-loaded modules. Aren't that too few? If we don't want that for some reason, we can just add "srfi srfi-1" to the last "match" form where it already prefers "(gnu ...)", but that's gonna turn into whack-a-mole fast. --Sig_/siF6GzT7E0/dUp/0y_IldTI Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl62XAoACgkQ5xo1VCww uqVODgf/RY3O5EhEpi6QKjaHsQddpRPrnImDhUDTRyNRI0ExSxxvbMbJHlOx5HCj L1DHRyJ6VbZbaA9h0ahez5euls+qj/gGe9bR4mMmMtHtyEyWY153xAQjioYQ9StX RMEfXkpszZ1X5/k3/whTu8nm2y4lwH83J7hznIpZbEyJe1LZVCRNGITP7vzYvaWa 1uyMeIh6YA+0ymd6ufSyNZDPs/L76YgHdnN7+EaPjelCdhgkUf+UwsNbW4cMi+oi T15+8Ze91YLKwX51kFceR3NKZIVJXG+GS3jlNb/gWZanuOxZWodacV8SWdji0k2V IZbo3pnSlvmZnIYyxfZ4dHEoH42ZvQ== =IrRH -----END PGP SIGNATURE----- --Sig_/siF6GzT7E0/dUp/0y_IldTI--