* bug#41019: util-linux runstatedir is not actually a state directory
@ 2020-05-02 9:55 Danny Milosavljevic
2020-05-02 10:14 ` Danny Milosavljevic
0 siblings, 1 reply; 6+ messages in thread
From: Danny Milosavljevic @ 2020-05-02 9:55 UTC (permalink / raw)
To: 41019
[-- Attachment #1: Type: text/plain, Size: 1772 bytes --]
Hi,
util-linux tries to use a "uuidd" daemon to generate uuids. It tries to
communicate with it via socket in $runstatedir/var/run/uuidd/ .
Unfortunately, we do not set runstatedir which means that we'll uselessly
refer to a socket inside util-linux's derivation output directory that never
will be there.
Better would be to refer to /var/run directly, or to remove that functionality
from our version of util-linux.
Git checkout:
repository: /home/dannym/src/guix-raghav/guix
branch: master
commit: 807986a55fc2849d6986efb79f9a015cf4132e09
I stumbled upon that while trying to get F2FS's fsck to work (bug 41015).
We try to build a static version of f2fs-tools (f2fs-tools-static in
guix master), but it retains a reference from mkfs to the non-static
util-linux because of the problem above.
Details of that part of util-linux:
./libuuid/src/uuidd.h: * Definitions used by the uuidd daemon
./libuuid/src/uuidd.h:#define UUIDD_DIR _PATH_RUNSTATEDIR "/uuidd"
./libuuid/src/uuidd.h:#define UUIDD_PIDFILE_PATH UUIDD_DIR "/uuidd.pid"
./libuuid/src/uuidd.h:#define UUIDD_PATH "/usr/sbin/uuidd"
./libuuid/src/gen_uuid.c:#include "uuidd.h"
./libuuid/src/gen_uuid.c: * Try using the uuidd daemon to generate the UUID
./libuuid/src/gen_uuid.c: * Tries to guarantee uniqueness of the generated UUIDs
by obtaining them from the uuidd daemon,
./libuuid/src/gen_uuid.c: * or, if uuidd is not usable, by using the global cloc
k state counter (see get_clock()).
UUIDD_SOCKET_PATH
./libuuid/src/uuidd.h:#define UUIDD_SOCKET_PATH UUIDD_DIR "/request"
./libuuid/src/uuidd.h:#define UUIDD_DIR _PATH_RUNSTATEDIR "/uuidd"
/gnu/store/xymkwf57x988q8cny2is1dgzrbr9xdfi-util-linux-2.34/var/run/uuidd
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#41019: util-linux runstatedir is not actually a state directory
2020-05-02 9:55 bug#41019: util-linux runstatedir is not actually a state directory Danny Milosavljevic
@ 2020-05-02 10:14 ` Danny Milosavljevic
2020-05-03 22:14 ` Danny Milosavljevic
0 siblings, 1 reply; 6+ messages in thread
From: Danny Milosavljevic @ 2020-05-02 10:14 UTC (permalink / raw)
To: 41019
[-- Attachment #1: Type: text/plain, Size: 598 bytes --]
Note: once that bug is fixed, still have to add:
diff --git a/gnu/system/linux-initrd.scm b/gnu/system/linux-initrd.scm
index 44ee4f10aa..6a1840dbf6 100644
--- a/gnu/system/linux-initrd.scm
+++ b/gnu/system/linux-initrd.scm
@@ -245,6 +245,9 @@ FILE-SYSTEMS."
'())
,@(if (find (file-system-type-predicate "jfs") file-systems)
(list jfs_fsck/static)
+ '())
+ ,@(if (find (file-system-type-predicate "f2fs") file-systems)
+ (list f2fs-fsck/static)
'())))
(define-syntax vhash ;TODO: factorize
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#41019: util-linux runstatedir is not actually a state directory
2020-05-02 10:14 ` Danny Milosavljevic
@ 2020-05-03 22:14 ` Danny Milosavljevic
2020-05-05 16:17 ` Leo Famulari
0 siblings, 1 reply; 6+ messages in thread
From: Danny Milosavljevic @ 2020-05-03 22:14 UTC (permalink / raw)
To: 41019
[-- Attachment #1: Type: text/plain, Size: 735 bytes --]
> Note: once that bug is fixed, still have to add:
>
> diff --git a/gnu/system/linux-initrd.scm b/gnu/system/linux-initrd.scm
> index 44ee4f10aa..6a1840dbf6 100644
> --- a/gnu/system/linux-initrd.scm
> +++ b/gnu/system/linux-initrd.scm
> @@ -245,6 +245,9 @@ FILE-SYSTEMS."
> '())
> ,@(if (find (file-system-type-predicate "jfs") file-systems)
> (list jfs_fsck/static)
> + '())
> + ,@(if (find (file-system-type-predicate "f2fs") file-systems)
> + (list f2fs-fsck/static)
> '())))
Added that in guix master in commit 33eab4a10dcd2a6580f168f18455df1d4653d14b.
Also added horrible workaround for this bug in commit
da09c63e78ebebeabb347f483d7284b87ff51c2f.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#41019: util-linux runstatedir is not actually a state directory
2020-05-03 22:14 ` Danny Milosavljevic
@ 2020-05-05 16:17 ` Leo Famulari
2020-05-05 17:16 ` Danny Milosavljevic
0 siblings, 1 reply; 6+ messages in thread
From: Leo Famulari @ 2020-05-05 16:17 UTC (permalink / raw)
To: Danny Milosavljevic; +Cc: 41019
On Mon, May 04, 2020 at 12:14:44AM +0200, Danny Milosavljevic wrote:
> Also added horrible workaround for this bug in commit
> da09c63e78ebebeabb347f483d7284b87ff51c2f.
Do you want to leave the bug ticket open? Or is it "done"?
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#41019: util-linux runstatedir is not actually a state directory
2020-05-05 16:17 ` Leo Famulari
@ 2020-05-05 17:16 ` Danny Milosavljevic
2020-05-05 18:08 ` Marius Bakke
0 siblings, 1 reply; 6+ messages in thread
From: Danny Milosavljevic @ 2020-05-05 17:16 UTC (permalink / raw)
To: Leo Famulari; +Cc: 41019
[-- Attachment #1: Type: text/plain, Size: 388 bytes --]
I'd prefer if we left the bug report still open and eventually fixed this
bug--although util-linux has a huge number of dependents.
The workaround is just removing the store reference from the executable file,
after the fact.
I mean it works because then libuuid.a can't find the socket for uuidd using
the name "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX", but that's not the right way :P
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#41019: util-linux runstatedir is not actually a state directory
2020-05-05 17:16 ` Danny Milosavljevic
@ 2020-05-05 18:08 ` Marius Bakke
0 siblings, 0 replies; 6+ messages in thread
From: Marius Bakke @ 2020-05-05 18:08 UTC (permalink / raw)
To: Danny Milosavljevic, Leo Famulari; +Cc: 41019
[-- Attachment #1: Type: text/plain, Size: 343 bytes --]
Danny Milosavljevic <dannym@scratchpost.org> writes:
> I'd prefer if we left the bug report still open and eventually fixed this
> bug--although util-linux has a huge number of dependents.
You could create a 'util-linux/fixed' variable for this package if you
know how to fix it, and merge it with util-linux in the next
core-updates round.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-05 18:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-02 9:55 bug#41019: util-linux runstatedir is not actually a state directory Danny Milosavljevic
2020-05-02 10:14 ` Danny Milosavljevic
2020-05-03 22:14 ` Danny Milosavljevic
2020-05-05 16:17 ` Leo Famulari
2020-05-05 17:16 ` Danny Milosavljevic
2020-05-05 18:08 ` Marius Bakke
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).